[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419868. FabioRS marked an inline comment as done. FabioRS added a comment. I did some simple refactor on the code I did for the function-method and it fixed the namespace syntactic problem too. I am not sure if it expands the pull request scope. CHANGES SI

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419616. FabioRS marked 6 inline comments as done. FabioRS set the repository for this revision to rG LLVM Github Monorepo. FabioRS added a comment. namespace ns { int y = 1; void foo(); } void ns::foo() {[[int x; y++; ]]} namespace ns { int y = 1; voi

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS added a comment. In D122698#3418018 , @sammccall wrote: > Thanks! I'll look at the changes in the morning, just wanted to mention one > thing > > In D122698#3417946 , @FabioRS wrote: > >> I can not run th

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419296. FabioRS added a comment. Full patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122698/new/ https://reviews.llvm.org/D122698 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/unittests/tweaks

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419290. FabioRS marked 14 inline comments as done. FabioRS added a comment. I am not sure about the LangOptions object, the NestedNameSpecifier needs it to correctly print the nested classes-name and not sure about the getEnclosing() too. I can not run the

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS created this revision. FabioRS added a reviewer: sammccall. FabioRS added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. FabioRS requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryu