[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

2021-06-11 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 created this revision. DNS320 added reviewers: aaron.ballman, njames93, alexfh. DNS320 added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. DNS320 requested review of this revision. Herald added a subscriber: cfe-commits. This check tr

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

2021-06-10 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 added a comment. Friendly Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102576/new/ https://reviews.llvm.org/D102576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-05-24 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 added a comment. Dear reviewers, Since this work was conducted as part of a bachelor's thesis, which has to be handed in on the 18th of June 2021, we wanted to add a friendly ping to this patch. It would make us, the thesis team, proud to state that some of our work was accepted and inclu

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

2021-05-19 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 updated this revision to Diff 346360. DNS320 added a comment. I updated the check according to the last review. It ignores now do-while statements which are inside a macro and have a false condition. (false condition part was taken from bugprone-terminating-continue

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

2021-05-16 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 created this revision. DNS320 added reviewers: aaron.ballman, njames93, alexfh. DNS320 added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. DNS320 requested review of this revision. This simple check flags do-while statements according

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-04-30 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 updated this revision to Diff 341929. DNS320 added a comment. Removed a link to the ES.26 C++ Core Guideline in the documentation part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100092/new/ https://reviews.llvm.org/D100092 Files: clan

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-04-30 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 marked an inline comment as done. DNS320 added a comment. In D100092#2726808 , @steveire wrote: > I implemented something like this recently too. The code I was trying to > refactor was something like > > auto ii = 0; > for (ii = 0; ii < thing

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-04-30 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 updated this revision to Diff 341784. DNS320 added a comment. Renamed the IsInsideMatchedForStmt() function according to a comment from the build system. Changed a data type to "auto" according to a comment from Eugene.Zelenko. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-04-29 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/DeclareLoopVariableInTheInitializerCheck.cpp:28 + + diag(MatchedForStmt->getBeginLoc(), + "Prefer to declare a loop variable in the initializer part of a " Eugene.Zel

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-04-29 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 updated this revision to Diff 341492. DNS320 marked 7 inline comments as done. DNS320 added a comment. I updated the check according to the last review. The check should now fully implement the defined enforcement chapter from the ES.74 C++ Core Guideline. About searching for declRefExpr

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-04-09 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 added a comment. Thank you for your reviews. I will work on your comments and write back soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100092/new/ https://reviews.llvm.org/D100092 ___ cfe-co

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

2021-04-08 Thread Fabian Thurnheer via Phabricator via cfe-commits
DNS320 created this revision. DNS320 added reviewers: aaron.ballman, njames93, alexfh. DNS320 added a project: clang-tools-extra. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. DNS320 requested review of this revision. This check implements the ES.74