[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely added a comment. In D91000#3862210 , @whisperity wrote: > In D91000#3861942 , @aaron.ballman > wrote: > >> My concern with that approach was that we pay the full expense of doing the >> matches only ge

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 485774. futogergely marked 5 inline comments as done. futogergely removed a reviewer: ktomi996. futogergely added a comment. Addressing review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Fi

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely added a comment. Hi, sorry for the late answer, did not have time to check this in the last few weeks. I will try to address all of the remaining comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 440259. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt clang-tools-extra/clan

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 440216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt clang-tools-extra/clan

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely added a comment. In D91000#3612090 , @Eugene.Zelenko wrote: > Locations for tests and check documentation was changed recently. Please > rebase from `main` and adjust your code accordingly. Done. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 440202. futogergely added a comment. updates based on comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/c

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely marked 7 inline comments as done. futogergely added a comment. In D91000#3506605 , @whisperity wrote: > Just one question if you could try this out for me: what happens if you run > `clang-tidy a.c b.c` (two TUs in the invocation) where **one

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 421435. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt clang-tools-extra/clan

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 414359. futogergely retitled this revision from "[clang-tidy] Add cert-msc24-msc33-c checker." to "[clang-tidy] Add bugprone-unsafe-functions checker.". futogergely added a comment. Checker has been moved to bugprone. CHANGES SINCE LAST ACTION https:/

[PATCH] D91000: [clang-tidy] Add cert-msc24-msc33-c checker.

futogergely added a comment. Herald added a project: All. In D91000#3313892 , @balazske wrote: > Now it would be better to have a checker called `UnsafeFunctionsCheck` > (probably in bugprone) and add the cert checkers "msc24-c" and "msc33-c" as > aliase

[PATCH] D91000: [clang-tidy] Add cert-msc24-msc33-c checker.

futogergely updated this revision to Diff 407819. futogergely marked an inline comment as done. futogergely retitled this revision from "[clang-tidy] Add cert-msc24-c checker." to "[clang-tidy] Add cert-msc24-msc33-c checker.". futogergely edited the summary of this revision. futogergely added a c

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked 14 inline comments as done and an inline comment as not done. futogergely added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ObsolescentFunctionsCheck.cpp:41-42 + + // Matching the `gets` deprecated function without replacement. + auto Depr

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely added a comment. In D91000#3225369 , @balazske wrote: > The functions `asctime` and `asctime_r` are discouraged according to CERT > MSC33-C rule. These could be added to this check as well. There is a clang SA > checker `SecuritySyntaxChecker

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely added a comment. Maybe we could remove the check for setbuf() and rewind() functions, making this a pure Annex K checker. There is an overlapping with another recommendation (https://wiki.sei.cmu.edu/confluence/display/c/ERR07-C.+Prefer+functions+that+support+error+checking+over+equ

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely added a comment. "It seems like none of these projects actually use the annex K functions, which is not really a surprise. VLC and lighttpd seems to use it. @futogergely could you please run your check on those projects?" **lighttpd**: the checker issued 386 warnings. The reason is

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely added a comment. "L129 and L135 are uncovered by tests. The rest of the lines are covered by tests, according to lcov." This happens if __STDC_WANT_LIB_EXT1__ is defined empty (L129) or __STDC_WANT_LIB_EXT1__ is not literal (numeric constant, ...). CHANGES SINCE LAST ACTION https

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked an inline comment as done. futogergely added a comment. In D91000#3161296 , @whisperity wrote: > Should/does this work in C++ mode for `std::whatever`? Right now the checker finds the functions in the global namespace only. The recomme

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked an inline comment as done. futogergely added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ObsolescentFunctionsCheck.cpp:48 + // Matching functions with safe replacements in annex K. + auto FunctionNamesWithAnnexKReplacementMatcher = hasAnyNa

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely updated this revision to Diff 391604. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-tools-extra/clang-tidy/cert/CMakeLists.txt clang-tools-extra/clang-tidy/cert/

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely updated this revision to Diff 390309. futogergely added a comment. x64 debian failed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-tools-extra/clang-tidy/cert/CM

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely updated this revision to Diff 390270. futogergely retitled this revision from "[clang-tidy] CERT MSC24-C Obsolescent Functions check" to "[clang-tidy] Add cert-msc24-c checker.". futogergely edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D910

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103595/new/ https://reviews.llvm.org/D103595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely updated this revision to Diff 349508. futogergely added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103595/new/ https://reviews.llvm.org/D103595 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaTemplate/instantiate-local-class.cpp Index: cla

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely updated this revision to Diff 349480. futogergely added a comment. formatting in instantiate-local-class.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103595/new/ https://reviews.llvm.org/D103595 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaTemplate/instantiate

[PATCH] D103595: [clang] Correct MarkFunctionReferenced for local class

futogergely created this revision. futogergely added a reviewer: rsmith. futogergely requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Minor correction after commit 4a941e25f2b57f85eef00a9cbfbc2569639570ad. If during the instantiation of a l