https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/126393
From c5d22c2dfba00742892dca6bfc84dd9e70b73d2a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 24 Dec 2023 21:01:32 -0500
Subject: [PATCH] [clang-tidy] Fixed clang-tidy rew
felix642 wrote:
https://github.com/llvm/llvm-project/pull/126393
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/126393
Rewriter would not properly fix files if they were symlinked and using --fix
with clang-tidy would overwrite the symlink with the corrections rather than
the file.
With these changes the Rewriter now properly
https://github.com/felix642 closed
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/76350
From 0a5ae9bfff7597794889c93e4da5789714be3a4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 24 Dec 2023 21:01:32 -0500
Subject: [PATCH] [clang][tidy] Fixed clang-tidy rew
felix642 wrote:
Probably because I did not tag this PR correctly so no one reviewed it. I'll
close it and reopen it with the proper tag.
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/felix642 closed
https://github.com/llvm/llvm-project/pull/111424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
Closing this PR since I no longer think this is an option that we need.
https://github.com/llvm/llvm-project/pull/111424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 closed
https://github.com/llvm/llvm-project/pull/111453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
> If I understand correctly, this situation is when CMake is configured for
> another compiler (e.g., GCC) but is also instructed to run clang-tidy, but
> then CMake hands clang-tidy the command line arguments it was handing to GCC,
> and clang-tidy is giving hard errors for th
felix642 wrote:
> +- some people may want to control this behavior and keep the explicit cast
> for enums, WDYT?
I can see why some people might want to explicitly cast the enum to its
underlying type.
I could add the option `WarnEnumCastToUnderlyingType` which could default to
`true`.
https
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/111424
From a786f626beb418cf6b8847c6250f0490b60affdb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Mon, 7 Oct 2024 15:27:36 -0400
Subject: [PATCH 1/4] [clang-tidy] Improved readabil
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/111453
From 5cdc27e543b0f4dea3dd3848d974a27614aea713 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Mon, 7 Oct 2024 19:22:44 -0400
Subject: [PATCH 1/2] [clang-tidy] New option to rem
@@ -106,6 +106,9 @@ Improvements to clang-tidy
- Improved :program:`run-clang-tidy.py` script. Fixed minor shutdown noise
happening on certain platforms when interrupting the script.
+- Improved :program:`clang-tidy` by adding the option
`CompilationArgsToRemoveRegex`
-
felix642 wrote:
> sounds better as the commit description.
I agree, thank you for the suggestion.
>The CI failure is probably because the implicit type for E3 is not unsigned
>int on Windows.
You are right. I could not find a way to make this test platform independent. I
would either have to i
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/111424
From a786f626beb418cf6b8847c6250f0490b60affdb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Mon, 7 Oct 2024 15:27:36 -0400
Subject: [PATCH 1/3] [clang-tidy] Improved readabil
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/111453
When using clang-tidy from a compilation database, some options might not be
recognized by clang if the compilation database was generated for another
compiler. This forces the user to add conditional code in
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/111424
From a786f626beb418cf6b8847c6250f0490b60affdb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Mon, 7 Oct 2024 15:27:36 -0400
Subject: [PATCH] [clang-tidy] Improved readability
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/111424
From 9c28fc517238c157a20307bcb5fd39201d0edc9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Mon, 7 Oct 2024 15:27:36 -0400
Subject: [PATCH] [clang-tidy] Improved readability
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/111424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/111424
Fixed false negatives with readability-redundant-casting when the underlying
types are the same and the option IgnoreTypeAlias is set to true.
Fixes #37
From 310315a294b9fa0f1c08ab242221950c0c3cd0a5 Mon S
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/109741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/109741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -183,6 +183,10 @@ Changes in existing checks
by adding the option `UseUpperCaseLiteralSuffix` to select the
case of the literal suffix in fixes.
+- Improved :doc:`readability-redundant-casting
+ ` check to
+ exclude `CXXParenListInitExpr` for the source expression mat
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/5] [clang-tidy] Improved --verify
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/85591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = "
[-verify-config]\n";
static bool verifyChecks(const StringSet<> &AllChecks, StringRef CheckGlob,
StringRef Source) {
- llvm::StringRef Cur, Rest;
+ GlobList Globs(CheckG
@@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = "
[-verify-config]\n";
static bool verifyChecks(const StringSet<> &AllChecks, StringRef CheckGlob,
StringRef Source) {
- llvm::StringRef Cur, Rest;
+ GlobList Globs(CheckG
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/4] [clang-tidy] Improved --verify
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From 72f2b398d6f41372dc84579a83d273398884c869 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH] [clang-tidy] Improved modernize-us
felix642 wrote:
Thank you for the review @SimplyDanny, as per your suggestion, I've rewrote
part of my fix to unify the parsing logic rather than updating the duplicated
code. The method now uses the GlobList which already handles correctly the
regexes generation from the list of checks.
http
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/3] [clang-tidy] Improved --verify
felix642 wrote:
@PiotrZSL I've squashed my changed. When you'll have time, I think we can merge
this PR.
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From e67122cb2c17395e863725cc25d99afe6c7bb48c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH] [clang-tidy] Improved modernize-us
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/85591
Specifying checks using the literal style (|) in the clang-tidy config file is
currently supported but was not implemented for the --verify-config options.
This means that clang-tidy would work properly but, us
https://github.com/felix642 ready_for_review
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From f1d957413bcc81e9ced06ad40570859769f4c1c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/6] [clang-tidy] Improved moderniz
https://github.com/felix642 converted_to_draft
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
Thank you for the quick review @PiotrZSL. I've implemented the proposed changes
and rebased on top of main. We can wait a few days to see if someone else has
some comments to add and then we should be ready to merge
https://github.com/llvm/llvm-project/pull/82947
_
https://github.com/felix642 ready_for_review
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From f1d957413bcc81e9ced06ad40570859769f4c1c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/5] [clang-tidy] Improved moderniz
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/4] [clang-tidy] Improved moderniz
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/3] [clang-tidy] Improved moderniz
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 00885ea60007a1da88f9d476e14252f950f358a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r
felix642 wrote:
Nevermind I broke the documentation.. Hold on
https://github.com/llvm/llvm-project/pull/82952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
> Rebase, and could be merged.
Done, thank you for the quick review.
https://github.com/llvm/llvm-project/pull/82952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 00885ea60007a1da88f9d476e14252f950f358a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH] [clang-tidy] bugprone-unused-retur
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 5e30d84368a05bab31a26c413fdc8092449f4111 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 86bc8a57fd56a6b2593af8bcf85d50bbc0ce984e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r
https://github.com/felix642 converted_to_draft
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/2] [clang-tidy] Improved moderniz
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/82952
The parameter `CheckedReturnTypes` now supports regexes
Fixes #63107
From 86bc8a57fd56a6b2593af8bcf85d50bbc0ce984e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH] [clang-tidy] Improved modernize-us
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/82947
The check needs a parent decl to match but if the typedef is in a function, the
parent is a declStmt which is not a decl by itself. Improved the matcher to
match on either a decl or a declstmt and extract the d
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/81423
From 0fa56a4176205337270d15049dc34a8508488905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 8 Feb 2024 17:07:38 -0500
Subject: [PATCH 1/2] =?UTF-8?q?[clang-tidy]=C2=A0Rem
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/81423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -47,6 +47,9 @@ AST_POLYMORPHIC_MATCHER_P(isInternalLinkage,
return VD->isInAnonymousNamespace();
llvm_unreachable("Not a valid polymorphic type");
}
+
+AST_MATCHER(clang::VarDecl, hasInitialization) { return Node.hasInit(); }
felix642 wrote:
Simply di
@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/81423
From 0fa56a4176205337270d15049dc34a8508488905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 8 Feb 2024 17:07:38 -0500
Subject: [PATCH] =?UTF-8?q?[clang-tidy]=C2=A0Removed
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/81423
Updated the check to ignore point static data members with in class initializer
since removing the inline specifier would generate a compilation error
Fixes #80684
From 45c89e269bd37e298dd12035dc78c986fa47e8
https://github.com/felix642 approved this pull request.
LGTM,
There is still some work to do to support more cases like ternary operators and
if/else statements, but I think we have a decent foundation to work on and we
can add these cases later in other PRs.
https://github.com/llvm/llvm-proj
@@ -0,0 +1,189 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,189 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,238 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,238 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,195 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,195 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,195 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 requested changes to this pull request.
Added a few more comments regarding some nits but we're almost there
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/felix642 deleted
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 requested changes to this pull request.
Looks good! I was able run your code on llvm's project and I'm happy with the
changes that I see. There is maybe one more use case that we should check
before I am ready to approve (Except what Piotr has already highlighted)
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
@11happy I was testing with `d5b8dc25598` but this seems to be working
properly now. I would assume that this has been fixed in your latest commits
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commi
felix642 wrote:
@PiotrZSL would you be able to commit those changes for me please ?
https://github.com/llvm/llvm-project/pull/78859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
@11happy I've compiled your code to test it on llvm's project and clang-tidy
seems to sometimes crash. Would you be able to have a look before we merge
this PR ?
```
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and
include the crash backtrace.
Sta
@@ -0,0 +1,175 @@
+// RUN: %check_clang_tidy %s readability-use-std-min-max %t
+
+#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b))
+
+constexpr int myConstexprMin(int a, int b) {
+ return a < b ? a : b;
+}
+
+constexpr int myConstexprMax(int a, int b) {
+ return a > b ? a : b;
@@ -0,0 +1,175 @@
+// RUN: %check_clang_tidy %s readability-use-std-min-max %t
+
+#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b))
+
+constexpr int myConstexprMin(int a, int b) {
+ return a < b ? a : b;
+}
+
+constexpr int myConstexprMax(int a, int b) {
+ return a > b ? a : b;
https://github.com/felix642 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
Rebased with main to fix merge conflicts.
https://github.com/llvm/llvm-project/pull/78859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/78859
From 57cbce14d5836e57f677fa1fef7214dd2663262a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sat, 20 Jan 2024 15:29:06 -0500
Subject: [PATCH 1/2] [clang-tidy] Ignore user-defin
@@ -56,11 +56,14 @@ void IntegerTypesCheck::registerMatchers(MatchFinder
*Finder) {
// http://google.github.io/styleguide/cppguide.html#64-bit_Portability
// "Where possible, avoid passing arguments of types specified by
// bitwidth typedefs to printf-based APIs."
- Fin
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/78859
From 8ea205ae2324d67f9adaf30d5662d2cde2096534 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sat, 20 Jan 2024 15:29:06 -0500
Subject: [PATCH 1/2] [clang-tidy] Ignore user-defin
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/78859
User-defined literals do not accept u?intXX(_t)? variables. So the check should
not emit a warning.
Fixes #54546 #25214
From 8ea205ae2324d67f9adaf30d5662d2cde2096534 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=
https://github.com/felix642 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,135 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,139 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,139 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,139 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 requested changes to this pull request.
@11happy I've left a few more comments regarding some minor issues with your
check. Please have a look and let me know what you think.
https://github.com/llvm/llvm-project/pull/77816
@@ -0,0 +1,175 @@
+// RUN: %check_clang_tidy %s readability-use-std-min-max %t
+
+#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b))
+
+constexpr int myConstexprMin(int a, int b) {
+ return a < b ? a : b;
+}
+
+constexpr int myConstexprMax(int a, int b) {
+ return a > b ? a : b;
@@ -0,0 +1,129 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 286c4445f8cba6ea2f49fb9e8f732f04ebdb6c97 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH] =?UTF-8?q?[clang-tidy]=C2=A0Added=
1 - 100 of 159 matches
Mail list logo
