[PATCH] D130476: [NFC] Fix some C++20 warnings

Godin added a comment. @aaron.ballman thanks for the review! could you please commit this on my behalf since I do not have commit rights? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130476/new/ https://reviews.llvm.org/D130476

[PATCH] D130476: [NFC] Fix some C++20 warnings

Godin created this revision. Herald added a project: All. Godin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch when using CMAKE_CXX_STANDARD=20 Microsoft compiler produces following warnings clang\include\clang/Basic/D

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

Godin added a comment. Thank you for the review @sammccall ! Can someone please commit this on my behalf since I do not have commit rights? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116904/new/ https://reviews.llvm.org/D116904

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

Godin created this revision. Godin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch when using CMAKE_CXX_STANDARD=20 and MSVC 19.30.30705.0 compilation fails with clang\lib\Tooling\Syntax\Tree.cpp(347): error C2666: 'cla

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115355/new/ https://reviews.llvm.org/D115355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin added a comment. Can someone please commit this on my behalf since I do not have commit rights? Comment at: clang/lib/AST/ASTImporter.cpp:8400-8403 + AttrArgImporter(const AttrArgImporter &) = delete; + AttrArgImporter(AttrArgImporter &&) = default; AttrArgImporter &

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin added a comment. Thank you for the review @shafik ! As a note: this change is similar to the https://reviews.llvm.org/rG95d0d8e9e9d10da3cfa503fbba405e740aea3cc1 by @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115355/new/ https://re

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Godin created this revision. Herald added subscribers: dexonsmith, martong, hiraditya, MatzeB. Herald added a reviewer: shafik. Godin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. See https://wg21.link/cwg2237 Reposito