[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal added a comment. @tbaeder Thank you! :^) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal added a comment. In D141283#4065117 , @tbaeder wrote: > AFAIK we need a name and an email address so the commit can be attributed > properly. The commit can be attributed to Evan Smal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal added a comment. Hi @shafik! Thanks for the review. I don't have commit access and am unsure what I should do to get this committed. Can you let me know what I need to do next? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ ht

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal updated this revision to Diff 488012. evansmal added a comment. Added additional test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 Files: clang/include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal added a comment. Thanks all for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal marked an inline comment as done. evansmal added a comment. In D141283#4038703 , @tbaeder wrote: > When grepping `clang/test/` for "for char array is too long", I get a bunch > of other hits for this diagnostic, are the those tests not failing

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal updated this revision to Diff 487443. evansmal added a comment. Improve specificity of the diagnostic message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 Files: clang/include/clang/Basic/D

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal added a comment. In D141283#4036449 , @shafik wrote: > Thank you for this diagnostic fix, please make sure you update > `clang/test/CXX/dcl.decl/dcl.init/dcl.init.string/p2.cpp`. I noticed that there are also some tests in: //clang/test/SemaCX

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal created this revision. evansmal added a reviewer: clang. evansmal added a project: clang. Herald added a project: All. evansmal requested review of this revision. Herald added a subscriber: cfe-commits. This patch improves the diagnostic message "initializer-string for char array is too