[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

2019-10-28 Thread Eugene Sedykh via Phabricator via cfe-commits
sedykh.eugene added a comment. In D69388#1723589 , @aaron.ballman wrote: > Thank you for the patch, and welcome! LGTM aside from a minor nit. Do you > need someone to commit this on your behalf? Thank you. You mean I don't rights? Then, yes, I need som

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

2019-10-28 Thread Eugene Sedykh via Phabricator via cfe-commits
sedykh.eugene updated this revision to Diff 226677. sedykh.eugene added a comment. I removed using. Not a big deal. Thank you for the reviews! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69388/new/ https://reviews.llvm.org/D69388 Files: clang-t

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

2019-10-24 Thread Eugene Sedykh via Phabricator via cfe-commits
sedykh.eugene created this revision. sedykh.eugene added reviewers: MyDeveloperDay, JonasToth. sedykh.eugene added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, xazax.hun. Herald added a project: clang. Current implementation suggests to add [[nodiscard]] to methods