[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added a comment. In D99250#2682598 , @DavidSpickett wrote: > This change has caused a test failure in lldb. On our Arm bots: > http://lab.llvm.org:8011/#/builders/96/builds/6582 > Also on Linux x86_64: http://lab.llvm.org:8011/#/builders/68/builds/1

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62fa9b9388aa: [DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions. (authored by Esme). Repository: rG LLVM Github Monorep

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added a comment. If there are no more comments, I'll commit the patch soon. What do you think? @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/ https://reviews.llvm.org/D99250 ___

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plus_p

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plus_p

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme updated this revision to Diff 334057. Esme added a comment. Addressed Zheng's comments. Thank you all for your comments. Since no DWARF consumers has dialect-specific behavior, the patch will proceed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added a comment. Thx! @aprantl The motivation of the patch came from the crash of tag name mismatching when using DBX under AIX. And modifying the debugger doesn't seem to make sense? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/

[PATCH] D99250: [DebugInfo] Fix the C++ language tags for Dwarf versions.

Esme created this revision. Esme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Solve the problem of tags and version mismatch Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99250 Files: clang/lib/CodeGen/CGDebugInfo

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffa67873a3f9: [PowerPC] Add variants of 64-bit vector types for vec_sel. (authored by Esme). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

Esme created this revision. Esme added reviewers: steven.zhang, nemanjai, qiucf, shchenz, PowerPC. Herald added a subscriber: kbarton. Esme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch added the following variants of vec_sel.

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3475f5b91c8: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp). (authored by Esme). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2584 +// Vector test software functions. +def : Pat<(i32 (int_ppc_vsx_xvtdivdp v2f64:$A, v2f64:$B)), steven.zhang wrote: > Vector test for software divide and sqrt I'll update it whe

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme added a comment. In D88278#2306618 , @amyk wrote: > Overall I think this LGTM. > > Please correct me if I am wrong but I think the description of the functions > need to be updated to: > > int vec_test_swdiv(vector double v1, vector double v2); >

[PATCH] D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).

Esme created this revision. Esme added reviewers: steven.zhang, masoud.ataei, shchenz, jsji, qiucf. Herald added subscribers: llvm-commits, cfe-commits, kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. Esme requested review of this revision. This patch implements the builtins for