Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

erik65536 added a comment. I don't see any other issues. Thanks for fixing this. http://reviews.llvm.org/D20903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

erik65536 added a comment. > The POSIX version of strerror_r() returns 0 on success, and any other value > indicates an error (Reference > ). I should have been more explicit when I wrote this recommendation. Checking if

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

erik65536 added a subscriber: erik65536. erik65536 added a comment. The C++ spec states that `error_category::message()` shall not change the value of `errno` (See section 19.5). So `errno` will have to be saved and restored if `strerror_r()` fails. The POSIX version of `strerror_r()` returns 0

Re: [PATCH] D17621: [clang-format] Detect constructor initializers preceded by `noexcept`.

erik65536 added a comment. I do not have commit access. http://reviews.llvm.org/D17621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17621: [clang-format] Detect constructor initializers preceded by `noexcept`.

erik65536 updated this revision to Diff 49155. erik65536 added a comment. Change is() || is() to isOneOf() and added a test case. http://reviews.llvm.org/D17621 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D17621: [clang-format] Detect constructor initializers preceded by `noexcept`.

erik65536 created this revision. erik65536 added reviewers: djasper, klimek. erik65536 added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D17621 Files: lib/Format/TokenAnnotator.cpp Index: lib/Format/TokenAnnotator.cpp ==