[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

2020-12-08 Thread Eric Seidel via Phabricator via cfe-commits
gridaphobe added a comment. Yes please! I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org/D91975 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

2020-12-06 Thread Eric Seidel via Phabricator via cfe-commits
gridaphobe marked 2 inline comments as done. gridaphobe added a comment. Herald added a subscriber: shchenz. I've added the non-narrowing tests, are we good to merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

2020-11-24 Thread Eric Seidel via Phabricator via cfe-commits
gridaphobe updated this revision to Diff 307348. gridaphobe added a comment. Add a couple passing tests involving typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org/D91975 Files: clang-tools-extra/clang-t

[PATCH] D91975: clang-tidy: detect narrowing conversions involving typedefs

2020-11-23 Thread Eric Seidel via Phabricator via cfe-commits
gridaphobe created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. gridaphobe requested review of this revision. The check 'cppcoreguidelines-narrowing-conversions' does not detect conversions involving typedef. This notably includes the stan