[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

ebiggers wrote: Thanks @topperc! https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

ebiggers wrote: Updated to add my Co-authored-by, as the original author is `Brandon Wu `. Someone who has permission to do so will need to approve the GitHub Actions workflow, and merge the commit once everything is ready. https://github.com/llvm/llvm-project/pull/74213 _

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

ebiggers wrote: No, I don't have commit access. https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

ebiggers wrote: Rebased to resolve conflicts again https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

@@ -143,6 +143,22 @@ on support follow. ``Zve64f`` Supported ``Zve64d`` Supported ``Zvfh`` Supported + ``Zvbb`` Assembly Support ebiggers wrote: Done https://github.com/llvm/llvm-project/pull/74213 __

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

ebiggers wrote: Rebased onto latest upstream because the `clang-format` warning is fixed there. No changes https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

ebiggers wrote: The `clang-format` warning is from existing code, not from this pull request. https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

ebiggers wrote: > To be safe, I think we should have an experimental tag to guard the > intrinsics, while the extension is ratified and do indeed don't need the > experimental. This is already part of the pull request. I've updated the commit message and pull request description to make it cl

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

@@ -485,7 +485,7 @@ class RVVIntrinsic { // RVVRequire should be sync'ed with target features, but only // required features used in riscv_vector.td. -enum RVVRequire : uint16_t { +enum RVVRequire : unsigned int { ebiggers wrote: Done. Note, I also changed t

[llvm] [clang] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

@@ -370,6 +371,10 @@ bool RISCVTargetInfo::handleTargetFeatures(std::vector &Features, ISAInfo = std::move(*ParseResult); } + if (std::find(Features.begin(), Features.end(), "+experimental") != ebiggers wrote: Done using `llvm::is_contained` https://

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

@@ -28,6 +28,7 @@ class RISCVTargetInfo : public TargetInfo { protected: std::string ABI, CPU; std::unique_ptr ISAInfo; + bool HasExperimental = false; ebiggers wrote: Done https://github.com/llvm/llvm-project/pull/74213 _

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

https://github.com/ebiggers edited https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Remove experimental from Vector Crypto extensions (PR #69000)

ebiggers wrote: No activity here in a few weeks, so I've opened https://github.com/llvm/llvm-project/pull/74213 with an updated version of the change. https://github.com/llvm/llvm-project/pull/69000 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [llvm] Remove experimental from Vector Crypto extensions (PR #69000)

ebiggers wrote: At https://github.com/ebiggers/llvm-project/tree/remove_experimental_from_vector_crypto I've rebased this pull request, squashed the commits, resolved conflicts, fixed the Zvkn duplication, and run `git clang-format`. Note, it was necessary to change the type of `enum RVVRequ

[llvm] [clang] Remove experimental from Vector Crypto extensions (PR #69000)

@@ -141,6 +141,23 @@ on support follow. ``Zve64f`` Supported ``Zve64d`` Supported ``Zvfh`` Supported + ``Zvbb`` Supported + ``Zvbc`` Supported + ``Zvkb`` Supported + ``Zvkg`` Supported + ``Zv

[llvm] [clang] Remove experimental from Vector Crypto extensions (PR #69000)

ebiggers wrote: FYI, I tried squashing the commits of this pull request and rebasing onto `main`, but there are conflicts in several files https://github.com/llvm/llvm-project/pull/69000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[llvm] [clang] Remove experimental from Vector Crypto extensions (PR #69000)

ebiggers wrote: Hi! What's the status of this pull request? Are there any major issues remaining? It would be very useful to have the LLVM assembler officially support the vector crypto extensions. I've been reviewing the [RISC-V vector crypto accelerated crypto routines for the Linux ker