https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/8] [clang] Instantiate attributes on other decl types
Start pro
https://github.com/ericastor closed
https://github.com/llvm/llvm-project/pull/115924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ericastor wrote:
> Test seems to have disappeared entirely!
Whoops. Apologies, missed that I'd forgotten to track the new file.
https://github.com/llvm/llvm-project/pull/115924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/8] [clang] Instantiate attributes on other decl types
Start pro
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/7] [clang] Instantiate attributes on other decl types
Start pro
ericastor wrote:
> test needs some simplification/help, else this is fine.
Thanks, I was mimicking another file that apparently isn't following best
practices. Done!
https://github.com/llvm/llvm-project/pull/115924
___
cfe-commits mailing list
cfe-co
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/7] [clang] Instantiate attributes on other decl types
Start pro
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/6] [clang] Instantiate attributes on other decl types
Start pro
ericastor wrote:
Alright, I've scoped this change back down to just LabelDecls, and added tests
that avoid the use of plugins. I appreciate your review!
https://github.com/llvm/llvm-project/pull/115924
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/ericastor edited
https://github.com/llvm/llvm-project/pull/115924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -52,7 +52,7 @@ struct ExampleAttrInfo : public ParsedAttrInfo {
AttrHandling handleDeclAttribute(Sema &S, Decl *D,
const ParsedAttr &Attr) const override {
// Check if the decl is at file scope.
-if (!D->getDeclContext()->isFileCo
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/5] [clang] Instantiate attributes on other decl types
Start pro
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/3] [clang] Instantiate attributes on other decl types
Start pro
ericastor wrote:
> Still need tests for namespacealiasdecl, typedefnamedecl, and
> typealiastemplatedecl actually being instantiated.
>
> Also, is there a reason why the only way to currently test these are with the
> plugins? I would expect there to be SOME builtin attribute that could be
>
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/3] [clang] Instantiate attributes on other decl types
Start pro
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/115924
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024 17:37:42 +
Subject: [PATCH 1/2] [clang] Instantiate attributes on other decl types
Start pro
ericastor wrote:
> The change is reasonable, but I need to see tests for each of the types.
>
> In general, we've had the attitude of "we can enable this instantiation once
> we see examples of it being useful", so we need tests to make sure it is
> instantiated, AND that it is useful.
This m
@@ -9,7 +9,7 @@ void CheckEnumerations() {
// Check that non-vector 'mode' attribute is OK with enumeration types.
typedef T __attribute__((mode(QI))) T1;
typedef T T2 __attribute__((mode(HI)));
- typedef T __attribute__((mode(V8SI))) T3; // expected-error{{mode 'V8SI' i
https://github.com/ericastor created
https://github.com/llvm/llvm-project/pull/115924
Start propagating attributes on (e.g.) labels inside of templated functions to
their instances.
>From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Tue, 12 Nov 2024
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Renato Golin
,Eric Astor
Message-ID:
In-Reply-To:
https://github.com/ericastor closed
https://github.com/llvm/llvm-project/pull/110334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/ericastor closed
https://github.com/llvm/llvm-project/pull/111841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/111841
>From 6ca0de7e07a02a91ed9ea1493e48c2d29806c537 Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Wed, 9 Oct 2024 22:12:50 +
Subject: [PATCH 1/6] [clang][frontend] Support applying annotate to statements
The
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/111841
>From 6ca0de7e07a02a91ed9ea1493e48c2d29806c537 Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Wed, 9 Oct 2024 22:12:50 +
Subject: [PATCH 1/5] [clang][frontend] Support applying annotate to statements
The
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/110334
>From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Fri, 27 Sep 2024 22:35:28 +
Subject: [PATCH 1/3] [clang][frontend] Add support for attribute plugins for
stat
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/111841
>From 6ca0de7e07a02a91ed9ea1493e48c2d29806c537 Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Wed, 9 Oct 2024 22:12:50 +
Subject: [PATCH 1/4] [clang][frontend] Support applying annotate to statements
The
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/111841
>From 6ca0de7e07a02a91ed9ea1493e48c2d29806c537 Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Wed, 9 Oct 2024 22:12:50 +
Subject: [PATCH 1/4] [clang][frontend] Support applying annotate to statements
The
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/111841
>From 6ca0de7e07a02a91ed9ea1493e48c2d29806c537 Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Wed, 9 Oct 2024 22:12:50 +
Subject: [PATCH 1/3] [clang][frontend] Support applying annotate to statements
The
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/110334
>From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Fri, 27 Sep 2024 22:35:28 +
Subject: [PATCH 1/3] [clang][frontend] Add support for attribute plugins for
stat
https://github.com/ericastor created
https://github.com/llvm/llvm-project/pull/111841
By allowing AnnotateAttr to be applied to statements, users can place arbitrary
information in the AST for later use.
For example, this can be used for HW-targeted language extensions that involve
specialize
@@ -2125,6 +2126,19 @@
TemplateInstantiator::TransformTemplateParmRefExpr(DeclRefExpr *E,
Arg, PackIndex);
}
+const AnnotateAttr *
+TemplateInstantiator::TransformAnnotateAttr(const AnnotateAttr *AA) {
+ SmallVector Args;
+ for (Expr
ericastor wrote:
So... I think this turned out to be surprisingly easy. After all, we don't
actually allow custom attributes to create entirely new attributes in the AST,
since they can't create new legal AST entries... instead, the example creates
AnnotateAttrs that can then be observed & act
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/110334
>From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Fri, 27 Sep 2024 22:35:28 +
Subject: [PATCH 1/3] [clang][frontend] Add support for attribute plugins for
stat
ericastor wrote:
> So the problem with statement attributes is that we don't really have a good
> way to do instantiation of them on a template, which is why we held off on
> this in the first place. The infrastructure for instantiation DOES happen on
> decl attributes automatically anyway, so
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/110334
>From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Fri, 27 Sep 2024 22:35:28 +
Subject: [PATCH 1/2] [clang][frontend] Add support for attribute plugins for
stat
https://github.com/ericastor updated
https://github.com/llvm/llvm-project/pull/110334
>From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001
From: Eric Astor
Date: Fri, 27 Sep 2024 22:35:28 +
Subject: [PATCH] [clang][frontend] Add support for attribute plugins for
statemen
https://github.com/ericastor created
https://github.com/llvm/llvm-project/pull/110334
We already have support for declaration attributes; this is just a matter of
extending the plugin infrastructure to cover one more case.
>From 0411b2939e10ca335e84731502126145509bef2d Mon Sep 17 00:00:00 2001
Author: Eric Astor
Date: 2020-02-26T15:19:40-05:00
New Revision: 85b641c27aecee637d3f7ab25915f47438f55848
URL:
https://github.com/llvm/llvm-project/commit/85b641c27aecee637d3f7ab25915f47438f55848
DIFF:
https://github.com/llvm/llvm-project/commit/85b641c27aecee637d3f7ab25915f47438f55848.diff
LO
Author: Eric Astor
Date: 2020-01-09T14:55:03-05:00
New Revision: 1c545f6dbcbb3ada2dfef2c6afbc1ca8939135cb
URL:
https://github.com/llvm/llvm-project/commit/1c545f6dbcbb3ada2dfef2c6afbc1ca8939135cb
DIFF:
https://github.com/llvm/llvm-project/commit/1c545f6dbcbb3ada2dfef2c6afbc1ca8939135cb.diff
LO
Author: Eric Astor
Date: 2019-12-30T14:35:26-05:00
New Revision: 4a7aa252a32a94b1bb61b3dc7f027b4a27ae334f
URL:
https://github.com/llvm/llvm-project/commit/4a7aa252a32a94b1bb61b3dc7f027b4a27ae334f
DIFF:
https://github.com/llvm/llvm-project/commit/4a7aa252a32a94b1bb61b3dc7f027b4a27ae334f.diff
LO
Author: Eric Astor
Date: 2019-12-22T09:16:34-05:00
New Revision: dc5b614fa9a1c83e8275fcb9c3f78444d0a30514
URL:
https://github.com/llvm/llvm-project/commit/dc5b614fa9a1c83e8275fcb9c3f78444d0a30514
DIFF:
https://github.com/llvm/llvm-project/commit/dc5b614fa9a1c83e8275fcb9c3f78444d0a30514.diff
LO
Author: Eric Astor
Date: 2019-11-04T12:49:19-05:00
New Revision: be6ac471f613427f3b5b3a306fe033e526d59f76
URL:
https://github.com/llvm/llvm-project/commit/be6ac471f613427f3b5b3a306fe033e526d59f76
DIFF:
https://github.com/llvm/llvm-project/commit/be6ac471f613427f3b5b3a306fe033e526d59f76.diff
LO
41 matches
Mail list logo
