[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39d8e6e22cd1: Add missing StringExtras.h includes (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D154543?vs=5382

[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 538238. IncludeGuardian added a comment. Rebasing on `main` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/BareMetal.cpp llv

[PATCH] D154543: [Support] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @MaskRay Thanks. I have updated the title to use `[Support]` and I will land the additional includes separately to the removal. This was very good advice last attempt as it I did have to revert the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 538047. IncludeGuardian added a comment. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Fix `XCOFFDump.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/li

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 537886. IncludeGuardian added a comment. Fix `CompressionTest.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/BareMetal.cp

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian created this revision. Herald added subscribers: ormris, hiraditya. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Add missing parts that caused https:

[PATCH] D153728: [llvm] Move AttributeMask to a separate header

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0fa2d7c2928: [llvm] Move AttributeMask to a separate header (authored by IncludeGuardian). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153728/new/ https:

[PATCH] D153728: [llvm] Move AttributeMask to a separate header

IncludeGuardian added a comment. This was found with IncludeGuardian 0.0.8 and the recommendation was given here https://gist.github.com/IncludeGuardian/4132d5149576a55e0560fae6f8ff4a38#file-before-yaml-L4053-L4055 The estimates of token count were run before and after this commit and can be se

[PATCH] D153728: [llvm] Move AttributeMask to a separate header

IncludeGuardian created this revision. IncludeGuardian added a reviewer: aaron.ballman. Herald added subscribers: mtrofin, Enna1, ormris, foad, jdoerfert, kerbowa, hiraditya, jvesely, arsenm, qcolombet, MatzeB. Herald added a project: All. IncludeGuardian requested review of this revision. Herald

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fa0dbd7bf35: [llvm] Move StringExtras.h include from Error.h to Error.cpp (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D153229?vs=533989&id=534347#toc Repository:

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @MaskRay good idea, I have split into 2 commits and pushed to the `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 ___ cf

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533989. IncludeGuardian added a comment. Fix missing includes for Windows-only files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: clang-tools-extr

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533968. IncludeGuardian added a comment. Add back all includes (bad arc change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: clang-tools-extra/cla

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533966. IncludeGuardian added a comment. Fix missing include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: llvm/unittests/Support/CompressionTest.c

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @barannikov88 no it's not. I was going to commit separately to keep the change small, but it turns out that if I move this to the source file there are no additional changes needed. SmallVector.h has now been moved to Error.cpp as well. Repository: rG LLVM G

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533941. IncludeGuardian added a comment. Herald added subscribers: vkmr, kadircet, arphaman, emaste. Herald added a reviewer: bollu. Herald added a reviewer: aartbik. Herald added a reviewer: MaskRay. Herald added a project: clang-tools-extra. Fix comp

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGcea0eea28e71: [llvm] Split out DenseMapInfo specialization (authored by IncludeGuardian). Herald added a project: Flang. Changed prior to commit: https://reviews.llvm.org/D150997?vs=532038&id=5

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. Herald added a subscriber: jsetoain. This was found with IncludeGuardian 0.0.8. The line that suggested this can be found in the output here . The count of pre

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian created this revision. Herald added subscribers: bviyer, luke, Moerafaat, kmitropoulou, zero9178, steakhal, mtrofin, bzcheeseman, mattd, gchakrabarti, pmatos, asb, sdasgup3, asavonic, jeroen.dobbelaere, wenzhicui, wrengr, ormris, foad, ChuanqiXu, cota, teijeong, frasercrmck, rdzh

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian added a comment. This is good to review now. Phabricator has become a bit confused after rebasing on top of https://reviews.llvm.org/D151557, I don't know whether it's worth creating a new, cleaner review and close this on? CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 532038. IncludeGuardian added a comment. Run clang-format over patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 531895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 531060. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 530855. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 530819. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 530787. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 530667. IncludeGuardian added a comment. Fix missing includes in test, fix formatting, and rebase on top of https://reviews.llvm.org/D151557 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files:

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian added a comment. @kadircet Thanks I will run this through the formatter. Thanks for fixing `isEqual`. I am currently on holiday for a few weeks so cannot guarantee when I'll be able to update this PR. I say go ahead with your fix and I'll incorporate those changes into this revi

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian requested review of this revision. IncludeGuardian added inline comments. Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.h:22 #include "mlir/Interfaces/SideEffectInterfaces.h" +#include I wasn't sure if it is possible to include `` w

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524125. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524109. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h llvm/include/llvm/ADT/DenseMapInfo.h llvm/include/llvm/ADT

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524094. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, mgester, arpith-j

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524041. IncludeGuardian added a comment. Add missing specialization for clang-include-cleaner/Types.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/incl

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian added inline comments. Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:321 - static bool isEqual(const Variant &LHS, const Variant &RHS) { -return LHS == RHS; - } Regardless of this change, I think the equality here needs to be fixed in the

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524024. IncludeGuardian added a comment. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix one missing `` include in tools and add `DenseMapInfoVariant.h`, which I forgot previously Repository: rG LLVM Github M

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 517310. IncludeGuardian added a comment. Rebase on upstream to resolve conflicts in release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added a comment. @aaron.ballman If you could commit for me that would be great. Please use "Elliot Goodrich" for the name and "elliotgoodr...@gmail.com" for the email - thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D14792

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 517291. IncludeGuardian added a comment. Update Clang release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Lex/MultipleIncludeOpt

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 514849. IncludeGuardian added a comment. Replace `ResetReadToken` with `SetReadToken` to avoid a conditional CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/include/clang/Lex/Multipl

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 +if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); +} aaron.ballman wrote: > NFC but matches our style guide. > > One thing to consi

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added a comment. Differences between the behaviors of compilers can be found here https://github.com/IncludeGuardian/multiple-inclusion-optimization-tests You can see the number of boost preprocessor files failing the include guard optimization when running IncludeGuardian

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian created this revision. IncludeGuardian added a reviewer: clang. IncludeGuardian added a project: clang. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added a subscriber: cfe-commits. The multiple-include optimization allows Clang to avoid op