Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

eliben added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:6498 @@ +6497,3 @@ + + Class classify(QualType Ty) const; + jpienaar wrote: > We only had one DefaultNumRegisterParameters that we supported > (DefaultNumRegisterParameters=4) so I just propaga

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

eliben added a subscriber: eliben. eliben added a comment. Clang-level tests? Comment at: lib/Basic/Targets.cpp:5873 @@ +5872,3 @@ +"-m:e" // ELF name manging +"-p:32:32" // 32-bit pointers work aligned +"-i64:64" // 64 bit integers, 64 bit aligne

Re: [PATCH] D13171: [CUDA] Added a wrapper header for inclusion of stock CUDA headers.

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D13171: [CUDA] Added a wrapper header for inclusion of stock CUDA headers.

eliben added inline comments. Comment at: lib/Headers/clang_cuda_support.h:53 @@ +52,3 @@ +// WARNING: Preprocessor hacks below are based on specific of +// implementation of CUDA-7.0 headers and are expected to break with +// any other version of CUDA headers. If

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. The CUDA parts look very good. Someone else should approve the overloading-related logic Comment at: include/clang/Sema/Sema.h:8605 @@ +8604,3 @@ + + CUDAFunctionPreference

r246573 - Fix typo in test

Author: eliben Date: Tue Sep 1 13:56:19 2015 New Revision: 246573 URL: http://llvm.org/viewvc/llvm-project?rev=246573&view=rev Log: Fix typo in test Modified: cfe/trunk/test/Preprocessor/init.c Modified: cfe/trunk/test/Preprocessor/init.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

eliben added inline comments. Comment at: include/clang/Sema/Sema.h:8599 @@ +8598,3 @@ +CFP_Never, // Invalid caller/callee combination. +CFP_LastResort, // same as CFP_Never or CFP_Fallback, depending on +// -fcuda-disable-target-call-checks optio

Re: [PATCH] D11950: [CUDA] Check register names on appropriate side of cuda compilation only.

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D11694: [CUDA] Added stubs for __nvvm_atom_add*_d()

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D12122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

eliben added inline comments. Comment at: include/clang/Basic/Builtins.h:85 @@ +84,3 @@ + /// \brief Return true if this function is a target-specific builtin + bool isTSBuiltin(unsigned ID) const { +return ID >= Builtin::FirstTSBuiltin; You can also use it

Re: [PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

eliben accepted this revision. eliben added a comment. lgtm Comment at: test/CodeGenCUDA/ptx-kernels.cu:26 @@ -16,1 +25,2 @@ // CHECK: !{{[0-9]+}} = !{void ()* @global_function, !"kernel", i32 1} +// CHECK: !{{[0-9]+}} = !{void (i32)* @_Z16templated_kernelIiEvT_, !"kernel", i3

Re: [PATCH] D11950: [CUDA] Check register names on appropriate side of cuda compilation only.

eliben added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5944 @@ -5943,3 +5943,3 @@ ProcessDeclAttributes(S, NewVD, D); - + bool ShouldHandleTargetErrors = DeclAttrsMatchCUDAMode(getLangOpts(), NewVD); if (getLangOpts().CUDA) { Since this is a CUDA-o