Author: delena
Date: Sun May 13 00:45:58 2018
New Revision: 332193
URL: http://llvm.org/viewvc/llvm-project?rev=332193&view=rev
Log:
Added atomic_fetch_min, max, umin, umax intrinsics to clang.
These intrinsics work exactly as all other atomic_fetch_* intrinsics and allow
to create *atomicrmw* w
delena accepted this revision.
delena added a comment.
This revision is now accepted and ready to land.
LGTM. Agree, one-by-one.
https://reviews.llvm.org/D25902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
delena added inline comments.
Comment at: lib/Headers/avx512fintrin.h:8394
_MM_FROUND_CUR_DIRECTION);
}
Using vfmaddss3_mask is wrong in this case.
It will propagate -B to lower bits if mask==0.
Comment at: lib/Headers/avx512fintr
delena added inline comments.
Comment at: test/CodeGen/x86-inline-asm-v-constraint.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -emit-llvm -target-cpu
x86-64 -o - | FileCheck %s --check-prefix SSE
+// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -
delena added inline comments.
Comment at: lib/Headers/avx512fintrin.h:9337
@@ +9336,3 @@
+{
+ return (__m128) _mm_move_ss( __A, __builtin_ia32_selectps_128 ((__mmask8)
__U,
+ (__v4sf) __B,
selectps
delena accepted this revision.
This revision is now accepted and ready to land.
Comment at: ../tunkClang/tools/clang/test/CodeGen/avx512vl-builtins.c:504
@@ -503,3 +503,3 @@
__mmask8 test_mm_cmp_epi32_mask(__m128i __a, __m128i __b) {
// CHECK-LABEL: @test_mm_cmp_epi32_mask
-
delena added a comment.
#include in the test is not clear for me. Does it mean that you
broke backward compatibility?
Comment at: lib/CodeGen/CGBuiltin.cpp:6779
@@ -6776,1 +6778,3 @@
}
+ case X86::BI__builtin_ia32_xgetbv: {
+return Builder.CreateCall(CGM.getIntrinsic(In
delena accepted this revision.
This revision is now accepted and ready to land.
Comment at: ../tunkClang/tools/clang/test/CodeGen/avx512f-builtins.c:1413-1414
@@ -1412,3 +1412,4 @@
// CHECK-LABEL: @test_mm512_mask_and_epi32
- // CHECK: @llvm.x86.avx512.mask.pand.d.512
+ // CH
delena added inline comments.
Comment at: lib/Headers/avx512fintrin.h:4518
@@ -4493,1 +4517,3 @@
+static __inline__ __m128 __DEFAULT_FN_ATTRS
+_mm_mask_store_ss (float * __W, __mmask8 __U, __m128 __A)
this intrinsic should be void.
Comment at:
delena added inline comments.
Comment at: lib/Headers/avx512fintrin.h:9124
@@ +9123,3 @@
+{
+ return (__m128) __builtin_ia32_movss_mask ((__v4sf) __A, (__v4sf) __B,
+ (__v4sf) __W,
please try the following:
if (__U)
return __builtin_shuffle(A, B,
delena added a comment.
Why do you need them. Is it a part of API?
http://reviews.llvm.org/D20871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
delena accepted this revision.
delena added a comment.
This revision is now accepted and ready to land.
LGTM, After tests cleanup
http://reviews.llvm.org/D20782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
delena added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:6304
@@ +6303,3 @@
+ Indices[i] = i;
+Ops[2] = CGF.Builder.CreateShuffleVector(Ops[2], Ops[2],
+ makeArrayRef(Indices, NumElts),
craig.topper w
delena added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:6304
@@ +6303,3 @@
+ Indices[i] = i;
+Ops[2] = CGF.Builder.CreateShuffleVector(Ops[2], Ops[2],
+ makeArrayRef(Indices, NumElts),
What code do y
delena added inline comments.
Comment at: test/CodeGen/avx512f-builtins.c:1927
@@ +1926,3 @@
+ // check-label: @test_mm512_div_pd
+ // check: @llvm.x86.avx512.mask.div.pd.512
+ return _mm512_div_pd(__a,__b);
I don't understand how do you receive intrinsic if
delena added a subscriber: delena.
Comment at: lib/CodeGen/TargetInfo.cpp:1569
@@ +1568,3 @@
+CGF.getTarget().getTargetOpts().Features;
+ if (std::find(TargetFeatures.begin(), TargetFeatures.end(),
+"+separate-stack-seg") != TargetFeatures.end()) {
---
Author: delena
Date: Sun Feb 21 01:41:23 2016
New Revision: 261467
URL: http://llvm.org/viewvc/llvm-project?rev=261467&view=rev
Log:
Added SKL and CNL processors and features to Clang
Differential Revision: http://reviews.llvm.org/D16756
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/tru
delena added a comment.
LGTM
http://reviews.llvm.org/D13861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
delena added a comment.
You should add the "xsave" features to all appropriate CPUs. It can be done in
a separate patch.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D13014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
delena added a comment.
Do you need to add some tests for clang?
Repository:
rL LLVM
http://reviews.llvm.org/D13014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
20 matches
Mail list logo
