eladcohen added a comment.
Thanks for the review! committed r285548.
Repository:
rL LLVM
https://reviews.llvm.org/D25767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285548: [Modules] Add a command line option for loading the
clang builtins modulemap. (authored by eladcohen).
Changed prior to commit:
https://reviews.llvm.org/D25767?vs=75133&id=76355#toc
Repository:
Author: eladcohen
Date: Mon Oct 31 03:21:54 2016
New Revision: 285548
URL: http://llvm.org/viewvc/llvm-project?rev=285548&view=rev
Log:
[Modules] Add a command line option for loading the clang builtins modulemap.
-fbuiltin-module-map loads the clang builtins modulemap file. (This is
equivalent t
eladcohen added a comment.
In https://reviews.llvm.org/D25337#571877, @rsmith wrote:
> I really don't like the command-line interface you're proposing here. It
> seems like it will be extremely confusing what something like `-fmodules
> -fexclusive-builtin-modules` means, for instance (usually,
eladcohen created this revision.
eladcohen added reviewers: rsmith, bruno, zvi.
eladcohen added a subscriber: cfe-commits.
-fbuiltin-module-map loads the clang builtins modulemap file.
(This is equivalent to -fmodule-map-file=/include/module.modulemap)
It can be used for enabling clang's 'modules
eladcohen added a comment.
In https://reviews.llvm.org/D25337#571845, @bruno wrote:
> > The long answer is that there is a history of problems regarding the
> > intrinsic files:
> > http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html
> > http://lists.llvm.org/pipermail/cfe-dev/2016-Se
eladcohen added a comment.
Hi Bruno,
The short answer is yes. Essentially it can be done, but we would actually like
for all the users to always get this behavior, implicitly.
The long answer is that there is a history of problems regarding the intrinsic
files:
http://lists.llvm.org/pipermail/
eladcohen created this revision.
eladcohen added reviewers: hans, rnk, zvi, rsmith, chandlerc.
eladcohen added a subscriber: cfe-commits.
-fexclusive-builtin-modules enables the clang 'modules' feature exclusively for
the clang intrinsic header files.
The end goal of this effort is to have this
eladcohen added a comment.
Thanks for the review! committed r282581.
Repository:
rL LLVM
https://reviews.llvm.org/D24825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282581: [X86] Remove the mm_malloc.h include guard hack from
the X86 builtins tests (authored by eladcohen).
Changed prior to commit:
https://reviews.llvm.org/D24825?vs=72158&id=72805#toc
Repository:
Author: eladcohen
Date: Wed Sep 28 06:59:09 2016
New Revision: 282581
URL: http://llvm.org/viewvc/llvm-project?rev=282581&view=rev
Log:
[X86] Remove the mm_malloc.h include guard hack from the X86 builtins tests
The X86 clang/test/CodeGen/*builtins.c tests define the mm_malloc.h include
guard as
eladcohen added inline comments.
Comment at: lib/Headers/module.modulemap:133
@@ -131,2 +132,3 @@
explicit module aes {
+ export sse2
header "__wmmintrin_aes.h"
bruno wrote:
> The mmx case above makes sense to me, but I find conceptually odd that
eladcohen added a comment.
ping
https://reviews.llvm.org/D24752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eladcohen created this revision.
eladcohen added a subscriber: cfe-commits.
The X86 clang/test/CodeGen/*builtins.c tests define the mm_malloc.h include
guard as a hack for avoiding its inclusion (mm_malloc.h requires a hosted
environment since it expects stdlib.h to be available - which is not t
eladcohen created this revision.
eladcohen added a reviewer: rsmith.
eladcohen added a subscriber: cfe-commits.
X86 intrinsic header files mm3dnow.h and wmmintrin.h include and depend on
mmintrin.h and emmintrin.h respectively.
This patch adds these missing dependencies to the corresponding submo
eladcohen added a comment.
Thanks Richard, committed r280613.
Repository:
rL LLVM
https://reviews.llvm.org/D23871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eladcohen
Date: Sun Sep 4 01:00:42 2016
New Revision: 280613
URL: http://llvm.org/viewvc/llvm-project?rev=280613&view=rev
Log:
[Modules] Add 'freestanding' to the 'requires-declaration' feature-list.
This adds support for modules that require (non-)freestanding
environment, such as the c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280613: [Modules] Add 'freestanding' to the
'requires-declaration' feature-list. (authored by eladcohen).
Changed prior to commit:
https://reviews.llvm.org/D23871?vs=69239&id=70279#toc
Repository:
rL
eladcohen added inline comments.
Comment at: lib/Headers/module.modulemap:66
@@ -65,2 +65,3 @@
explicit module mm_malloc {
+ requires !freestanding
header "mm_malloc.h"
rsmith wrote:
> Are there more parts of the intrinsics modules to which this s
eladcohen created this revision.
eladcohen added reviewers: rsmith, andreybokhanko.
eladcohen added a subscriber: cfe-commits.
This adds support for modules that require (non-)freestanding environment such
as the compiler builtin mm_malloc submodule.
https://reviews.llvm.org/D23871
Files:
doc
Author: eladcohen
Date: Mon Aug 22 02:34:21 2016
New Revision: 279419
URL: http://llvm.org/viewvc/llvm-project?rev=279419&view=rev
Log:
Test commit (Removing trailing whitespace).
Modified:
cfe/trunk/include/clang/Driver/Driver.h
Modified: cfe/trunk/include/clang/Driver/Driver.h
URL:
http:/
21 matches
Mail list logo
