[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN added inline comments. Comment at: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.remove_all/remove_all.pass.cpp:86 + +TEST_CHECK(fs::remove_all(p) == 0); +TEST_CHECK(!ec); EricWF wrote: > This test is incorrect. `ec` isn'

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN added a comment. In https://reviews.llvm.org/D41830#973419, @mclow.lists wrote: > LGTM. > > Do you need me to commit this? Nope, i can do it myself https://reviews.llvm.org/D41830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN added inline comments. Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67 non_empty_dir, -file_in_bad_dir, +// file_in_bad_dir, // produces "St13exception_ptruncaught_exceptions not yet implemented" }; -

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN updated this revision to Diff 129453. TyanNN added a comment. Fix tests https://reviews.llvm.org/D41830 Files: src/experimental/filesystem/operations.cpp test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp test/std/experimental/filesystem/fs.op.funcs/fs.op.re

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN marked 2 inline comments as done. TyanNN added inline comments. Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67 non_empty_dir, -file_in_bad_dir, +// file_in_bad_dir, // produces "St13exception_ptruncaught_e

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN added inline comments. Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67 non_empty_dir, -file_in_bad_dir, +// file_in_bad_dir, // produces "St13exception_ptruncaught_exceptions not yet implemented" }; -

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN updated this revision to Diff 129280. TyanNN added a comment. Fix remove and remove_all error resetting. Move test to the appropriate files and fix old tests. https://reviews.llvm.org/D41830 Files: src/experimental/filesystem/operations.cpp test/std/experimental/filesystem/fs.op.fun

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN updated this revision to Diff 129115. TyanNN retitled this revision from "[libc++] Fix PR#35780 - make std::experimental::filesystem::remove return false if the file doesn't exist" to "[libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if t

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove return false if the file doesn't exist

TyanNN created this revision. TyanNN added a reviewer: EricWF. Herald added a subscriber: cfe-commits. Previously it thrown an error if the file didn't exist. PR#35780 Repository: rCXX libc++ https://reviews.llvm.org/D41830 Files: src/experimental/filesystem/operations.cpp test/libcxx/