t;15"
>>
>> YAML:1:1: error: Unrecognized escape code!
>>
>> ^
>>
>> :1:7: note: possible intended match here
>>
>> YAML:1:1: error: Unrecognized escape code!
>>
>> ^
>>
>>
>> error: command failed with exit status: 1
&g
: possible intended match here
>
> YAML:1:1: error: Unrecognized escape code!
>
> ^
>
>
> error: command failed with exit status: 1
>
> Douglas Yung
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Beha
Author: ehsan
Date: Fri Feb 17 13:31:43 2017
New Revision: 295482
URL: http://llvm.org/viewvc/llvm-project?rev=295482&view=rev
Log:
[clang-tidy] Add -path option to clang-tidy-diff.py
Summary:
This flag allows specifying a custom path for the compilation
database. Unfortunately we can't use the
Author: ehsan
Date: Thu Feb 9 12:32:02 2017
New Revision: 294607
URL: http://llvm.org/viewvc/llvm-project?rev=294607&view=rev
Log:
[clang-tidy] Add -quiet option to suppress extra output
Summary:
This new flag instructs clang-tidy to not output anything
except for errors and warnings. This make
Author: ehsan
Date: Wed Feb 8 11:50:24 2017
New Revision: 294491
URL: http://llvm.org/viewvc/llvm-project?rev=294491&view=rev
Log:
[clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py
Summary:
These flags allow specifying extra arguments to the tool's command
line which don't
Author: ehsan
Date: Wed Jan 18 11:49:35 2017
New Revision: 292415
URL: http://llvm.org/viewvc/llvm-project?rev=292415&view=rev
Log:
[clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py
Summary:
These flags allow specifying extra arguments to the tool's command
line which don't a
ehsan resigned from this revision.
ehsan removed a reviewer: ehsan.
ehsan added a comment.
I also don't know enough about the build system to review this, sorry!
Repository:
rL LLVM
https://reviews.llvm.org/D1
___
cfe-commits mailing list
cfe
aeology)?
>
> On Mon, Nov 23, 2015 at 11:56 AM, Ehsan Akhgari via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ehsan
>> Date: Mon Nov 23 13:56:46 2015
>> New Revision: 253909
>>
>> URL: http://llvm.org/viewvc/llvm-project?re
Author: ehsan
Date: Tue May 31 10:55:51 2016
New Revision: 271292
URL: http://llvm.org/viewvc/llvm-project?rev=271292&view=rev
Log:
clang-c: Add the clang_getCursorVisibility() API
This patch adds an API for querying the visibility of the entity
referred to by a cursor.
Patch by Michael Wu .
Ad
Author: ehsan
Date: Tue May 31 10:39:10 2016
New Revision: 271291
URL: http://llvm.org/viewvc/llvm-project?rev=271291&view=rev
Log:
Revert r253909 because it was committed with an incorrect message
Removed:
cfe/trunk/test/Index/symbol-visibility.c
Modified:
cfe/trunk/include/clang-c/Index
Author: ehsan
Date: Tue Feb 9 14:49:24 2016
New Revision: 260276
URL: http://llvm.org/viewvc/llvm-project?rev=260276&view=rev
Log:
Fix the test added in r260266
Modified:
cfe/trunk/test/Frontend/plugins.c
Modified: cfe/trunk/test/Frontend/plugins.c
URL:
http://llvm.org/viewvc/llvm-project/
Author: ehsan
Date: Tue Feb 9 13:43:13 2016
New Revision: 260266
URL: http://llvm.org/viewvc/llvm-project?rev=260266&view=rev
Log:
clang-cl: Enable plugins on Windows
Modified:
cfe/trunk/test/Frontend/plugins.c
cfe/trunk/test/lit.cfg
Modified: cfe/trunk/test/Frontend/plugins.c
URL:
htt
Author: ehsan
Date: Tue Feb 9 13:43:11 2016
New Revision: 260265
URL: http://llvm.org/viewvc/llvm-project?rev=260265&view=rev
Log:
clang-cl: Support loading plugins on Windows
This builds on the support being added to LLVM to import and export
registries from DLLs. This will allow us to pick up
ehsan updated this revision to Diff 47057.
ehsan added a comment.
Sorry for the noise, arconist fail...
http://reviews.llvm.org/D16761
Files:
docs/ClangPlugins.rst
examples/PrintFunctionNames/PrintFunctionNames.cpp
lib/FrontendTool/ExecuteCompilerInvocation.cpp
test/Frontend/plugins.c
ehsan updated this revision to Diff 47056.
ehsan added a comment.
Updating based on the LLVM side changes.
http://reviews.llvm.org/D16761
Files:
docs/ClangPlugins.rst
examples/PrintFunctionNames/PrintFunctionNames.cpp
include/clang/Basic/DiagnosticASTKinds.td
lib/AST/ExprConstant.cpp
ehsan updated this revision to Diff 47021.
ehsan added a comment.
Addressed the review comments.
http://reviews.llvm.org/D16465
Files:
include/clang/AST/Decl.h
include/clang/AST/Expr.h
include/clang/Basic/DiagnosticASTKinds.td
lib/AST/Decl.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CG
ehsan added a comment.
In http://reviews.llvm.org/D16503#342116, @thakis wrote:
> Sorry for the slow response. I was reading http://reviews.llvm.org/D15670 to
> understand this patch, and I couldn't find anything in that patch that
> enables this extension only in Microsoft mode. Trying
> supp
ehsan created this revision.
ehsan added a reviewer: rnk.
ehsan added a subscriber: cfe-commits.
This builds on the support being added to LLVM to import and export
registries from DLLs. This will allow us to pick up the registry
entries added in the DLL's copy of FrontendPluginRegistry.
This wi
Hi Renato,
Thanks, Nico helped me diagnose and fix the test yesterday <
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160125/147979.html>.
I fixed the test accordingly in r258776 and that seems to have worked!
Cheers,
Ehsan
On Tue, Jan 26, 2016 at 7:41 AM, Renato Golin
wrote:
> Hi,
:
> Since it isn't a -### test, the test probably just needs a `// REQUIRES:
> x86-registered-target`? Is adding -### a possibility?
>
> On Mon, Jan 25, 2016 at 8:51 PM, Ehsan Akhgari via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ehsan
>&
Author: ehsan
Date: Mon Jan 25 20:23:05 2016
New Revision: 258776
URL: http://llvm.org/viewvc/llvm-project?rev=258776&view=rev
Log:
Recommit the test for r258720 using -###
Modified:
cfe/trunk/test/Driver/unknown-arg.c
Modified: cfe/trunk/test/Driver/unknown-arg.c
URL:
http://llvm.org/viewv
if you can
> revert it for me. I will look at fixing this tomorrow.
> On Jan 25, 2016 6:49 PM, "Renato Golin" wrote:
>
>> On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits
>> wrote:
>> > Author: ehsan
>> > Date: Mon Jan 25 15:14:52 2016
>
Author: ehsan
Date: Mon Jan 25 19:51:47 2016
New Revision: 258772
URL: http://llvm.org/viewvc/llvm-project?rev=258772&view=rev
Log:
Revert the test for r258720 temporarily
This test is failing on a bot for reasons that are unclear to me.
Reverting for now...
Modified:
cfe/trunk/test/Driver/u
Ouch, sorry about that! I'm afk right now, I would appreciate if you can
revert it for me. I will look at fixing this tomorrow.
On Jan 25, 2016 6:49 PM, "Renato Golin" wrote:
> On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits
> wrote:
> > Author: ehsan
&g
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258720: [MSVC Compat] Only warn for unknown clang-cl
arguments (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D16511?vs=45796&id=45906#toc
Repository:
rL LLVM
http://reviews.l
Author: ehsan
Date: Mon Jan 25 15:14:52 2016
New Revision: 258720
URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev
Log:
[MSVC Compat] Only warn for unknown clang-cl arguments
Summary:
MSVC's driver accepts all unknown arguments but warns about them. clang
by default rejects all unkno
Thanks for the reviews! Will address both when landing.
On Mon, Jan 25, 2016 at 2:34 PM, Hans Wennborg wrote:
> hans added a subscriber: hans.
> hans added a comment.
>
> Maybe this behavior should be called out in the Command-Line Options
> section under clang-cl in docs/UsersManual.rst?
>
>
>
ehsan created this revision.
ehsan added a reviewer: rnk.
ehsan added a subscriber: cfe-commits.
MSVC's driver accepts all unknown arguments but warns about them. clang
by default rejects all unknown arguments. This causes issues
specifically with build systems such as autoconf which liberally p
On Fri, Jan 22, 2016 at 3:22 PM, Nico Weber wrote:
> Every time we accept something in MS mode that isn't standards compliant,
> we should accept it with a warning (for stuff that's harmless, an Extension
> warning, for stuff that can lead to bugs a Warning warning), unless it's
> really hard to
ehsan created this revision.
ehsan added a reviewer: thakis.
ehsan added a subscriber: cfe-commits.
MSVC suppresses a trailing comma if no arguments are passed in place of
a variadic argument[1]. This patch adds a -Wmicrosoft warning when
accepting such code.
[1] https://msdn.microsoft.com/en-us
it possible to emit some -Wmicrosoft warning in cases where this is
> necessary?
>
> On Fri, Jan 22, 2016 at 2:26 PM, Ehsan Akhgari via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ehsan
>> Date: Fri Jan 22 13:26:44 2016
>> New Revision: 258
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258530: [MSVC Compat] Accept elided commas in macro function
arguments (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D15670?vs=43310&id=45718#toc
Repository:
rL LLVM
http://r
Author: ehsan
Date: Fri Jan 22 13:26:44 2016
New Revision: 258530
URL: http://llvm.org/viewvc/llvm-project?rev=258530&view=rev
Log:
[MSVC Compat] Accept elided commas in macro function arguments
Summary:
This fixes PR25875. When the trailing comma in a macro argument list is
elided, we need to t
ehsan added a comment.
Sure. I'd be happy to address any comments post-landing.
Thanks!
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sure. I'd be happy to address any comments post-landing.
Thanks!
On Fri, Jan 22, 2016 at 2:13 PM, Reid Kleckner wrote:
> rnk added a comment.
>
> Let's go ahead and land this. It doesn't seem high risk. Richard will be
> back on Monday, he's been skiing.
>
>
> http://reviews.llvm.org/D15670
>
ehsan added a comment.
In http://reviews.llvm.org/D16465#333688, @rnk wrote:
> Your code won't catch this test case:
>
> static int x;
> extern inline const bool *f() {
> static const bool p = !&x;
> return &p;
> }
>
> Getting this exactly right is going to be a challenge. =/
Oh y
ehsan added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4113
@@ +4112,3 @@
+ if (!CheckPotentialExpressionContainingDeclRefExpr(E->getTrueExpr(),
+ E->getFalseExpr()))
+return false;
O
ehsan created this revision.
ehsan added a reviewer: rnk.
ehsan added a subscriber: cfe-commits.
In the Microsoft ABI, some expressions containing references to variables
cannot be evaluated as a constant. These are expressions containing a
conditional, logical and/or, or comma operator with an o
ehsan added a subscriber: ehsan.
ehsan added a comment.
Richard: ping?
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Richard: ping?
On Tue, Jan 12, 2016 at 6:41 PM, Reid Kleckner wrote:
> rnk accepted this revision.
> rnk added a comment.
> This revision is now accepted and ready to land.
>
> Seems reasonable to me, but we should check with Richard.
>
>
> http://reviews.llvm.org/D15670
>
>
>
>
--
Ehsan
ehsan abandoned this revision.
ehsan added a comment.
Oops, sorry, I submitted this by mistake.
http://reviews.llvm.org/D15839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ehsan created this revision.
ehsan added a reviewer: hansw.
ehsan added a subscriber: cfe-commits.
The documentation in https://msdn.microsoft.com/en-us/library/hh977022.aspx
says that this intrinsic is defined in immintrin.h, and that's the header
where MSVC declares this intrinsic, but clang-cl
ehsan accepted this revision.
ehsan added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
ehsan created this revision.
ehsan added reviewers: rnk, rsmith.
ehsan added a subscriber: cfe-commits.
This fixes PR25875. When the trailing comma in a macro argument list is
elided, we need to treat it similarly to the case where a variadic macro
misses one actual argument.
http://reviews.llvm
ehsan accepted this revision.
ehsan added a reviewer: ehsan.
ehsan added a comment.
Landed in r253909.
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ehsan
Date: Mon Nov 23 13:56:46 2015
New Revision: 253909
URL: http://llvm.org/viewvc/llvm-project?rev=253909&view=rev
Log:
Make clang_Cursor_getMangling not mangle if the declaration isn't mangled
Right now clang_Cursor_getMangling will attempt to mangle any
declaration, even if the decl
Author: ehsan
Date: Thu Oct 29 12:20:17 2015
New Revision: 251638
URL: http://llvm.org/viewvc/llvm-project?rev=251638&view=rev
Log:
Add a link to the DXR project
DXR is a project developed at Mozilla that implements a code indexing
and browsing utility on top of libclang that has features such as
Author: ehsan
Date: Wed Oct 7 19:01:20 2015
New Revision: 249639
URL: http://llvm.org/viewvc/llvm-project?rev=249639&view=rev
Log:
Make clang_Cursor_getMangling not mangle if the declaration isn't mangled
Right now clang_Cursor_getMangling will attempt to mangle any
declaration, even if the decl
Author: ehsan
Date: Tue Oct 6 13:53:12 2015
New Revision: 249440
URL: http://llvm.org/viewvc/llvm-project?rev=249440&view=rev
Log:
Revert r249437
Modified:
cfe/trunk/test/Index/print-mangled-name.cpp
cfe/trunk/tools/c-index-test/c-index-test.c
cfe/trunk/tools/libclang/CIndex.cpp
Mod
ehsan closed this revision.
ehsan added a comment.
Landed in r249437.
http://reviews.llvm.org/D13317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ehsan
Date: Tue Oct 6 13:24:33 2015
New Revision: 249437
URL: http://llvm.org/viewvc/llvm-project?rev=249437&view=rev
Log:
Make clang_Cursor_getMangling don't mangle if the declaration isn't mangled
Right now clang_Cursor_getMangling will attempt to mangle any
declaration, even if the de
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245401: Insert override at the same line as the end of the
function declaration (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D9286?vs=24449&id=32492#toc
Repository:
rL LLVM
Author: ehsan
Date: Tue Aug 18 21:05:37 2015
New Revision: 245401
URL: http://llvm.org/viewvc/llvm-project?rev=245401&view=rev
Log:
Insert override at the same line as the end of the function declaration
Summary:
The existing check converts the code pattern below:
void f()
{
}
to:
void
ehsan added a comment.
I should land this, but let's wait to see if we want
http://reviews.llvm.org/D9285 or not, since this patch is built on top of it.
If not, I can rebase it on top of master as well.
http://reviews.llvm.org/D9286
___
cfe-comm
ehsan added a comment.
Sorry, I kind of dropped the ball here!
At Mozilla we ended up deciding on allowing only a maximum of one of virtual,
final or override per function declaration, similar to the Google coding style,
so we won't need the KeepVirtual option. Should I still add it neverthele
55 matches
Mail list logo
