[PATCH] D145321: [clang-tidy] altera-id-dependent-backward-branch: fix assignment notes

yeputons-gh added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:126 IdDepFieldsMap[Field] = IdDependencyRecord( Field, Statement->getBeginLoc(), Twine("assignment of ID-dependent field ") + Field->getNameAsSt

[PATCH] D145321: [clang-tidy] altera-id-dependent-backward-branch: fix direct assignment notes

yeputons-gh updated this revision to Diff 502447. yeputons-gh added a comment. Test inferred assignments and fix notes for them as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145321/new/ https://reviews.llvm.org/D145321 Files: clang-tool

[PATCH] D145321: [clang-tidy] altera-id-dependent-backward-branch: fix direct assignment notes

yeputons-gh created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously a note

[PATCH] D145305: [clang-tidy] altera-id-dependent-backward-branch: do not mark all variables

yeputons-gh updated this revision to Diff 502445. yeputons-gh added a comment. Rebased on top of the recent `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145305/new/ https://reviews.llvm.org/D145305 Files: clang-tools-extra/clang-tidy/al

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

yeputons-gh updated this revision to Diff 502442. yeputons-gh added a comment. Rebased on top of the recent 'main'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145304/new/ https://reviews.llvm.org/D145304 Files: clang-tools-extra/test/clang-t

[PATCH] D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test

yeputons-gh added a comment. Absolutely, give we few minutes. Maybe it conflicts with the previous revision that has already landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145304/new/ https://reviews.llvm.org/D145304 __

[PATCH] D145303: clang-tidy altera-id-dependent-backward-branch: print notes after warning

yeputons-gh added a comment. Hi, @carlosgalvezp ! I don't have any commit rights for the LLVM project, so I probably need help. My GitHub handle is `yeputons` (https://github.com/yeputons/), my email for attribution is `egor.suvo...@gmail.com` (that's my first name, last name) Repository: r

[PATCH] D145305: clang-tidy altera-id-dependent-backward-branch: fix #52790

yeputons-gh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/altera/id-dependent-backward-branch.cpp:128 + + for (int i = 0; i < NotThreadID2; i++) { +accumulator++; This line previously yielded a false positive. Now it does not

[PATCH] D145305: clang-tidy altera-id-dependent-backward-branch: fix #52790

yeputons-gh updated this revision to Diff 502372. yeputons-gh added a comment. Applied clang-format to the header as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145305/new/ https://reviews.llvm.org/D145305 Files: clang-tools-extra/clang-t

[PATCH] D145305: clang-tidy altera-id-dependent-backward-branch: fix #52790

yeputons-gh created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Mark variables/fields as ID

[PATCH] D145304: clang-tidy altera-id-dependent-backward-branch: refactor test

yeputons-gh created this revision. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Put all "Inferred Assignments" testing at the end - Group together ID-dependent variable/member testin

[PATCH] D145303: clang-tidy altera-id-dependent-backward-branch: print notes after warning

yeputons-gh created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. yeputons-gh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In Clang notes are typicall