[PATCH] D140462: [clangd] Add schema for `.clangd` config

2023-01-10 Thread Edwin Kofler via Phabricator via cfe-commits
hyperupcall abandoned this revision. hyperupcall added a comment. I think I abandon this revision for the reasons stated above - there is an improved path forward at https://reviews.llvm.org/D140745 with autogenerated files. Reposito

[PATCH] D140462: [clangd] Add schema for `.clangd` config

2023-01-10 Thread Edwin Kofler via Phabricator via cfe-commits
hyperupcall updated this revision to Diff 487706. hyperupcall added a comment. Improve schema correctness and disable `additionalProperties` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140462/new/ https://reviews.llvm.org/D140462 Files: clang-

[PATCH] D140462: [clangd] Add schema for `.clangd` config

2023-01-09 Thread Edwin Kofler via Phabricator via cfe-commits
hyperupcall marked 2 inline comments as done. hyperupcall added a comment. In D140462#4018983 , @sammccall wrote: > The difficulty in testing is that: > > - JSON-schema is totally unknown in llvm-project, so there are no tools but > also no expectation t

[PATCH] D140462: [clangd] Add schema for `.clangd` config

2022-12-26 Thread Edwin Kofler via Phabricator via cfe-commits
hyperupcall added a comment. Thank you for the suggestions - I applied all of the fixes! As someone who helps maintain a lot of the schemas on schemastore, it's nice when schemas are in-tree with their respective project, but I totally understand th

[PATCH] D140462: [clangd] Add schema for `.clangd` config

2022-12-26 Thread Edwin Kofler via Phabricator via cfe-commits
hyperupcall updated this revision to Diff 485352. hyperupcall added a comment. Apply `clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140462/new/ https://reviews.llvm.org/D140462 Files: clang-tools-extra/clangd/schema/config.json In

[PATCH] D140462: [clangd] Add schema for `.clangd` config

2022-12-26 Thread Edwin Kofler via Phabricator via cfe-commits
hyperupcall updated this revision to Diff 485351. hyperupcall added a comment. Improve schema correctness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140462/new/ https://reviews.llvm.org/D140462 Files: clang-tools-extra/clangd/schema/config.js

[PATCH] D140462: [clangd] Add schema for `.clangd` config

2022-12-20 Thread Edwin Kofler via Phabricator via cfe-commits
hyperupcall created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hyperupcall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/cla