[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-06-01 Thread Edward O via Phabricator via cfe-commits
eddy-geek added a subscriber: Eugene.Zelenko. eddy-geek added a comment. @Eugene.Zelenko wrote: > Frankly, I don't think that length-based criteria is reasonable one. > Readability of code is much more important than line/file length. It provides an added configuration flexibility without being

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-27 Thread Edward O via Phabricator via cfe-commits
eddy-geek added a subscriber: sammccall. eddy-geek added a comment. Builds ok, ready for review. I can't edit reviewers now, can someone help? @sammccall ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103188/new/ https://reviews.llvm.org/D103188

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-26 Thread Edward O via Phabricator via cfe-commits
eddy-geek updated this revision to Diff 348081. eddy-geek added a comment. *Trigger rebuild (windows failed to git clone)* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103188/new/ https://reviews.llvm.org/D103188 Files: clang-tools-extra/clang-

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-26 Thread Edward O via Phabricator via cfe-commits
eddy-geek updated this revision to Diff 348080. eddy-geek added a comment. *Trigger rebuild (windows failed to git clone)* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103188/new/ https://reviews.llvm.org/D103188 Files: clang-tools-extra/clang

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-26 Thread Edward O via Phabricator via cfe-commits
eddy-geek updated this revision to Diff 348047. eddy-geek added a comment. *Trigger rebuild (windows failed to git clone)* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103188/new/ https://reviews.llvm.org/D103188 Files: clang-tools-extra/clang-

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-26 Thread Edward O via Phabricator via cfe-commits
eddy-geek updated this revision to Diff 348038. eddy-geek added a comment. Fix test output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103188/new/ https://reviews.llvm.org/D103188 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-26 Thread Edward O via Phabricator via cfe-commits
eddy-geek updated this revision to Diff 348028. eddy-geek added a comment. Fix test build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103188/new/ https://reviews.llvm.org/D103188 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.c

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-26 Thread Edward O via Phabricator via cfe-commits
eddy-geek added a comment. I haven't been able to build locally so far -- OOM on my machine, not sure if I can do something lighter than: cmake -G Ninja -DLLVM_ENABLE_PROJECTS=clang\;clang-tools-extra -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$PWD -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

2021-05-26 Thread Edward O via Phabricator via cfe-commits
eddy-geek created this revision. Herald added a subscriber: xazax.hun. eddy-geek requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes bug 35694 Adds option AutoTypeNameLength, defau