Re: r321099 - [driver][darwin] Take the OS version specified in "-target" as the target

2017-12-24 Thread Duncan Exon Smith via cfe-commits
> On Dec 21, 2017, at 16:39, Alex L wrote: > > > >> On 21 December 2017 at 12:34, James Y Knight wrote: >> I totally agree with moving towards eliminating the -m-version-min >> flags, it's much better to put it in the target, and will clean up a lot of >> cruft in the driver, eventually. >>

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

2017-06-16 Thread Duncan Exon Smith via cfe-commits
> On Jun 15, 2017, at 22:22, Eric Fiselier wrote: > > > >> On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith >> wrote: >> Your suggestion is essentially to replace experimental/string_view with >> something like: >> >> namespace std { inline namespace __1 { namespace experiment

Re: [PATCH] D30009: Add support for '#pragma clang attribute'

2017-04-05 Thread Duncan Exon Smith via cfe-commits
> On Apr 5, 2017, at 05:13, Aaron Ballman via Phabricator > wrote: > > aaron.ballman added inline comments. > > > > Comment at: lib/Sema/SemaAttr.cpp:578 > +return; > + Diag(PragmaAttributeStack.back().Loc, > diag::warn_pragm_attribute_no_pop_eof); > +} > -

Re: [PATCH] D27387: [libc++] Add a key function for bad_function_call

2016-12-05 Thread Duncan Exon Smith via cfe-commits
I haven't looked at the patch, but yes, many developers on our platform back-deploy to older OS versions (and we support that via Clang flags, e.g., -miphoneos-version-min=8.0). They always build against the newest SDK/headers. -- dpnes > On Dec 5, 2016, at 00:35, Eric Fiselier via Phabricator

Re: [libcxx] r263036 - Implement LWG#2583: There is no way to supply an allocator for basic_string(str, pos)

2016-03-11 Thread Duncan Exon Smith via cfe-commits
There's a longer term fix involving availability attributes. My patch to the test system for deployment targets is holding up a series of patches that tell the compiler when API was introduced (with a 'strict' flag). This moves link time errors (and load time errors when back deploying) to co