[PATCH] D99715: [CMake] Fix Python 3 lookup when building LLVM with tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGb78e883fd8b3: [CMake] Fix Python 3 lookup when building LLVM with tests (authored by gargaroff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ ht

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff updated this revision to Diff 335438. gargaroff added a comment. Remove find_package call from Tooling/CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715 Files: clang/lib/Tooling/CMa

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff added a comment. In D99715#2663588 , @serge-sans-paille wrote: > Did you try just removing that `find_package`? Simply removing it also works. I just wasn't sure whether it might be required by something else, but if not I can go ahead and cha

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff added a comment. Although I find it strange, that `find_package` is called again, even though it is already set through `llvm/CMakeLists.txt`, this patch does not try to refactor this in any way. The sole purpose is to make tests executable again in our downstream setup. Repository:

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

gargaroff added a comment. This still breaks for us. The `find_package(Python3 ...)` from `Tooling/CMakeLists.txt` does not look for the minimum version and overrides the version that was already found through `llvm/CMakeLists.txt`. I opened D99715 to fix this

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

gargaroff created this revision. gargaroff added reviewers: serge-sans-paille, dblaikie, jyknight, JDevlieghere, yln, efriedma, ctetreau. Herald added a subscriber: mgorny. gargaroff requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This wil