[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping, can someone review my changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487200. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp clang/test/AST/Interp/shifts.cpp clang/test/C/drs/dr0xx.c clang/test/Sema

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487183. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp clang/test/AST/Interp/shifts.cpp clang/test/C/drs/dr0xx.c clang/test/Sema

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. In D141192#4033962 , @tbaeder wrote: > In D141192#4033591 , @shafik wrote: > >> So it looks like in `handleIntIntBinOp` we do hit this code: >> >> unsigned SA = (unsigned) RHS.getLimit

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. I've modified `handleIntIntBinOp` so now it emits message about bad shift value. `DiagnoseBadShiftValues` changes are also needed because `handleIntIntBinOp` cant properly cover for example the case we are not in c++11 mode. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487174. chestnykh retitled this revision from "[Clang] Add warnings on bad shifts inside enums." to "[Clang] Fix warnings on bad shifts.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/li

[PATCH] D141192: [Clang] Add warnings on bad shifts inside enums.

chestnykh updated this revision to Diff 487168. chestnykh edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp clang/test/AST/Interp/shifts.c

[PATCH] D141192: [Clang] Add warnings on bad shifts inside enums.

chestnykh added a comment. In D141192#4033591 , @shafik wrote: > So it looks like in `handleIntIntBinOp` we do hit this code: > > unsigned SA = (unsigned) RHS.getLimitedValue(LHS.getBitWidth()-1); >if (SA != RHS) { > Info.CCEDiag(E, diag::note_

[PATCH] D141192: [Clang] Add warnings on bad shifts inside enums.

chestnykh created this revision. chestnykh added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. chestnykh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Those warnings were gone because DiagRuntime