Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-30 Thread Dimitry Ivanov via cfe-commits
dimitry added inline comments. Comment at: src/cxa_thread_atexit.cpp:46 @@ +45,3 @@ + pthread_key_delete(key_); +} + bcraig wrote: > dimitry wrote: > > run_dtors() is called when/if libc++.so gets unloaded... but only for the > > thread calling dlclose()

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

2016-06-29 Thread Dimitry Ivanov via cfe-commits
dimitry added a subscriber: dimitry. Comment at: src/cxa_thread_atexit.cpp:46 @@ +45,3 @@ + pthread_key_delete(key_); +} + run_dtors() is called when/if libc++.so gets unloaded... but only for the thread calling dlclose()? http://reviews.llvm.org/D2180

Re: [PATCH] D14858: Support building tsan on android.

2015-11-21 Thread Dimitry Ivanov via cfe-commits
dimitry added a comment. The only difference is that main executable group is not RTLD_GLOBAL in android (it is RTLD_GLOBAL in glibc) - so the symbols of DT_NEEDED libraries are not visible by default; the way to enforce this for you library on android is to use -z global ld option http://rev

Re: [PATCH] D14858: Support building tsan on android.

2015-11-20 Thread Dimitry Ivanov via cfe-commits
dimitry added a subscriber: dimitry. dimitry added a comment. In http://reviews.llvm.org/D14858#294082, @eugenis wrote: > I vaguely recall that android runtime loader had some symbol lookup > differencies with glibc and that prevented interceptors (when statically > linked into the main executa