Re: [PATCH] D23284: Add -Rpass-with-hotness

2016-08-26 Thread Diego Novillo via cfe-commits
dnovillo added a comment. In https://reviews.llvm.org/D23284#526389, @anemet wrote: > @dnovillo or @rsmith, can you please confirm if you agree that this new > option -Rpass-with-hotness should not be part of R_group. R_group options > enable/disable groups of remarks whereas this one is only

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-11 Thread Diego Novillo via cfe-commits
On Sat, Jul 9, 2016 at 7:39 PM Sean Silva wrote: > silvas added a comment. > > In http://reviews.llvm.org/D21823#479418, @davidxl wrote: > > > I should have brought it up earlier, but I forgot.I think a better > (and simpler) proposal is to make -fprofile-generate and -fprofile-use turn > on

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

2016-06-27 Thread Diego Novillo via cfe-commits
dnovillo accepted this revision. dnovillo added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D21737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: r258128 - Add -Wexpansion-to-undefined: warn when using `defined` in a macro definition.

2016-01-19 Thread Diego Novillo via cfe-commits
Thanks! On Jan 19, 2016 3:34 PM, "Nico Weber" wrote: > I think I've fixed all warnings by now, and I've reenabled the warning for > LLVM builds (in r258210; that commit's commit message links to the > individual fixes.) > > On Tue, Jan 19, 2016 at 3:56 PM, Nico Weber wrote: > >> r258181 should s

Re: r258128 - Add -Wexpansion-to-undefined: warn when using `defined` in a macro definition.

2016-01-19 Thread Diego Novillo via cfe-commits
On Tue, Jan 19, 2016 at 3:43 PM, Nico Weber wrote: > I mean you could pass a -Wno flag. It's undefined behavior that's actually > causing bugs in practice; it should probably be on by default. > But then you need to fix all the warnings it's producing in an llvm build. That is currently blocking

Re: r258128 - Add -Wexpansion-to-undefined: warn when using `defined` in a macro definition.

2016-01-19 Thread Diego Novillo via cfe-commits
On Tue, Jan 19, 2016 at 3:30 PM, Nico Weber wrote: > I'll take a look. If it's urgent it's also possible to disable this > warning. > Yeah. I think disabling it by default may be the better choice. Thanks. ___ cfe-commits mailing list cfe-commits@lis

Re: r258128 - Add -Wexpansion-to-undefined: warn when using `defined` in a macro definition.

2016-01-19 Thread Diego Novillo via cfe-commits
Nico, this is producing tons of warnings on an LLVM build and is actually breaking our internal builds (we build with -Werror). I fixed one file that was producing this, but there are several that have the same problem (e.g., gtest-port.h). Could you fix them or rollback? Thanks. Diego. On Tu

r255809 - Add -fsyntax-only to fix failure in read-only directories.

2015-12-16 Thread Diego Novillo via cfe-commits
Author: dnovillo Date: Wed Dec 16 13:52:05 2015 New Revision: 255809 URL: http://llvm.org/viewvc/llvm-project?rev=255809&view=rev Log: Add -fsyntax-only to fix failure in read-only directories. Internally, this test is executed in a read-only directory, which causes it to fail because the driver

r250705 - Sample Profiles - Fix location of binary encoding documentation. NFC.

2015-10-19 Thread Diego Novillo via cfe-commits
Author: dnovillo Date: Mon Oct 19 10:53:17 2015 New Revision: 250705 URL: http://llvm.org/viewvc/llvm-project?rev=250705&view=rev Log: Sample Profiles - Fix location of binary encoding documentation. NFC. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

r250310 - Sample profiles - Update text profile documentation.

2015-10-14 Thread Diego Novillo via cfe-commits
Author: dnovillo Date: Wed Oct 14 13:37:39 2015 New Revision: 250310 URL: http://llvm.org/viewvc/llvm-project?rev=250310&view=rev Log: Sample profiles - Update text profile documentation. There's been some changes to the text encoding for sample profiles. This updates the documentation and an exa

Re: r249316 - [VFS] Add working directories to every virtual file system.

2015-10-05 Thread Diego Novillo via cfe-commits
Never mind. My llvm and clang trees were out of sync. Diego. On Mon, Oct 5, 2015 at 11:15 AM, Diego Novillo wrote: > > > On Mon, Oct 5, 2015 at 9:55 AM, Benjamin Kramer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: d0k >> Date: Mon Oct 5 08:55:20 2015 >> New Revision: 2

Re: r249316 - [VFS] Add working directories to every virtual file system.

2015-10-05 Thread Diego Novillo via cfe-commits
On Mon, Oct 5, 2015 at 9:55 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Mon Oct 5 08:55:20 2015 > New Revision: 249316 > > URL: http://llvm.org/viewvc/llvm-project?rev=249316&view=rev > Log: > [VFS] Add working directories to every virtual file s

Re: [PATCH] D11908: Clang support for -fthinlto.

2015-10-02 Thread Diego Novillo via cfe-commits
On Fri, Oct 2, 2015 at 9:44 AM, Teresa Johnson via cfe-commits < cfe-commits@lists.llvm.org> wrote: As David mentioned, "inlineonly" is much too restrictive for what is > possible. I prefer to stick with "thin" since it refers to this new model > of keeping the whole program part very thin. > Agr

r245941 - Convert SampleProfile pass into a Module pass.

2015-08-25 Thread Diego Novillo via cfe-commits
Author: dnovillo Date: Tue Aug 25 10:25:13 2015 New Revision: 245941 URL: http://llvm.org/viewvc/llvm-project?rev=245941&view=rev Log: Convert SampleProfile pass into a Module pass. Eventually, we will need sample profiles to be incorporated into the inliner's cost models. To do this, we need th