[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

DiegoAstiazaran accepted this revision. DiegoAstiazaran added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66502/new/ https://reviews.llvm.org/D66502 ___ cfe-commits mailing

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369182: [clang-doc] Fix casting not working in gcc 5.4.0 (authored by DiegoAstiazaran, committed by ). Herald added a proj

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

DiegoAstiazaran created this revision. DiegoAstiazaran added a project: clang-tools-extra. An implicit cast of std::string to llvm::SmallString<> was breaking GCC 5.4.0 builder. A pair using llvm::SmallString<> now uses std::string. https://reviews.llvm.org/D66378 Files: clang-tools-extra/cl

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

This revision was automatically updated to reflect the committed changes. Closed by commit rL369139: [clang-doc] Redesign of generated HTML files (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

DiegoAstiazaran updated this revision to Diff 215642. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Add comments. Fix clang-doc version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files: clang-tools-ex

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

DiegoAstiazaran updated this revision to Diff 215624. DiegoAstiazaran added a comment. Run clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/Represen

[PATCH] D66298: [clang-doc] Fix records in global namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rL369123: [clang-doc] Fix records in global namespace (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran updated this revision to Diff 215537. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix tests that were going to fail in Windows. Fix tests broken after rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66298/new/ https://review

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL369075: [clang-doc] Serialize inherited attributes and methods (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215506. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66238/new/ https://reviews.llvm.org/D66238 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeW

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

This revision was automatically updated to reflect the committed changes. Closed by commit rL369068: [clang-doc] Sort index elements case insensitive (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D66268: [clang-doc] Fix use of source-root flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL369065: [clang-doc] Fix use of source-root flag (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D66151: [clang-doc] Fix bitcode writer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369063: [clang-doc] Fix bitcode writer for access specifiers (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. Implement logic to compare the references of the index case insensitive. https://reviews.llvm.org/D66299 F

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. When a Record is declared in the global namespace, clang-doc serializes it as a child of the global namespace, so the global namespace is now one

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:436 + if (const CXXRecordDecl *Base = + cast_or_null(Ty->getDecl()->getDefinition())) { +bool IsVirtual = false; juliehockett wrote: > Will `get

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215304. DiegoAstiazaran marked 11 inline comments as done. DiegoAstiazaran added a comment. Increase version number of clang-doc bitcode. Rename `documentInfo` function to `shouldSerializeInfo`. In new `parseBases` a BaseRecordInfo object is created an

[PATCH] D66268: [clang-doc] Fix use of source-root flag

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, ilya-biryukov. The value, if any, of --source-root flag was not being used. This has been fixed and

[PATCH] D66124: [clang-doc] Add missing check in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL368912: [clang-doc] Add missing check in tests (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. clang-doc now serializes the inherited attributes and methods, not only the name of the base class.

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran updated this revision to Diff 215193. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Use getAccess() instead of getAccessUnsafe() for CXXMethodDecl. Add comments in YAML generator to specify that AS_none is used as the default here because it's

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran updated this revision to Diff 214923. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Default value of AccessSpecifier attributes is now AS_public. Multiple tests modified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66151/new/ htt

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Bitcode writer was not emitting the corresponding record for the Access attribute of a FunctionInfo. This is added and corresponding test is incl

[PATCH] D66124: [clang-doc] Add missing check in tests

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Path is now checked when comparing two Infos in the unit tests. https://reviews.llvm.org/D66124 F

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

This revision was automatically updated to reflect the committed changes. Closed by commit rL368602: [clang-doc] Generate HTML links for children namespaces/records (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D65918: [clang-doc] Generate an HTML index file

This revision was automatically updated to reflect the committed changes. Closed by commit rL368484: [clang-doc] Generate an HTML index file (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran updated this revision to Diff 21. DiegoAstiazaran added a comment. Change the implementation of computeRelativePath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65987/new/ https://reviews.llvm.org/D65987 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clan

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D" instead of a "../D". It is correct + // but it would be better to have the shorter

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368460: [clang-format] Add link to source code in file definitions (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Path is now stored in the references to the child while serializing, then this path is used to generate the relative path in the HTML generator.

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

This revision was automatically updated to reflect the committed changes. Closed by commit rL368313: [clang-doc] Protect Index with mutex during reducing and generation stage (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D65918: [clang-doc] Generate an HTML index file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. clang-doc now generates a file that contains only an index to all the infos that can be used as the landing

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Idx in ClangDocContext instance was being modified by multiple threads causing a seg fault. A mut

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214004. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeW

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214000. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add comments. Move definition of ClangDocContext constructor to .cpp file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.ll

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

This revision was automatically updated to reflect the committed changes. Closed by commit rL368209: [clang-doc] Add second index for sections within info's content (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213991. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/unittests/clang-doc/HTM

[PATCH] D65628: [clang-doc] Parallelize reducing phase

This revision was automatically updated to reflect the committed changes. Closed by commit rL368206: [clang-doc] Parallelize reducing phase (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213986. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Add comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ https://reviews.llvm.org/D65628 Files: clang-tools-extra/clang-doc/tool/ClangD

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72 +static llvm::cl::opt ThreadCount( +"thread-count", juliehockett wrote: > Can we use the pre-existing concurrency flag instead > (https://github.com/llv

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213968. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Use pre-existing concurrency flag `--execute-concurrency` instead implementing a new one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ ht

[PATCH] D65833: [Tooling] Expose ExecutorConcurrency option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368196: [Tooling] Expose ExecutorConcurrency option. (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213776. DiegoAstiazaran added a comment. Remove unnecessary type casting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/cl

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/docs/clang-doc.rst:93 +--public- Document only public declarations. +--repository= - + URL of repository that hosts code. julie

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213772. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Add comments. Change name of flag; `root-directory` -> `--source-root` Moved fixing of repository link to Cl

[PATCH] D65833: [Tooling] Expose ExecutorConcurrency option.

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. https://reviews.llvm.org/D65833 Files: clang/include/clang/Tooling/AllTUsExecution.h clang/lib/Tooling/AllTUsExecution.cpp Index: clang/lib/Tooling/AllTUsExecution.cpp

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL368087: [clang-doc] Fix paths of js in import tags (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (let's make sure we double check this

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213706. DiegoAstiazaran added a comment. Changed `JumpToSection` in Index struct and `genHTML(const Index &Index, ...)` function to `llvm::Optional`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030

[PATCH] D65690: [clang-doc] Add index in each info html file

This revision was automatically updated to reflect the committed changes. Closed by commit rL368070: [clang-doc] Add index in each info html file (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.cpp:79 + +bool Generator::createResources(ClangDocContext &CDCtx) { + std::error_code OK; juliehockett wrote: > Why is this implementation in the generic Generator? It's fa

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + juliehockett wrote: > DiegoAstiazaran wrote: > > juliehockett wrote: > > > Formatting is

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 213513. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Moved serialization of Index to HTML generator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 Files: cla

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213509. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a parent revision: D65690: [clang-doc] Add index in each info html file. DiegoAstiazaran added a comment. Changed depe

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D65690 replaces this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65003/new/ https://reviews.llvm.org/D65003 ___ cfe-comm

[PATCH] D64958: [clang-doc] Fix link generation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367958: [clang-doc] Fix link generation (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213498. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files: clang-tools-extra/clang-doc/BitcodeRe

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213425. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Herald added a subscriber: jfb. Fix atomicity issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ https://reviews.llvm.org/D65628 Files:

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran added a subscriber: phosek. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); +

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 213171. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix format of index.js file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 Files: clang-tools-extra/clang

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/assets/index.js:17 + return FilePath.substring(Path.length + 1) + Path = Path.substring(0, Path.lastIndexOf("/")); + } phosek wrote: > Wrong indentation? Yes, clang-format "

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213169. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran added a comment. Change http to https as the default fix to the repository link. Add new flags to clang-doc documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D65622: [clang-doc] Update documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367743: [clang-doc] Update documentation (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D65622: [clang-doc] Update documentation

DiegoAstiazaran updated this revision to Diff 213162. DiegoAstiazaran added a comment. Specify that `stylesheets` flag is only required for html format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65622/new/ https://reviews.llvm.org/D65622 Files: clang-tools-extra/docs/ReleaseNotes

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett, phosek. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, mgorny. An index structure is created while generating the output file for each info

[PATCH] D65627: [clang-doc] Add flag to continue after mapping errors

This revision was automatically updated to reflect the committed changes. Closed by commit rL367729: [clang-doc] Add flag to continue after mapping errors (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213128. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files: clang-tools-extra/clang-doc/BitcodeRea

[PATCH] D65627: [clang-doc] Add flag to continue after mapping errors

DiegoAstiazaran updated this revision to Diff 213126. DiegoAstiazaran retitled this revision from "[clang-doc] Continue after mapping error" to "[clang-doc] Add flag to continue after mapping errors". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. A flag has

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Reduce phase has been parallelized and a execution time was reduced by 60% with this. The reading o

[PATCH] D65627: [clang-doc] Continue after mapping error

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. The tool used to stop execution if there was an error in the mapping phase. It will now show the er

[PATCH] D65622: [clang-doc] Update documentation

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. HTML generator has been included in clang-tools-extra release notes. clang-doc documentation file has been updated. https://reviews.llvm.org/D65

[PATCH] D65483: [clang-format] Add link to source code in file definitions

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Two command line options have been added to clang-doc. --repository= - URL of r

[PATCH] D65425: [clang-doc] Fix expected output in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL367279: [clang-doc] Fix expected output in tests (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D65425: [clang-doc] Fix expected output in tests

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Removes conversion of html paths in output. These will always be in posix-style paths. https://reviews.llvm.org/D65425 Files: clang-tools-extra/unittests

[PATCH] D65419: [clang-doc] Fix failing tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL367264: [clang-doc] Fix failing tests on Windows (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D65419: [clang-doc] Fix failing tests on Windows

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Tests on Windows were failing due to path separator differences. Links in HTML should use posix-style paths. https://reviews.llvm.org/D65419 Files: clang-

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 211979. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Change attribute used to check special case of global namespace; IsPathValid changed to IsInGlobalNamespace. This attribute is true when its first parent is

[PATCH] D65309: [clang-format] Fix style of css file paths

This revision was automatically updated to reflect the committed changes. Closed by commit rL367137: [clang-format] Fix style of css file paths (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D65309: [clang-format] Fix style of css file paths

DiegoAstiazaran updated this revision to Diff 211971. DiegoAstiazaran added a comment. Add comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65309/new/ https://reviews.llvm.org/D65309 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/unittests/clang-doc/HT

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + juliehockett wrote: > Formatting is a bit weird for sublists Fixed by D65005. It will be

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 211869. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Add comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 Files: clang-tools-extra/clang-doc/HTMLGenera

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:337-346 + + A + B + C + + D + E juliehockett wrote: > The indentation here seems a bit off Fixed by D65005. CHANGES SINCE LAST ACTION https://r

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 211866. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Rebase and add comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65003/new/ https://reviews.llvm.org/D65003 Files: clang-tools-extra/clang-do

[PATCH] D65309: [clang-format] Fix style of css file paths

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. CSS files included in HTML should have a path in posix style, it should not be different for Windows. https://reviews.llvm.org/D65309 Files:

[PATCH] D65306: [clang-doc] Fix failing tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL367074: [clang-doc] Fix failing tests on Windows (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D65306: [clang-doc] Fix failing tests on Windows

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. Make sure you update the other stylesheet p

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

This revision was automatically updated to reflect the committed changes. Closed by commit rL367072: [clang-doc] Add option for user provided stylesheets (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

DiegoAstiazaran updated this revision to Diff 211841. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64938/new/ https://reviews.llvm.org/D64938 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5d8e3db253: [clang-doc] Add stylesheet to generated html docs (authored by DiegoAstiazaran). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 211820. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D65005: [clang-doc] Fix output format of html

This revision was automatically updated to reflect the committed changes. Closed by commit rL367050: [clang-doc] Fix output format of html (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D65005: [clang-doc] Fix output format of html

DiegoAstiazaran updated this revision to Diff 211812. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65005/new/ https://reviews.llvm.org/D65005 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp Index: clang-tools-extra/un

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

This revision was automatically updated to reflect the committed changes. Closed by commit rL367045: [clang-doc] Fix html entities in rendered text (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran added a comment. In D64958#1601228 , @juliehockett wrote: > Under what circumstances, exactly, is the path not set where you would need > to create a link despite that? Is it only in the global namespace case? If > so, could you special-

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:137 +// saved (possibly unresolved) + bool IsPathValid = false; // Indicates if a value has been assigned to Path, +

[PATCH] D64938: [clang-doc] Add option for user provided stylesheets

DiegoAstiazaran updated this revision to Diff 211362. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Add a second CSS file to one of the tests in HTMLGeneratorTest.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64938/new/ https://reviews.llvm.org/D

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran updated this revision to Diff 211201. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Use printHTMLEscaped() in ADT/StringExtras.h to write HTML entities. CHANGES SINCE LAST ACTION https://r

[PATCH] D65107: [clang-doc] Fix html entities in rendered text

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Replace <, > and " with its corresponding html entities before rendering text nodes. https://reviews.llvm.org/D65107 Files: clang-tools-extr

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. This new index contains links to the main section of infos: Namespaces, Records, Functions, Enum

  1   2   >