[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

2022-11-08 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added subscribers: dhruvachak, dreachem. dreachem added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @jdoerfert @tianshilei1992 @atmnpatel @dhruvachak Is the target to get this merged in for LLVM 16? Does the VGPU implementation provide a way to support OM

[PATCH] D133694: [Clang][OpenMP] Fix use_device_addr

2022-09-12 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added inline comments. Comment at: clang/test/OpenMP/target_data_use_device_addr_codegen_ptr.cpp:14 +{ +#pragma omp target data use_device_addr(x) +{ ye-luo wrote: > doru1004 wrote: > > doru1004 wrote: > > > ye-luo wrote: > > > > doru

[PATCH] D119440: [OpenMP][NFC] update status for 5.1 'nothing' directive to 'worked on'

2022-02-10 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem created this revision. dreachem added reviewers: cchen, jdoerfert, koops. Herald added subscribers: guansong, yaxunl. dreachem requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://

[PATCH] D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension

2021-12-16 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem created this revision. dreachem added reviewers: jdoerfert, koops, cchen. Herald added subscribers: guansong, yaxunl. dreachem requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Update status for the atomic 'fail' clause to "

[PATCH] D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive

2021-10-22 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added a comment. There still exists a restriction that the loop variable must not be threadprivate in OpenMP 5.1. See Canonical Loop Nest restrictions, p125, line 7: > The loop iteration variable may not appear in a threadprivate directive. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D91944: OpenMP 5.0 metadirective

2020-12-16 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added a comment. In D91944#2414364 , @jdoerfert wrote: > This looks close to an OpenMP 5.0 implementation. I left comments inlined. > > We need tests that show how non-selected alternatives *do not* impact the > program. As an example, a template

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

2020-11-05 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added a comment. I don't have commit access. @jdoerfert, please commit the change if you think it's ready. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90802/new/ https://reviews.llvm.org/D90802 ___ cfe-commits mailing list

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

2020-11-05 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem updated this revision to Diff 303258. dreachem added a comment. Marking the "begin/end declare variant" feature as 'done' in the 5.1 table. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90802/new/ https://reviews.llvm.org/D90802 Files: clang/docs/OpenMPSupport.rst Index: cl

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

2020-11-05 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added inline comments. Comment at: clang/docs/OpenMPSupport.rst:343 ++--+--+--+---+ +| misc

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

2020-11-04 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem created this revision. dreachem added reviewers: kkwli0, jdoerfert, ABataev, RaviNarayanaswamy. Herald added subscribers: cfe-commits, jfb, guansong, yaxunl. Herald added a project: clang. dreachem requested review of this revision. Herald added a subscriber: sstefan1. Adding features in

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

2020-01-22 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added inline comments. Comment at: clang/docs/OpenMPSupport.rst:210 +--+--+--+---+ -| dev

[PATCH] D69923: [OPENMP][DOCS] Update OpenMP status (NFC)

2019-11-07 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem added a comment. I don't believe I have commit permissions on this. @ABataev, can you commit this? Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69923/new/ https://reviews.llvm.org/D69923 ___ cfe-co

[PATCH] D69923: [OPENMP][DOCS] Update OpenMP status (NFC)

2019-11-06 Thread Deepak Eachempati via Phabricator via cfe-commits
dreachem created this revision. dreachem added reviewers: ABataev, hfinkel, jdoerfert, kkwli0. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This is updating the OpenMP status table. Cray has volunteered for `defaultmap` and supporting `in_reduction` on the `targ