[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd31a689844: [NFC] Add SmallVector constructor to allow creation of SmallVector from… (authored by yurai007). Repository: rG LLVM Github Monor

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 updated this revision to Diff 450259. yurai007 added a comment. Fix std::initializer_list lifetime issue in test case revealed on CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130268/new/ https://reviews.llvm.org/D130268 Files: llvm/

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 updated this revision to Diff 450069. yurai007 marked an inline comment as done. yurai007 added a comment. Rebase to last SmallVector NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130268/new/ https://reviews.llvm.org/D130268 Files:

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 marked an inline comment as done. yurai007 added inline comments. Comment at: llvm/unittests/ADT/SmallVectorTest.cpp:867 - template - static unsigned NumBuiltinElts(const SmallVector&) { return N; } }; fhahn wrote: > This seems like an unrelated chan

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 updated this revision to Diff 449963. yurai007 edited the summary of this revision. yurai007 added a comment. Rebase and fix last comment. Remove dependency to https://reviews.llvm.org/D129781 by moving relevant part of change here. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added a comment. In D130268#3684244 , @nikic wrote: > I think my only concern with this change is that it will also allow some > implicit ArrayRef constructors. For example, this will permit creating a > SmallVector from `std::array`, `std::vec

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added a comment. Drop WIP tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130268/new/ https://reviews.llvm.org/D130268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 marked an inline comment as done. yurai007 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); +

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 updated this revision to Diff 446773. yurai007 edited the summary of this revision. yurai007 added a comment. Update constructor definition with explicit to avoid implicit conversions and remove ambiguity workarounds. Adjust constructor users and add unit tests. Repository: rG LLVM G

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added a comment. Instead adding one more constructor another option is tweaking existing SmallVector(const iterator_range &R) one in following way: - template - explicit SmallVector(const iterator_range &R) - : SmallVectorImpl(N) { + template , T>::value>> + SmallVec

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 created this revision. yurai007 added reviewers: nikic, dexonsmith, wolfgangp, dblaikie. Herald added subscribers: jsji, ecnelises, pengfei, kbarton, hiraditya, nemanjai. Herald added a project: All. yurai007 requested review of this revision. Herald added projects: clang, LLVM. Herald ad

[PATCH] D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization

This revision was automatically updated to reflect the committed changes. Closed by commit rGf54ca1f63264: [NFC][Coroutines] Add regression test for heap allocation elision optimization (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization

yurai007 created this revision. yurai007 added reviewers: nikic, ChuanqiXu, lxfind, GorNishanov. Herald added a project: All. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Recently C++ snippet included in this patch popped up at

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

yurai007 added a comment. Indeed, measuring performance is tricky and chasing slow downs can be challenging especially those at the level of ~0.2%-0.1% or less. Personally, every time when I need to use perf on Clang I follow those short guidelines to reduce noise and get relevant numbers: ht

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

yurai007 added a comment. Disclaimer: I'm not front-end guy. After running 7zip benchmark under perf and comparing origin (7acc88be031 ) with fix (0d300da799b0

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. In D123300#3474834 , @nikic wrote: > @yurai007 I've put up https://reviews.llvm.org/D124459 to fix this > optimization failure. @nikic: I can confirm that patch fix regression and makes coroutines snippet great again. Thanks!

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. Just one more thing regarding this: In D123300#3467165 , @yurai007 wrote: > Hi, unfortunately for some reason it doesn't play well with coroutines HALO. > There is regression seen on Gor's Nishanov classical code snippet: > h

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. Hi, unfortunately for some reason it doesn't play well with coroutines HALO. There is regression seen on Gor's Nishanov classical code snippet: https://godbolt.org/z/PKMxqq4Gr I'm checking IR to find out more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

This revision was automatically updated to reflect the committed changes. Closed by commit rGd813116c9dea: [NFC][Lexer] Remove getLangOpts function from Lexer (authored by yurai007). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 added a comment. Rebased to https://reviews.llvm.org/D120334 and simplified by removing non-static Lexer::getSpelling function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120404/new/ https://reviews.llvm.org/D120404 __

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 updated this revision to Diff 412120. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120404/new/ https://reviews.llvm.org/D120404 Files: clang/include/clang/Lex/Lexer.h clang/lib/Lex/Lexer.cpp clang/lib/Lex/ModuleMap.cpp Index: clang

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa64d3c602fb7: [NFC][Lexer] Make Lexer::LangOpts const reference (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. All comments were addressed. Since broken libarcher/libomp/libomptarget UT are seen on others patches too I think it has nothing to do with this particular change. There is no speed degradation in comparison to LangOptionsBase approach so I believe now change is mature

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 updated this revision to Diff 411770. yurai007 edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 Files: clang/include/clang/Lex/Lexer.h clang/lib/Format/Forma

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added inline comments. Comment at: clang/include/clang/Lex/Lexer.h:94 + // LangOpts enabled by this language. + const LangOptions &LangOpts; + cor3ntin wrote: > Should we add a comment to explain why this is a reference? Good idea. It will be added.

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. In D120334#3340639 , @cor3ntin wrote: > I like this approach. it seems a lot easier to maintain as people don't have > to remember to use LangOptionsBase to not degrade performance I like it either but we need to be careful abo

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. Unfortunately after change there is lifetime issue in FormatTokenLexer because LangOpts received from getFormattingLangOpts has automatic storage duration and Lexer gets reference to it. Fix issue and poke CI to make sure clang-tools-extra tests on CI are passing. For

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 updated this revision to Diff 411368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 Files: clang/include/clang/Lex/Lexer.h clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/FormatToken

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 updated this revision to Diff 410802. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120404/new/ https://reviews.llvm.org/D120404 Files: clang/include/clang/Lex/Lexer.h clang/lib/Lex/Lexer.cpp clang/lib/Lex/ModuleMap.cpp Index: clang/

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. Use simpler approach with const LangOptions reference + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 ___ cfe-commits mailin

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 updated this revision to Diff 410801. yurai007 retitled this revision from "[NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts" to "[NFC][Lexer] Make Lexer::LangOpts const reference". yurai007 edited the summary of this revision. Repository: rG LLVM Github Mono

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

yurai007 added a comment. In D120334#3339764 , @serge-sans-paille wrote: > A small local test hints that using a ``SmallVector`` instead of a > ``std::vector`` also fixes the assembly bloat. I don't know if it's worth > considering as an alternative or

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:1617 const char *Start = SpellingBuffer.data(); -unsigned Length = -Lexer::getSpelling(LToken, Start, SourceMgr, L.getLangOpts()); +unsigned Length = L.getSpelling(LToken, Start, SourceMg

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

yurai007 added a comment. Mentioned follow-up: https://reviews.llvm.org/D120404 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120333 ___ cfe-commits mailing list cfe

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

yurai007 created this revision. yurai007 added reviewers: serge-sans-paille, cor3ntin, jansvoboda11, ymandel, nikic, xbolva00. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Give that there is only one external user of Lexer::get

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbe38a784e28: [NFC][Lexer] Make access to LangOpts more consistent (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

yurai007 added a comment. Thank you all for review! In D120333#3339730 , @serge-sans-paille wrote: > I don't object to the change but it may me wonder if there would be a way to > remove the apparent redundancy in the API here? If you don't mind let m

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

yurai007 added a comment. In D120334#3338367 , @jansvoboda11 wrote: > In D120334#3338314 , @yurai007 > wrote: > >> In D120334#3337961 , @jansvoboda11 >> wrote: >> >>> T

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

yurai007 added a comment. In D120334#3337961 , @jansvoboda11 wrote: > The performance implications are pretty interesting! Have you tried avoiding > the copy altogether by just storing the reference? Yes, actually that was my first attempt but I failed

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

yurai007 created this revision. yurai007 added reviewers: xbolva00, nikic, serge-sans-paille, aeubanks, jansvoboda11, ymandel, cor3ntin. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change can be seen as code cleanup but m

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, serge-sans-paille, ymandel, jansvoboda11, cor3ntin. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this change without any good reason Lexer::LangO

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d8d3a11c4d4: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes (authored by yurai007). Repository: rG LLVM Github Mo

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

yurai007 added a comment. In D118608#3290086 , @serge-sans-paille wrote: > Thanks, that's helpful. Any hint about why this particular values? Sure, let me elaborate on this. Initial capacities were empirically chosen to reduce number of internal hashta

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, aeubanks, ChuanqiXu, v.g.vassilev, serge-sans-paille. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Among many FoldingSet users most notable seem to be A

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 added a comment. In D118385#3281620 , @nikic wrote: > It might make sense to split this into individual changes, so it's clearer > what impact each of them has. > > I tested just moving the `AddXYZ` methods into the header, which had a large >

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void AddInteger(u

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 marked 3 inline comments as done. yurai007 added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - vo

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 updated this revision to Diff 403951. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118385/new/ https://reviews.llvm.org/D118385 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/CodeGenTypes.h

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, aeubanks, ChuanqiXu, v.g.vassilev, serge-sans-paille, rsmith. Herald added subscribers: dexonsmith, pengfei, hiraditya. yurai007 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscriber

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb88ca619d33b: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

yurai007 added a comment. Thank you all for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

yurai007 created this revision. yurai007 added reviewers: nikic, xbolva00, erichkeane, craig.topper, aeubanks, Tyker. Herald added a subscriber: pengfei. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeGenModule::DeferredDecls