[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

davidvc1 added a comment. Herald added a project: All. @curdeius , the PR description mentions the reason: when you pipe input from stdin, clang-format has to run through the "is it objective C?" codepath, and this is the codepath with the bug. On the other hand, when you pass a .cpp file as a

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

davidvc1 added a comment. + @rsmith from CODE_OWNERS.txt: Hi Richard, could you please suggest a reviewer for this change? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114837/new/ https://reviews.llvm.org/D114837

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

davidvc1 added a comment. Hi @curdeius, I'm new to the project and I'm adding you as a reviewer because I noticed you reviewed a number of recent changes in this directory. Are you a good reviewer for this change? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types

davidvc1 created this revision. davidvc1 added a reviewer: curdeius. davidvc1 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Running `clang-format` on the following input int lambdas() { return [&] { return [&] { return [&

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

davidvancleve added a comment. Hi klimek, any more action needed on my part to land this? This is my first LLVM change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89920/new/ https://reviews.llvm.org/D89920 _

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

davidvancleve added a comment. +klimek: I added you from glancing at CODE_OWNERS.txt; are you a good reviewer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89920/new/ https://reviews.llvm.org/D89920 ___

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

davidvancleve created this revision. davidvancleve added a reviewer: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. davidvancleve requested review of this revision. This change adds another export, `using TemplateArgumentMatcher = internal::Matcher;`, to the collecti

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Seems like it's working as expected now! Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099 ___ cfe-commits mailing li

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Super! Once we pull in that version (unsure of the latency; this is my first time reporting an issue with clangd), I'll be sure to come back and confirm that the fix is working for me. Thank you again for the quick turnaround! Repository: rG LLVM Github Monorep

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Yes, these two are exactly the case! > - you'd be using an editor/plugin that sends compile commands over LSP (such > as YCM + ycm_extra_conf). What are you using? > - there should be relatively few *.idx files inside the extra directories > (the ones not near you

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Thanks for the quick response! Nope, no compile_commands.json files, and they didn't previously contain .clangd files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099 _

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Hey, quick question about this change: I'm seeing .cache directories appear off of subdirectories too, not just my project root: Untracked files: 31 #» .cache/