dtellenbach wrote:
@EthanLuisMcDonough I think your patch effectively introduces a dependency on
libc because `__llvm_write_custom_profile` has `__attribute__((uses))`` but
calls e.g. `atoi` through `setupIOBuffer`.
In compiler-rt it's not safe to make that assumption because it potentially
b
dtellenbach wrote:
@EthanLuisMcDonough I think your patch effectively introduces a dependency on
libc because `__llvm_write_custom_profile` has `__attribute__((used))`` but
calls e.g. `atoi` through `setupIOBuffer`.
In compiler-rt it's not safe to make that assumption because it potentially
b
dtellenbach wrote:
Hi @EthanLuisMcDonough, this unfortunately breaks
-
[Profile-x86_64.Profile-x86_64.instrprof-darwin-dead-strip.c](https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-RA/3529/testReport/junit/Profile-x86_64/Profile-x86_64/instrprof_darwin_dead_strip_c/),
and
-
[Profile-
https://github.com/dtellenbach closed
https://github.com/llvm/llvm-project/pull/98097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtellenbach wrote:
Linux test failure seems unrelated (fails to build some libcxx stuff). The new
test passes:
```
PASS: Clang :: CodeGen/aarch64-inlineasm-ios.c (14316 of 95454)
```
https://github.com/llvm/llvm-project/pull/98097
___
cfe-commits
https://github.com/dtellenbach edited
https://github.com/llvm/llvm-project/pull/98097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,23 @@
+// REQUIRES: aarch64-registered-target
dtellenbach wrote:
Yep, seems like I accidentally added a new folder. Targets other than AArch64
and Arm use a subfolder but still rely on `REQUIRES`. AArch64 just dumps
everything into the top-level test
https://github.com/dtellenbach updated
https://github.com/llvm/llvm-project/pull/98097
>From 46e32d1156e38653c79682600fbf63d964277dba Mon Sep 17 00:00:00 2001
From: David Tellenbach
Date: Mon, 8 Jul 2024 16:04:18 -0700
Subject: [PATCH 1/2] [AsmPrinter] Don't check for inlineasm dialect on non-X
dtellenbach wrote:
@MaskRay the added test fails since your commit
https://github.com/llvm/llvm-project/commit/f4335f075b3496bce6b49f9267e6160d1824b1bb.
The commit itself is alright, just exposed the underlying problem.
https://github.com/llvm/llvm-project/pull/98097
__
https://github.com/dtellenbach created
https://github.com/llvm/llvm-project/pull/98097
AArch64 uses MCAsmInfo::AssemblerDialect to control the style of emitted Neon
assembly. E.g. Apple platforms use AsmWriterVariantTy::Apple by default which
collides with InlineAsm::AD_Intel (both value 1). C
https://github.com/dtellenbach approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/89483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtellenbach closed
https://github.com/llvm/llvm-project/pull/82192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtellenbach created
https://github.com/llvm/llvm-project/pull/82192
None
>From 23b311470d4609fa394bc51b6fce8af83aeff022 Mon Sep 17 00:00:00 2001
From: David Tellenbach
Date: Sun, 18 Feb 2024 14:46:43 -0800
Subject: [PATCH] [clang][CodeCoverage] Fix conditional-operator test
https://github.com/dtellenbach closed
https://github.com/llvm/llvm-project/pull/82141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,25 @@
+// RUN: %clang_cc1 -mllvm -emptyline-comment-coverage=false
-fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping
-emit-llvm-only %s | FileCheck %s
+
+// CHECK-LABEL: binary_conditional:
+// CHECK-NEXT: File 0, [[@LINE+4]]:31 -> {{
https://github.com/dtellenbach updated
https://github.com/llvm/llvm-project/pull/82141
>From f8e11fed8b4b6b0cc359e2915e4f2f32c3f08bb5 Mon Sep 17 00:00:00 2001
From: David Tellenbach
Date: Sat, 17 Feb 2024 15:16:39 -0800
Subject: [PATCH 1/2] [clang][CodeCoverage] Fix CoverageMapping for binary
https://github.com/dtellenbach created
https://github.com/llvm/llvm-project/pull/82141
Fix an issue that produces a wrong coverage mapping when using binary
conditional operators as show in the example below.
Before this patch:
```
1| 1|int binary_cond(int x) {
2| 1| x = x
dtellenbach wrote:
> It should be fixed by
> [56e205a](https://github.com/llvm/llvm-project/commit/56e205a89cbb114750f2bd3f5cfbd19e209d018a).
Thank you!
https://github.com/llvm/llvm-project/pull/70856
___
cfe-commits mailing list
cfe-commits@lists.ll
dtellenbach wrote:
@ZequanWu this seems to cause issues on macOS:
https://green.lab.llvm.org/green/job/clang-stage1-RA/36184/console
```
Profile-x86_64 :: Darwin/instrprof-debug-info-correlate.c
Profile-x86_64 :: instrprof-darwin-
Profile-x86_64h :: Darwin/instrprof-debug-info-correlate.c
Profil
19 matches
Mail list logo
