https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/134612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -463,6 +466,7 @@ X86 Support
Arm and AArch64 Support
^^^
+- For ARM targets, cc1as now considers the FPU's features for the selected CPU
or Arch.
DavidSpickett wrote:
Arch -> architecture
https://github.com/llvm/llvm-project/pull/1346
@@ -0,0 +1,32 @@
+// REQUIRES: arm-registered-target
+// Ensures that when targeting an ARM target with an Asm file, clang
DavidSpickett wrote:
I have often been asked to use `///` for comments that were actually comments.
I think it is marginally easier to read
@@ -0,0 +1,32 @@
+// REQUIRES: arm-registered-target
+// Ensures that when targeting an ARM target with an Asm file, clang
+// collects the features from the FPU. This is critical in the
+// activation of NEON for supported targets. The Cortex-R52 will be
+// used and tested for V
@@ -0,0 +1,32 @@
+// REQUIRES: arm-registered-target
+// Ensures that when targeting an ARM target with an Asm file, clang
+// collects the features from the FPU. This is critical in the
+// activation of NEON for supported targets. The Cortex-R52 will be
+// used and tested for V
@@ -679,20 +679,17 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver
&D,
CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind :
ArchArgFPUKind;
(void)llvm::ARM::getFPUFeatures(FPUKind, Features);
} else {
-bool Generic = true;
-if (!ForAS) {
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/134366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver
&D,
CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind :
ArchArgFPUKind;
(void)llvm::ARM::getFPUFeatures(FPUKind, Features);
} else {
+bool Generic = true;
if (!ForAS) {
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver
&D,
CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind :
ArchArgFPUKind;
(void)llvm::ARM::getFPUFeatures(FPUKind, Features);
} else {
+bool Generic = true;
if (!ForAS) {
@@ -38,6 +38,9 @@ Potentially Breaking Changes
- Fix missing diagnostics for uses of declarations when performing typename
access,
such as when performing member access on a '[[deprecated]]' type alias.
(#GH58547)
+- For ARM targets, when using cc1as, the features included
https://github.com/DavidSpickett commented:
I see that this would be breaking for code unintentionally relying on the
features being omitted, but it makes sense to fix it nevertheless. I would have
expected us to add the features all along.
What does gcc/binutils do in this scenario? I don't t
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/130589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
> used to emable or disable
enable
https://github.com/llvm/llvm-project/pull/130623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/130589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/130589
https://github.com/llvm/llvm-project/pull/129952 /
42d49a77241df73a17cb442973702fc460e7fb90 added this test which is failing on
32-bit ARM because the alignment chosen is 4 not 8. Which would make sense i
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/130589
https://github.com/llvm/llvm-project/pull/129952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
The failure above is real, ABI or 32-bitness issue I think. Looking at it now.
https://github.com/llvm/llvm-project/pull/129952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
DavidSpickett wrote:
Can someone from @llvm/reviewers-libcxx help with the FreeBSD failure? Seems
unrelated.
https://github.com/llvm/llvm-project/pull/103473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/126488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/126352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I also looked at this but got into a rabbit hole finding out whether you could
have channel specific invites. I think you can, but I don't think it actually
helps us. As the other problem we have had is invites expiring, so the fewer
unique invite links the better.
https:
https://github.com/DavidSpickett approved this pull request.
Just looking at this on Linaro's bots, thanks for the fix!
https://github.com/llvm/llvm-project/pull/126488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
DavidSpickett wrote:
> You can check the CI logs for the exact command line it uses and replicate it
> locally.
Should be towards the start of the log, search for `cmake ` to find the command.
https://github.com/llvm/llvm-project/pull/126243
___
cfe-
DavidSpickett wrote:
> As for the cases mentioned, when I tried compile all projects (compile with
> -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and
> I've fixed them all.
> Now all projects can be successfully built, so I think it should be fine?
Just to explain why
DavidSpickett wrote:
> I have seen this before
https://github.com/llvm/llvm-project/commit/a2bd5db00d07bc28fcfb3350b9d50e72e6350cba
https://github.com/llvm/llvm-project/pull/125737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
DavidSpickett wrote:
I wonder if it is only happening on a rebuild not a clean build. This one was
clean:
https://lab.llvm.org/buildbot/#/builders/65/builds/11869
But your test did not fail (I assume did not run). This one is a rebuild:
https://lab.llvm.org/buildbot/#/builders/65/builds/11870
DavidSpickett wrote:
I've pushed a fix for one of the tests on 32 bit Arm, as it failed on our bot:
https://lab.llvm.org/buildbot/#/builders/154/builds/11413/steps/5/logs/FAIL__Clang__offload-Xarch_c
Maybe your intent was specifically to have a line that uses the host
architecture, if that was
Author: David Spickett
Date: 2025-02-05T17:17:37Z
New Revision: 9deafad7ab00c81c9869d50bfde2aa47bdaa6dd7
URL:
https://github.com/llvm/llvm-project/commit/9deafad7ab00c81c9869d50bfde2aa47bdaa6dd7
DIFF:
https://github.com/llvm/llvm-project/commit/9deafad7ab00c81c9869d50bfde2aa47bdaa6dd7.diff
LOG
DavidSpickett wrote:
Might be as simple as a constant true or false, but I'm nearing the end of my
work day so I've reverted it for now.
In the meantime, @Michael137 might know if this is something LLDB should
actually be tracking. Or in other words, is
https://github.com/llvm/llvm-project/is
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/125710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,65 @@
+#include "clang/Sema/Common.h"
+
+namespace clang {
DavidSpickett wrote:
https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions
For example clang::CheckArgTypeIsCorrect instead of opening
https://github.com/DavidSpickett commented:
Just a drive by style comment.
https://github.com/llvm/llvm-project/pull/125045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/125045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/122095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett approved this pull request.
My understanding is that:
* This PR does not conflict with what the Debian patch does.
* It in fact will fix a bug in the Debian build.
* This does not change the behaviour of an unmodified Clang from a user's
perspective, therefore we
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver
&D,
CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind :
ArchArgFPUKind;
(void)llvm::ARM::getFPUFeatures(FPUKind, Features);
} else {
+bool Generic = true;
if (!ForAS) {
DavidSpickett wrote:
Make sure to update the *PR Description* as this becomes the commit message
when the squash and merge happens.
(yes, this is confusing but that's how llvm is set up)
But what I read makes sense thank you for rephrasing the commit message.
https://github.com/llvm/llvm-proj
DavidSpickett wrote:
Yeah, my first impression from the commit message was that you removed the
check entirely.
https://github.com/llvm/llvm-project/pull/122969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/122881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1071,6 +1071,10 @@ Arm and AArch64 Support
- Implementation of SVE2.1 and SME2.1 in accordance with the Arm C Language
Extensions (ACLE) is now available.
+- For ARM baremetal targets, the frame pointer (FP) is now turned off by
+ default. To turn on frame pointers for
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/122881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1076,6 +1076,8 @@ Arm and AArch64 Support
in leaf functions after enabling ``-fno-omit-frame-pointer``, you can do so
by adding
the ``-momit-leaf-frame-pointer`` option.
+- For ARM baremetal targets, the frame pointer (FP) is now turned off by
default.
--
DavidSpickett wrote:
Setting default features for a platform based on what we happened to choose
(likely with a very thin justification) to be the default CPU sounds fragile to
me, so I think this patch is a good step forward. Even if there weren't this
downstream patch interacting with it, I
DavidSpickett wrote:
Or is it that this change allows other downstreams to patch the Linux issue in
a way that does not break Windows and iOS in the process?
If I'm using clang on Debian, that's where I would find this C can use Neon but
assembly cannot problem.
https://github.com/llvm/llvm-p
DavidSpickett wrote:
> In practice, when compiling C for Windows/ARMv7, NEON actually still is
> available, but not when compiling assembly files.
So the "bug" if we're going to call it that, is that C code can produce Neon
but assembly files compiled in the same way cannot use Neon instructi
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Updated to list @frasercrmck and @tstellar for libclc. Tell me if that works
for now, perhaps you can sort out any additions later.
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.ll
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/118309
>From 409dd1184f1c4ff9f11e2d715b6e4a496c70c7e4 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 2 Dec 2024 15:22:50 +
Subject: [PATCH 1/2] [libclc] Add Maintainers.md for libclc
---
libclc/Ma
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/120739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Thanks for the fix!
https://github.com/llvm/llvm-project/pull/120739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool
&HasGet,
->getCanonicalTypeUnqualified();
}
}
-}
+} break;
DavidSpickett wrote:
On second thought, there are a ton of these in
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/120739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool
&HasGet,
->getCanonicalTypeUnqualified();
}
}
-}
+} break;
DavidSpickett wrote:
Could put it inside the `case : { ...}` scope,
DavidSpickett wrote:
Polly pushed in
https://github.com/llvm/llvm-project/commit/788d5a5f1e1263657f0a281545e095769f6b375b.
Only libclc remains.
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/118309
>From 64bfb1cd1bb7aa9e1597c0212dba7067c9f75d9f Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 2 Dec 2024 15:22:50 +
Subject: [PATCH] [libclc] Add Maintainers.md for libclc
---
libclc/Mainta
DavidSpickett wrote:
If you look for:
```
FAILED:
[0mtools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CompileCommands.cpp.o
```
In the build log that's the failure reason.
All of the tests that reported JSON passed, that's why you have green test
reports but failed builds. I wi
DavidSpickett wrote:
> The relevant binaries build, but check-lldb currently hits unrelated errors
> for me blocking any progress in checking those changes.
`ninja check-lldb` passes on AArch64 Linux, and given the changes, it's
unlikely to fail on other platforms.
https://github.com/llvm/llv
DavidSpickett wrote:
My comments have been addressed.
https://github.com/llvm/llvm-project/pull/112714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Libcxx part pushed as
https://github.com/llvm/llvm-project/commit/1bdb0a408f1e2e9f6d5f43b23b4f87f87b3950ab.
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/118309
>From 8398d47a413dfbabb9a4eb96809304c240f4e3ad Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 2 Dec 2024 15:22:50 +
Subject: [PATCH] [llvm] Move sub-project lead maintainers into their own fi
DavidSpickett wrote:
OpenMP part pushed directly:
https://github.com/llvm/llvm-project/commit/2137ded301adb430e0616cd835da9838e4fd79ce
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/118309
>From fe59fcd2c14f7ff84857ad75bc3564cbe6752c9d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 2 Dec 2024 15:22:50 +
Subject: [PATCH] [llvm] Move sub-project lead maintainers into their own fi
DavidSpickett wrote:
It already landed, I'll rebase this PR.
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
@tobiasgrosser
(because for some reason I can't add you as a reviewer directly)
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/118309
>From 9d279bcb1174e80e24ddac8755962cb65e20be91 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 2 Dec 2024 15:22:50 +
Subject: [PATCH 1/2] [llvm] Move sub-project lead maintainers into their ow
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/118309
This adds Maintainers.md files to the sub-projects mentioned here, so that
someone going directly to that sub-project will find them more easily.
Recently I needed to find a libclc maintainer and I had no
@@ -434,29 +433,17 @@ Others only have a lead maintainer listed here.
[Flang
maintainers](https://github.com/llvm/llvm-project/blob/main/flang/Maintainers.txt)
-[LLD
maintainers](https://github.com/llvm/llvm-project/blob/main/lld/CODE_OWNERS.TXT)
-
-[LLDB
maintainers](http
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/117985
Now "Download" will be a link to the file so people don't have to know
to open the build tab and find the download button.
This is a URL from a real build:
https://buildkite.com/organizations/llvm-project/
DavidSpickett wrote:
Thanks, I'll leave it open then, this PR is a welcome improvement regardless.
https://github.com/llvm/llvm-project/pull/117419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
DavidSpickett wrote:
Please check if this fixes https://github.com/llvm/llvm-project/issues/109778
too. Seems very similar.
https://github.com/llvm/llvm-project/pull/117419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/116017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/116017
None
>From 69a3030e61ab5d4483464cd912d78a4e5d24d644 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 13 Nov 2024 09:19:10 +
Subject: [PATCH 1/2] Reland "[ci] New script to generate test report
DavidSpickett wrote:
Abandoning in favour of marking the unique filename option as hidden.
https://github.com/llvm/llvm-project/pull/113896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/113896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/112714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Also I edited the title tags. They aren't an exact science but clang seems the
most appropriate here.
https://github.com/llvm/llvm-project/pull/112714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
@@ -1677,6 +1677,22 @@ MCSection
*TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
/*AddSegmentInfo=*/false))
Kind = SectionKind::getMetadata();
+
+ const Global
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/112714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett commented:
I'm not an expert here but added some generic comments for now. FYI with the
llvm conference last week, many people are still away so review pace is slower
right now.
Since this is a Clang change it should have a release note, I think it can go
in h
@@ -1677,6 +1677,22 @@ MCSection
*TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
/*AddSegmentInfo=*/false))
Kind = SectionKind::getMetadata();
+
+ const Global
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s -triple arm64-windows-msvc
+// expected-no-diagnostics
+#pragma clang section bss = "mybss.1" data = "mydata.1" rodata = "myrodata.1"
text = "mytext.1"
+#pragma clang section bss="" data="" rodata="" text=""
+#pragma cl
@@ -1677,6 +1677,22 @@ MCSection
*TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
/*AddSegmentInfo=*/false))
Kind = SectionKind::getMetadata();
+
+ const Global
@@ -1677,6 +1677,22 @@ MCSection
*TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
/*AddSegmentInfo=*/false))
Kind = SectionKind::getMetadata();
+
+ const Global
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/114394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett commented:
Maybe add " when no -mmcu option is used" to the commit title but otherwise
LGTM.
https://github.com/llvm/llvm-project/pull/114394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
@@ -0,0 +1,328 @@
+# Script to parse many JUnit XML result files and send a report to the
buildkite
+# agent as an annotation.
+#
+# To run the unittests:
+# python3 -m unittest discover -p generate_test_report.py
+
+import argparse
+import unittest
+from io import StringIO
+from
DavidSpickett wrote:
I have updated this PR to include marking the option as hidden. If folks would
be ok with that approach, I will break this up into individual parts for review
and landing separately.
If no, I will work more on the lit wrapper approach.
@boomanaiden154 what do you think to
DavidSpickett wrote:
> FWIW, I didn't mean to derail this effort or create significant additional
> complexity by saying what I said above. My intention was only to point out
> the tradeoff of adding new functionality for a temporary benefit, which
> wasn't clear to me had been thought about i
@@ -0,0 +1,328 @@
+# Script to parse many JUnit XML result files and send a report to the
buildkite
+# agent as an annotation.
+#
+# To run the unittests:
+# python3 -m unittest discover -p generate_test_report.py
+
+import argparse
+import unittest
+from io import StringIO
+from
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/113447
>From e9e79e33f06942e471dca6b727a4cd9cd6fa4563 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 29 Oct 2024 15:38:12 +
Subject: [PATCH 1/4] [llvm][llvm-lit] Hide --use-unique-output-file-name f
DavidSpickett wrote:
I also looked through GitHub code search to see if anyone else was hitting this
same issue.
ROCm avoids it by splitting each check target into its own step:
https://github.com/ROCm/ROCm/blob/bce439ecacc86b7f48934f5cc6be7ce2044412cf/.azuredevops/components/llvm-project.yml#L
DavidSpickett wrote:
I tried a few more things, so I will summarise everything up until this point.
There are two layers here:
1. Making test reports.
2. Producing the XML test results.
Using the buildkite plugin is not an option
(https://github.com/llvm/llvm-project/pull/113290) because we'd
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/113896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/113896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/113896
>From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 23 Oct 2024 11:39:15 +0100
Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/113896
>From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 23 Oct 2024 11:39:15 +0100
Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/113896
>From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 23 Oct 2024 11:39:15 +0100
Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/113896
>From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 23 Oct 2024 11:39:15 +0100
Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/113896
>From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 23 Oct 2024 11:39:15 +0100
Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite
1 - 100 of 630 matches
Mail list logo
