[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

dsanders11 added a comment. Cool stuff! Chiming in randomly here, but I've been keeping a loose eye on the progress of IncludeCleaner. I've been using IncludeCleaner to power include cleanup in the Chromium code base for the past few months, and have built Python scripts around it so I can mor

[PATCH] D90110: [clang-tidy] Use --use-color in run-clang-tidy.py

dsanders11 added a comment. No one has raised any concerns, so if someone with commit access wants to commit this on my behalf it would be appreciated.. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90110/new/ https://reviews.llvm.org/D901

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. In D90109#2366415 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yea, I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90109/new/ https://revi

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. > Oh, how neat. The bug you linked to was closed as a dup of another bug. The > other bug was then closed as something that's not in scope with the general > product direction, whatever that means. Yea, typical Microsoft/Windows fun there. > Yeah, that would be reas

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 updated this revision to Diff 301755. dsanders11 added a comment. code review changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90109/new/ https://reviews.llvm.org/D90109 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-t

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. Herald added a subscriber: dexonsmith. > What issues did you run into regarding testing, because I feel like the patch > should have test coverage (esp given that color vs ANSI escape codes are a > bit of an oddity to reason about)? I'm unable to create a debug build

[PATCH] D90110: Use --use-color in run-clang-tidy.py

dsanders11 created this revision. dsanders11 added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. dsanders11 requested review of this revision. Now that D79477 landed, it's a better user experience to use '--use-color'

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. Added a few inline comments for clarification. **Note**: I was not able to get a debug build and unit tests working on my Windows set up, so this has only been tested manually. I'm not sure if the unit test added in D79477 runs on Wi

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 created this revision. dsanders11 added reviewers: aaron.ballman, njames93. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, xazax.hun. Herald added projects: clang, LLVM. dsanders11 requested review of this revision. On Windows the --use-color option cannot be used for i