[PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG859ebca744e6: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`." (authored by david-salinas). Herald added subscribers: cfe-commits, libc

[PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas abandoned this revision. david-salinas added a comment. Abandoning. Will use D115960 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116547/new/ https://reviews.llvm.org/D116547 _

[PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas created this revision. Herald added subscribers: luke957, abrachet, ormris, foad, dang, jdoerfert, phosek, kerbowa, usaxena95, pengfei, s.egerton, asbirlea, mstorsjo, lebedev.ri, kadircet, rupprecht, arphaman, steven_wu, mgrang, simoncook, fedor.sergeev, hiraditya, krytarowski, ari

[PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas created this revision. Herald added subscribers: luke957, abrachet, ormris, foad, dang, jdoerfert, phosek, kerbowa, usaxena95, pengfei, s.egerton, asbirlea, mstorsjo, lebedev.ri, kadircet, rupprecht, arphaman, steven_wu, mgrang, simoncook, fedor.sergeev, hiraditya, krytarowski, ari

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

david-salinas added a comment. This change has caused a regression for generic C++. Should this affect OpenCL only? The following simple test causes the diagnostic to be emitted: #define ATTR_GLOBAL __attribute__((address_space(1))) int calc(int ATTR_GLOBAL *ip) { int i = *ip; return i+1

[PATCH] D53780: Fix bitcast to address space cast for coerced load/stores

david-salinas updated this revision to Diff 172673. david-salinas added a comment. fix missing ; Repository: rC Clang https://reviews.llvm.org/D53780 Files: lib/CodeGen/CGCall.cpp test/CodeGenCXX/address-space-cast-coerce.cpp Index: test/CodeGenCXX/address-space-cast-coerce.cpp ===

[PATCH] D53780: Fix bitcast to address space cast for coerced load/stores

david-salinas updated this revision to Diff 172671. david-salinas added a comment. using CreateElementBitCast instead Repository: rC Clang https://reviews.llvm.org/D53780 Files: lib/CodeGen/CGCall.cpp test/CodeGenCXX/address-space-cast-coerce.cpp Index: test/CodeGenCXX/address-space-ca

[PATCH] D53780: Fix bitcast to address space cast for coerced load/stores

david-salinas updated this revision to Diff 172261. david-salinas added a comment. As per rjmccall's comments, changed the call to CreatePointerBitCastOrAddrSpaceCast back to a call to CreateBitCast, but now we're casting to the int8* with the address space of the target. https://reviews.llvm.

[PATCH] D53780: Fix bitcast to address space cast for coerced load/stores

david-salinas updated this revision to Diff 171367. david-salinas added a comment. remove __attribute__((cpu)) __attribute__((hc)) from test Repository: rC Clang https://reviews.llvm.org/D53780 Files: lib/CodeGen/CGCall.cpp test/CodeGenCXX/address-space-cast-coerce.cpp Index: test/Code

[PATCH] D53780: Fix bitcast to address space cast for coerced load/stores

david-salinas created this revision. david-salinas added reviewers: yaxunl, scchan. Herald added a subscriber: cfe-commits. Coerced load/stores through memory do not take into account potential address space differences when it creates its bitcasts. Repository: rC Clang https://reviews.llvm