[clang] [OpenMP][Docs] Update OpenMP supported features table (PR #126292)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/126292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Docs] Update OpenMP supported features table (PR #126292)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/126292 Updated status to 'done' for OpenMP 6.0 features: - OpenMP directives in concurrent loop regions - atomics constructs on concurrent loop regions - Lift nesting restriction on concurrent loop Removed duplic

[clang] [llvm] [clang][OpenMP] New OpenMP 6.0 assumption clause, 'no_openmp_constructs' (PR #125933)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/125933 >From 86069865d3ae356593c7a28f99cc1a4ec53f3120 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Thu, 30 Jan 2025 10:53:30 -0600 Subject: [PATCH 1/2] [clang][OpenMP] New OpenMP 6.0 assumption clause, 'no_openmp_c

[clang] [llvm] [clang][OpenMP] New OpenMP 6.0 assumption clause, 'no_openmp_construc… (PR #125933)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/125933 …ts'. Add initial parsing/sema support for new assumption clause so clause can be specified. For now, it's ignored, just like the others. Added support for 'no_openmp_construct' to release notes. Testing - Up

[clang] [clang][OpenMP] OpenMP 6.0 updates to restrictions with order/concurrent (PR #125621)

ddpagan wrote: @alexey-bataev - question: I didn't see an approval from you but the PR says that I can merge. Did I miss something? https://github.com/llvm/llvm-project/pull/125621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [clang][OpenMP] OpenMP 6.0 updates to restrictions with order/concurrent (PR #125621)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/125621 >From deffda7ca37661781f1bae565ac8ae4a8fbba674 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Fri, 31 Jan 2025 16:12:08 -0600 Subject: [PATCH 1/3] [clang][OpenMP] OpenMP 6.0 updates to restrictions with order/

[clang] [clang][OpenMP] OpenMP 6.0 updates to restrictions with order/concurrent (PR #125621)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/125621 >From OpenMP 6.0 features list - OpenMP directives in concurrent loop regions - atomics constructs on concurrent loop regions - Lift nesting restriction on concurrent loop Testing - Updated test/OpenMP/for_order

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/121814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/121814 >From d2747bc68455a3dab6ffb47da8851fd1db3f59b5 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Fri, 22 Nov 2024 10:35:40 -0600 Subject: [PATCH 1/6] [clang][OpenMP] Add 'align' modifier for 'allocate' clause Th

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/121814 >From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Fri, 22 Nov 2024 10:35:40 -0600 Subject: [PATCH 1/6] [clang][OpenMP] Add 'align' modifier for 'allocate' clause Th

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/121814 >From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Fri, 22 Nov 2024 10:35:40 -0600 Subject: [PATCH 1/5] [clang][OpenMP] Add 'align' modifier for 'allocate' clause Th

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

ddpagan wrote: Made changes requested by Alexey. https://github.com/llvm/llvm-project/pull/121814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/121814 >From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Fri, 22 Nov 2024 10:35:40 -0600 Subject: [PATCH 1/4] [clang][OpenMP] Add 'align' modifier for 'allocate' clause Th

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

ddpagan wrote: Thanks for reviewing, Alexey. Made the requested changes. https://github.com/llvm/llvm-project/pull/121814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/121814 >From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Fri, 22 Nov 2024 10:35:40 -0600 Subject: [PATCH 1/3] [clang][OpenMP] Add 'align' modifier for 'allocate' clause Th

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

@@ -5285,6 +5285,7 @@ static void checkAllocateClauses(Sema &S, DSAStackTy *Stack, } for (OMPClause *C : AllocateRange) { auto *AC = cast(C); +// TODO: Check alignment? ddpagan wrote: Old note to myself. As far as I know there aren't any checks r

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

ddpagan wrote: > Update OpenMPSupport.rst New 'align' modifier added to implemented features list. https://github.com/llvm/llvm-project/pull/121814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/121814 >From c2c2c4c46c3ea615e86484b9f9a14a74fab21295 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Fri, 22 Nov 2024 10:35:40 -0600 Subject: [PATCH 1/2] [clang][OpenMP] Add 'align' modifier for 'allocate' clause Th

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

ddpagan wrote: NOTE: OpenMP Support doc will be updated as well in a subsequent patch. https://github.com/llvm/llvm-project/pull/121814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add 'align' modifier for 'allocate' clause (PR #121814)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/121814 The 'align' modifier is now accepted in the 'allocate' clause. Added LIT tests covering codegen, PCH, template handling, and serialization for 'align' modifier. Added support for align-modifier to release note

[clang] [clang][OpenMP][NFC] Move 'allocate' clause modifier parsing into fun… (PR #115775)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/115775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP][NFC] Move 'allocate' clause modifier parsing into fun… (PR #115775)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/115775 …ction Parsing of 'allocate' clause modifier ('allocator') has been moved into a separate function in anticipation of adding another modifier ('align'). >From 78e9809b743f74207dfab2e2271d91a04b2f75ca Mon Sep 1

[clang] [OpenMP][Docs] Update OpenMP supported features table (PR #115106)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/115106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add 'allocator' modifier for 'allocate' clause. (PR #114883)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/114883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add 'allocator' modifier for 'allocate' clause. (PR #114883)

ddpagan wrote: @alexey-bataev - I'll make that change in the next PR. Thanks for the review. https://github.com/llvm/llvm-project/pull/114883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][OpenMP] Add 'allocator' modifier for 'allocate' clause. (PR #114883)

@@ -2242,9 +2247,16 @@ void OMPClausePrinter::VisitOMPAllocateClause(OMPAllocateClause *Node) { if (Node->varlist_empty()) return; OS << "allocate"; + OpenMPAllocateClauseModifier Modifier = Node->getAllocatorModifier(); if (Expr *Allocator = Node->getAllocator())

[clang] [clang][OpenMP] Add 'allocator' modifier for 'allocate' clause. (PR #114883)

https://github.com/ddpagan updated https://github.com/llvm/llvm-project/pull/114883 >From 0959f99f541f7e10e3f761b062948f2408afc0fd Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Mon, 14 Oct 2024 15:27:56 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Add 'allocator' modifier for 'allocate' clause

[clang] [clang][OpenMP] Add 'allocator' modifier for 'allocate' clause. (PR #114883)

@@ -4539,6 +4539,8 @@ bool Parser::ParseOpenMPVarList(OpenMPDirectiveKind DKind, bool NeedRParenForLinear = false; BalancedDelimiterTracker LinearT(*this, tok::l_paren, tok::annot_pragma_openmp_end); + BalancedDelimiterTracker AllocateT(*

[clang] [OpenMP][Docs] Update OpenMP release notes with 'omp scope' (PR #109752)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/109752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Docs] Update OpenMP release notes with 'omp scope' (PR #109752)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/109752 Release notes: added 'omp scope' directive to "OpenMP Support" section of "What's New in Clang" >From 6ded6531f20d4f2a8eee5e0263d2ff87da17e8d8 Mon Sep 17 00:00:00 2001 From: Dave Pagan Date: Mon, 23 Sep 2024 2

[clang] [OpenMP][Docs] Update OpenMP supported features table (PR #109726)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/109726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Docs] Update OpenMP supported features table (PR #109726)

ddpagan wrote: Thanks, Alexey. I'll do that. https://github.com/llvm/llvm-project/pull/109726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Docs] Update OpenMP supported features table (PR #109726)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/109726 OpenMP features table: updated scope directive status from 'worked on' to 'done' in section OpenMP 5.1 Implementation Details. >From 1827e1189aaaf2dc3945a744e249ea77b4acc6c0 Mon Sep 17 00:00:00 2001 From: Dave

[clang] [llvm] [clang][OpenMP] Add codegen for scope directive (PR #109197)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/109197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Add codegen for scope directive (PR #109197)

@@ -0,0 +1,2267 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --include-generated-funcs --replace-value-regex "__omp_offloading_[0-9a-z]+_[0-9a-z]+" "reduction_size[.].+[.]" "pl_cond[.].+[.|,]" --prefix-filechec

[clang] [llvm] [clang][OpenMP] Add codegen for scope directive (PR #109197)

@@ -0,0 +1,2267 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --include-generated-funcs --replace-value-regex "__omp_offloading_[0-9a-z]+_[0-9a-z]+" "reduction_size[.].+[.]" "pl_cond[.].+[.|,]" --prefix-filechec

[clang] [clang][OpenMP][NFC] Remove unnecessary nullptr check (PR #94680)

https://github.com/ddpagan commented: LGTM. https://github.com/llvm/llvm-project/pull/94680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #87278)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/87278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

@@ -1537,6 +1537,12 @@ class CodeGenModule : public CodeGenTypeCache { void printPostfixForExternalizedDecl(llvm::raw_ostream &OS, const Decl *D) const; + /// Under debug mode, print status of target teams loop transformation, + /// w

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

@@ -11311,6 +11311,10 @@ class Sema final { OpenMPDirectiveKind &Kind, OpenMPDirectiveKind &PrevMappedDirective); + /// [target] teams loop is equivalent to parallel for if associated loop + /// nest meets certain critera. + b

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

ddpagan wrote: After some additional discussion with Alexey offline, he concluded that the current changes are okay, specifically for this reason: _"Then I realized that actually it does not require AST nodes building. In this case, this helper class should be moved to CodeGenStmt and hidden i

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

ddpagan wrote: Ping. https://github.com/llvm/llvm-project/pull/72417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

@@ -6106,6 +6106,8 @@ class OMPTeamsGenericLoopDirective final : public OMPLoopDirective { class OMPTargetTeamsGenericLoopDirective final : public OMPLoopDirective { friend class ASTStmtReader; friend class OMPExecutableDirective; + /// true if loop directive's associated

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

@@ -6106,6 +6106,8 @@ class OMPTeamsGenericLoopDirective final : public OMPLoopDirective { class OMPTargetTeamsGenericLoopDirective final : public OMPLoopDirective { friend class ASTStmtReader; friend class OMPExecutableDirective; + /// true if loop directive's associated

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

ddpagan wrote: Ping. https://github.com/llvm/llvm-project/pull/72417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [mlir] [clang] [compiler-rt] [clang-tools-extra] [llvm] [OpenMP] atomic compare fail : Codegen support (PR #75709)

https://github.com/ddpagan commented: Aside from Alexey's comments, LGTM. https://github.com/llvm/llvm-project/pull/75709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

@@ -7485,6 +7485,99 @@ void CodeGenModule::printPostfixForExternalizedDecl(llvm::raw_ostream &OS, } } +namespace { +/// A 'teams loop' with a nested 'loop bind(parallel)' or generic function +/// call in the associated loop-nest cannot be a 'parllel for'. +class TeamsLoopCh

[clang] [clang][OpenMP] Fix target data if/logical expression assert fail (PR #70268)

https://github.com/ddpagan closed https://github.com/llvm/llvm-project/pull/70268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix target data if/logical expression assert fail (PR #70268)

https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/70268 Fixed assertion failure Basic Block in function 'main' does not have terminator! label %land.end caused by premature setting of CodeGenIP upon entry to emitTargetDataCalls, where subsequent evaluation of lo