[PATCH] D81072: [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools.

2020-10-21 Thread David Kilzer via Phabricator via cfe-commits
ddkilzer added a comment. Herald added a subscriber: steakhal. Thanks for implementing this! For posterity, I wanted to note a couple cases that this checker doesn't catch. 1. Under ARC, a more general case of assigning to an `__autoreleasing` variable. (Not sure why anyone would do this, but

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

2019-05-15 Thread David Kilzer via Phabricator via cfe-commits
ddkilzer added a comment. Had a couple questions about using `objc_retainAutoreleasedReturnValue` without a `return` statement. (I'm just reading this from a layman's point of view; it may not actually matter in practice.) Comment at: test/CodeGenObjC/convert-messages-to-run