[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

davidtgoldblatt added a comment. This version of the commit also introduces some breakages; as before I'm not sure if it's the code or the diff that's incorrect. Repro: enum class Enum { E1 }; template inline constexpr bool some_concept = true; template struct S { template

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

davidtgoldblatt added a comment. This breaks ~the world in the versions of libstdc++ I can easily check -- see e.g. https://gcc.godbolt.org/z/ETeGzc3ve (crashes at this commit, changes to an error at ce861ec782ae3f41807b61e855512aaccf3c2149

[PATCH] D147021: [Builtins] Add __builtin_implicit_object_fence.

davidtgoldblatt created this revision. Herald added subscribers: jeroen.dobbelaere, kosarev. Herald added a project: All. davidtgoldblatt updated this revision to Diff 509069. davidtgoldblatt added a comment. davidtgoldblatt added a reviewer: rsmith. davidtgoldblatt published this revision for revi

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 507133. davidtgoldblatt added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/docs/LanguageExtensions.rst clang/docs/Releas

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the same struct, elements of the same array, +etc.). bruno w

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 501315. davidtgoldblatt added a comment. Use utils/update_cc_test_checks.py for the codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: cla

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added a comment. In addition to the release notes addition, I also added an entry in LanguageExtensions.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 __

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 501297. davidtgoldblatt added a comment. Per comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/docs/LanguageExtensions.rst clang/docs

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added a comment. Summarizing a brief offline discussion: I think it's probably fine to just get rid of the SemaChecking changes entirely; type-checking here is done by the generalized builtin-handling code. I'll do the change if there's no objection. Repository: rG LLVM Githu

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 481770. davidtgoldblatt added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.def clang/includ

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 481481. davidtgoldblatt added a comment. Per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 478394. davidtgoldblatt added a comment. Fix out-of-date comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/include/clang/Basic/Builtins.

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt created this revision. Herald added a project: All. davidtgoldblatt updated this revision to Diff 476281. davidtgoldblatt added a comment. davidtgoldblatt updated this revision to Diff 476283. davidtgoldblatt retitled this revision from "[builtins] add separate storage builtin supp

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

davidtgoldblatt added a comment. (For background: I'm a jemalloc maintainer and wrote N2293). In D100879#3145361 , @rjmccall wrote: > Platforms are permitted to make stronger guarantees than the C standard > requires, and it is totally reasonable for co