[PATCH] D51120: clang-format Additional Indent for class blocks

2018-09-25 Thread Darby Payne via Phabricator via cfe-commits
dpayne added a comment. @djasper @klimek Are there any comments here about this approach? Repository: rC Clang https://reviews.llvm.org/D51120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D51120: clang-format Additional Indent for class blocks

2018-09-18 Thread Darby Payne via Phabricator via cfe-commits
dpayne updated this revision to Diff 166057. dpayne added a comment. Adding the missing Style member variable. Repository: rC Clang https://reviews.llvm.org/D51120 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLinePars

[PATCH] D51120: clang-format Additional Indent for class blocks

2018-08-22 Thread Darby Payne via Phabricator via cfe-commits
dpayne updated this revision to Diff 162129. dpayne added a comment. Adding unit tests to check indents, these were mostly taken from the original patch https://reviews.llvm.org/D22505. Repository: rC Clang https://reviews.llvm.org/D51120 Files: docs/ClangFormatStyleOptions.rst lib/Form

[PATCH] D51120: clang-format Additional Indent for class blocks

2018-08-22 Thread Darby Payne via Phabricator via cfe-commits
dpayne created this revision. dpayne added reviewers: klimek, djasper. Herald added subscribers: cfe-commits, mgorny. Hi, This is another attempt at fixing the issue describe here https://reviews.llvm.org/D22505. Some code bases will have an extra indent for member variables and functions, whil

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

2018-04-06 Thread Darby Payne via Phabricator via cfe-commits
dpayne added a comment. Hi Bumping this commit. I do not have commit access so I cannot merge myself, if you have the time could you merge this commit? Repository: rC Clang https://reviews.llvm.org/D43957 ___ cfe-commits mailing list cfe-commit

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

2018-03-21 Thread Darby Payne via Phabricator via cfe-commits
dpayne added a comment. I'll make sure to do the full diff in the future. I did that for the first patch but forgot to do it in the follow up patch, I won't make that mistake in the future. I do not have commit access so I cannot merge myself. When you have the time could you merge this change

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

2018-03-20 Thread Darby Payne via Phabricator via cfe-commits
dpayne updated this revision to Diff 139212. dpayne added a comment. Adding a unit test for formatting a global namespace var with SpacesInParentheses enabled. Repository: rC Clang https://reviews.llvm.org/D43957 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Ind

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

2018-03-01 Thread Darby Payne via Phabricator via cfe-commits
dpayne created this revision. dpayne added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. When SpacesInParentheses is set to true clang-format does not add a space before a global namespace variable. For example this is the output of clang-format for a somewhat contrived exa