[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

2017-03-07 Thread Daphne Pfister via Phabricator via cfe-commits
daphnediane added a comment. ping https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

2017-02-20 Thread Daphne Pfister via Phabricator via cfe-commits
daphnediane added a comment. Rebuilt with the latest patch and got one compile error. See line comment worked okay after fixing it. Comment at: lib/Format/WhitespaceManager.cpp:215 + +if (i != Start) { + if (Changes[i].nestingAndIndentLevel() > These

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

2017-02-06 Thread Daphne Pfister via Phabricator via cfe-commits
daphnediane added a comment. In https://reviews.llvm.org/D21279#667471, @bmharper wrote: > Thanks @daphnediane. I only read your comment after merging, but that would > have been helpful. If you still want my diff let me know as it is slightly different from yours. No longer has NestingAndInd

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

2017-02-04 Thread Daphne Pfister via Phabricator via cfe-commits
daphnediane added a comment. ping. I've been using this for a long time and still seems to apply to cleanly and works, though the line numbers have shifted a little since I generated the previous diff. https://reviews.llvm.org/D24703 ___ cfe-commi

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

2017-02-04 Thread Daphne Pfister via Phabricator via cfe-commits
daphnediane added a comment. In https://reviews.llvm.org/D21279#663670, @bmharper wrote: > Thanks - the merge conflicts don't look too bad. I should have it cleaned up > by tomorrow. Have you had a chance to do the merge yet? If not I have a merged version which passes the tests that I could