[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. In D129973#3684940 , @yvvan wrote: > With this change we don't pass "LocInfo" directly and it seems to break the > locations when calling "getCXXOperatorNameRange" for this DeclRefExpr later > on. Please fix it. You can intr

[PATCH] D130799: [clang] Keep declaration name info in DeclRefExpr

SimplyDanny created this revision. SimplyDanny added a reviewer: yvvan. Herald added a subscriber: arphaman. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without it `getCXXOperatorNameRange` retur

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG0734c02b34e4: [clang-tidy] Avoid extra parentheses around MemberExpr (authored by SimplyDanny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/ ht

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

SimplyDanny added a comment. alexfh, aaron.ballman, njames93, LegalizeAdulthood Could anyone give some feedback, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/ https://reviews.llvm.org/D129596 __

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e94f6653150: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads (authored by SimplyDanny). Changed prior to commit: https://rev

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. In D129973#3673094 , @SimplyDanny wrote: > Thank you for the review! Before I push the change into main I may add an > entry to `clang/docs/ReleaseNotes.rst`, right? > > And do you agree that the test failures are unrelated

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny added a comment. Thank you for the review! Before I push the change into main I may add an entry to `clang/docs/ReleaseNotes.rst`, right? And do you agree that the test failures are unrelated to my change? It looks like they are all located in `libomptarget` caused by a linker error

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446718. SimplyDanny added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 Files: clang-tools-extra/test/clang-tidy/checkers/misc/un

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446629. SimplyDanny added a comment. Rebased commit onto current main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 Files: clang-tools-extra/test/clan

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:65 +// CHECK-NEXT: |-ImplicitCastExpr {{.*}} 'void (*)(E, E)' +// CHECK-NEXT: | `-DeclRefExpr {{.*}} 'void (E, E)' lvalue

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang/test/Index/annotate-operator-call-expr.cpp:21 +// CHECK1: Punctuation: "(" [7:6 - 7:7] CallExpr=operator():3:7 +// CHECK1: Punctuation: ")" [7:7 - 7:8] CallExpr=operator():3:7 // C

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446592. SimplyDanny added a comment. Herald added a subscriber: arphaman. Added a test for the AST dump and updated some test references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://re

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny created this revision. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. SimplyDanny requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Without the "found declaration" it is

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

SimplyDanny created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/55

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:250-253 +- Made the fix-it of :doc:`cppcoreguidelines-init-variables + ` use ``false`` to initialize + boolean variables. + nja

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny added a comment. In D129420#3640482 , @njames93 wrote: > Can you add a line to release notes about this fix then LGTM Sure. Thank you for the fast review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e212954430: [clang-tidy] Initialize boolean variables with `false` in cppcoreguidelines… (authored by SimplyDanny). Changed prior to commit: https://reviews.llvm.org/D129420?vs=443429&id=443434#toc R

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny added a comment. This is a potential fix for this issue . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129420/new/ https://reviews.llvm.org/D129420 __

[PATCH] D129420: [clang-tidy] Initialize boolean variables with 'false' in cppcoreguidelines-init-variables' fix-it

SimplyDanny created this revision. SimplyDanny added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subsc

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny marked 3 inline comments as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of sizeof pointer 'sizeof(T)/sizeof(T)' -int

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of sizeof pointer 'sizeof(T)/sizeof(T)' -int Test3() { return Foo<42>() + Bar(); } +templa

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny added a comment. In D122544#3411226 , @aaron.ballman wrote: > LGTM! Can you also add a release note for the fix? > > I'm happy to land this on your behalf if you'd prefer, but given that you've > had several quality commits already, you migh

[PATCH] D122544: Utilize comparison operation implemented in APInt

This revision was automatically updated to reflect the committed changes. Closed by commit rGff60af91ac0b: [clang-tidy] Utilize comparison operation implemented in APInt (authored by SimplyDanny). Changed prior to commit: https://reviews.llvm.org/D122544?vs=418450&id=418709#toc Repository: r

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny created this revision. SimplyDanny added a reviewer: njames93. Herald added a subscriber: carlosgalvezp. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is a fix for #539

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. @tonic, can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 ___ cfe-commits mailing list cfe-commits@

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny added a comment. In D120187#3375610 , @aaron.ballman wrote: > LGTM, but please wait a day or two before landing in case @njames93 has > further concerns. Would you merge the changes, @aaron.ballman? Seems like there are no objections from

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. In D121078#3373139 , @philnik wrote: > In D121078#3373081 , @SimplyDanny > wrote: > >> I'm happy that you found a reasonable compromise. I like it too. ;) >> >> Now, I ask you to help

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. I'm happy that you found a reasonable compromise. I like it too. ;) Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a "n

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny updated this revision to Diff 413642. SimplyDanny added a comment. Removed duplicate target names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 Files: clang-tools-extra/README.txt clang

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. In D121078#3363856 , @aaron.ballman wrote: > I think we need to retain *some* references to the existing mailing list > archives. The migration to Discourse worked fairly well, but there were still > data migration issues.

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added inline comments. Comment at: clang/README.txt:22 If you have questions or comments about Clang, a great place to discuss them is -on the Clang development mailing list: - http://lists.llvm.org/mailman/listinfo/cfe-dev +in the Clang forum: + https://discourse.

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny updated this revision to Diff 413630. SimplyDanny marked 9 inline comments as done. SimplyDanny added a comment. Updated revision according to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.ll

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny added a comment. Herald added a project: All. What else can be done to get this change approved, @njames93? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120187/new/ https://reviews.llvm.org/D120187

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny created this revision. SimplyDanny added a reviewer: tonic. Herald added subscribers: libcxx-commits, arphaman. Herald added a reviewer: sscalpone. Herald added projects: libunwind, Flang, All. Herald added a reviewer: libunwind. SimplyDanny requested review of this revision. Herald add

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:100 + EXPECT_TRUE(!!Options); + EXPECT_EQ("-*,misc-*\nllvm-*\n-clang-*,\ngoogle-*\n", *Options->Checks); +} -

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny marked 2 inline comments as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:100 + EXPECT_TRUE(!!Options); + EXPECT_EQ("-*,misc-*\nllvm-*\n-clang-*,\ngoogle-*\n", *Options->Checks); +} -

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny updated this revision to Diff 410102. SimplyDanny added a comment. Update according to comments in review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120187/new/ https://reviews.llvm.org/D120187 Files: clang-tools-extra/clang-tidy/

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny created this revision. SimplyDanny added a reviewer: alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. SimplyDanny requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. This is a fix for #53737. In additi