[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4553727 , @aaron.ballman wrote: > In D155809#4553694 , @danlark wrote: > >> In D155809#4553690 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4553690 , @aaron.ballman wrote: > In D155809#4551876 , @danlark wrote: > >> In D155809#4551721 , @cor3ntin >> wrote: >> >>> I think t

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4551721 , @cor3ntin wrote: > I think the test we want is a set of classes and virtuaal fuc > > In D155809#4551686 , @philnik wrote: > >> @aaron.ballman I think what @danlark mea

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4550711 , @aaron.ballman wrote: > In D155809#4550700 , @danlark wrote: > >> In D155809#4550682 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a subscriber: ldionne. danlark added a comment. In D155809#4550682 , @aaron.ballman wrote: > In D155809#4550674 , @danlark wrote: > >> In D155809#4550663 ,

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4550663 , @aaron.ballman wrote: > In D155809#4550654 , @danlark wrote: > >> In D155809#4550646 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4550646 , @aaron.ballman wrote: > In D155809#4527890 , @danlark wrote: > >> In D155809#4527847 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155809/new/ https://reviews.llvm.org/D155809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4527847 , @aaron.ballman wrote: > In D155809#4527199 , @danlark wrote: > >> In D155809#4521494 , @rsmith wrote: >> >>> This looks corr

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4521494 , @rsmith wrote: > This looks correct to me, but it's still a little subtle. Perhaps it'd be > clearer to map the method to an integer (0 for copy assignment, 1 for move > assignment, 2 for destructor, 3 for e

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark updated this revision to Diff 542492. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155809/new/ https://reviews.llvm.org/D155809 Files: clang/lib/AST/VTableBuilder.cpp Index: clang/lib/AST/VTableBuilder.cpp ==

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark created this revision. Herald added a project: All. danlark requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In sorting elements can compare with themselves and sometimes assert further down the line was triggered Repository: rG

[PATCH] D116037: [clang-include-fixer] Fix incorrect ranking because of dangling references

danlark created this revision. danlark added reviewers: alexfh, klimek. Herald added subscribers: arphaman, mgrang. danlark requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. SymbolAndSignals stores SymbolInfo which stores two std:

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added a comment. Failure looks unrelated, please submit on your behalf as I don't have commit rights Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 __

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345568. danlark added a comment. - Address comment from Richard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseExprCXX.cpp clang/lib/

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added a comment. In D102502#2759900 , @rsmith wrote: > Thanks, nice catch! > > Can we also add an assert when parsing a `for` statement that we actually > find a range if the tentative parse said we were expecting one? Done. Repository: rG L

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345561. danlark added a comment. - Add assert of finding a for range declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseExprCXX

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added inline comments. Comment at: clang/test/CodeGenCXX/for-loop-init-ternary-operator-statement.cpp:1 +// RUN: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o - %s | FileCheck %s + rsmith wrote: > We don't use `-O3` tests for this kind of thi

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345536. danlark marked 3 inline comments as done. danlark added a comment. - Add codegen and AST tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark added a comment. Done, please, take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark updated this revision to Diff 345460. danlark added a comment. - Add codegen and AST tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseTentative.cpp clang/test/

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark updated this revision to Diff 345458. danlark added a comment. - Add codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseTentative.cpp clang/test/CodeGenCX

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark added a comment. In D102502#2759776 , @lebedev.ri wrote: > This should have codegen, and maybe AST, tests. Will add shortly Comment at: clang/test/Parser/cxx2a-init-statement.cpp:18 + for (int i = 0; int x = i < 2 ? 1 : 0;

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark created this revision. danlark added a reviewer: rsmith. danlark requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix ternary operator in for loop argument, it was by mistake not set as CanBeForRangeDecl and led to incorrect codegen

[PATCH] D97000: [clang] Increase the bitness of data length in ASTDeclContextNameLookup

danlark abandoned this revision. danlark added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97000/new/ https://reviews.llvm.org/D97000 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D97000: [clang] Increase the bitness of data length in ASTDeclContextNameLookup

danlark created this revision. danlark added a reviewer: rsmith. danlark requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We faced the assert of too many declarations for serialized lookup for a very generated C++ target. We think moving th

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark marked an inline comment as done. danlark added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do hiraditya wrote: > danlark wrote: > > lichray wro

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark added a comment. In D44823#1375590 , @mclow.lists wrote: > I just tried this (on Compiler Explorer) using LLVM 7, and the code for my > original test in https://bugs.llvm.org/show_bug.cgi?id=35637 is now optimal. > Looking briefly at your test ca

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark added inline comments. Herald added a subscriber: ldionne. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do lichray wrote: > mclow.lists wrote: > > I have been ask

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

danlark created this revision. danlark added reviewers: EricWF, mclow.lists. Herald added subscribers: cfe-commits, christof. Consider the following code. #include #include class TestClass { public: TestClass(size_t size) : Data(size) { } private: