[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple amdgcn-am

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple amdgcn-am

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added a comment. Needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115283/new/ https://reviews.llvm.org/D115283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed8e0caab9b: [NFC] Reduce include files dependency and AA header cleanup (part 2). (authored by dfukalov). Changed prior to commit: https://revie

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org/D92852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added inline comments. Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:685 + } +} + RKSimon wrote: > This should probably be pulled out too It uses `dyn_cast(I)` so clang-tidy reports //incomplete type 'llvm::CallBase' named in nested name specifier//

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov updated this revision to Diff 310509. dfukalov edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org/D92852 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/examples/Bye/Bye.

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov updated this revision to Diff 310506. dfukalov added a comment. Splitting change as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org/D92852 Files: llvm/include/llvm/Analysis/AliasAnalysis.h

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added inline comments. Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:800 case Instruction::Invoke: - return getModRefInfo((const InvokeInst *)I, Loc, AAQIP); + return getModRefInfo((const CallBase *)I, Loc, AAQIP); case Instruction::CatchPad:

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added inline comments. Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:66 class Value; +class TargetLibraryInfo; Just realized wrong order, will fix in updated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov created this revision. dfukalov added a reviewer: RKSimon. Herald added subscribers: kerbowa, asbirlea, jfb, steven_wu, george.burgess.iv, zzheng, hiraditya, eraman, nhaehnle, jvesely, arsenm, MatzeB. dfukalov requested review of this revision. Herald added projects: clang, LLVM. Herald a

[PATCH] D82764: [NFC] Fixed ignored .hip test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc722ffc749: [NFC] Fixed ignored .hip test. (authored by dfukalov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82764/new/ https://reviews.llvm.org/D8276

[PATCH] D82764: [NFC] Fixed ignored .hip test.

dfukalov created this revision. dfukalov added a reviewer: hliao. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82764 Files: clang/test/CodeGenHIP/lit.local.cfg Index: clang/test/CodeGenHIP/lit.lo

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

dfukalov abandoned this revision. dfukalov added a comment. I was completely wrong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82650/new/ https://reviews.llvm.org/D82650 ___ cfe-commits mailing list

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

dfukalov planned changes to this revision. dfukalov added a comment. In D82650#2116849 , @yaxunl wrote: > I think the point of -ffp-contract=fast is that it allows emitting fma across > statements if there are such opportunities whereas -ffp-contract=on o

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

dfukalov created this revision. dfukalov added reviewers: yaxunl, b-sumner, rampitec. Herald added subscribers: cfe-commits, Anastasia. Herald added a project: clang. With the FAST default FP_CONTRACT mode' setting for `func(float a, float b, float c) { return a + b * c; }` FE generates pair `fmul

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC332848: [AMDGPU] fixes for lds f32 builtins (authored by dfukalov, committed by ). Changed prior to commit: https://reviews.llvm.org/D43281?vs=142412&id=147801#toc Repository: rC Clang https://revie

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov updated this revision to Diff 142412. dfukalov edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D43281 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-amdgcn-vi.cl test/SemaOpenCL/builtins-am

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. ping... Repository: rC Clang https://reviews.llvm.org/D43281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. ping... Repository: rC Clang https://reviews.llvm.org/D43281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. > My real question was what happens if you put 11 in the description string? in this case CanT.getAddressSpace() returns target addrspace value "20" (also shifted in the enum by 9==LangAS::FirstTargetAddressSpace) So again ASTContext::getAddrSpaceQualType decieds that

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. ping... Repository: rC Clang https://reviews.llvm.org/D43281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov updated this revision to Diff 136752. dfukalov edited the summary of this revision. dfukalov set the repository for this revision to rC Clang. dfukalov added a comment. addrspace specifications are kept in descriptions strings Repository: rC Clang https://reviews.llvm.org/D43281 Fil

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. The problem is that if set addrspace "2" in description string, CanT.getAddressSpace() returns target addrspace value "11" (shifted in the enum) and compares it with input LangAS addrspace ("2", "opencl_local" in our case). So I cannot set a number a description string

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. In https://reviews.llvm.org/D43281#1018657, @arsenm wrote: > Can’t you just change the description to be the LangAS value? I also thought > these happened to be the same already Am I right that you mean to change the semantic of the addrspace number in a description

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov marked an inline comment as done. dfukalov added a comment. ping... https://reviews.llvm.org/D43281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov marked an inline comment as done. dfukalov added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:9866 + case AMDGPU::BI__builtin_amdgcn_ds_fmax: { +llvm::SmallVector Args; +for (unsigned I = 0; I != 5; ++I) b-sumner wrote: > Can the point

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov updated this revision to Diff 134503. dfukalov edited the summary of this revision. dfukalov added a comment. diff updated as requested by reviewer https://reviews.llvm.org/D43281 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov created this revision. dfukalov added reviewers: b-sumner, arsenm. dfukalov added a project: AMDGPU. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl. 1. removed addrspace 3 specifications from builtins description strings since it's not tar

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions (authored by dfukalov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42578 Files: include/clang/Basic/BuiltinsAMDGPU

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions (authored by dfukalov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42578

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

dfukalov updated this revision to Diff 131820. dfukalov added a comment. fixed builtins descriptions Repository: rC Clang https://reviews.llvm.org/D42578 Files: include/clang/Basic/BuiltinsAMDGPU.def test/CodeGenOpenCL/builtins-amdgcn-vi.cl Index: test/CodeGenOpenCL/builtins-amdgcn-vi.

[PATCH] D42578: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

dfukalov updated this revision to Diff 131593. dfukalov retitled this revision from "[AMDGPU] Add ds_fadd builtin function" to "[AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions". dfukalov added a comment. Sorry, missed them Repository: rC Clang https://reviews.llvm.org/D42578 Files

[PATCH] D42578: [AMDGPU] Add ds_fadd builtin function

dfukalov created this revision. dfukalov added reviewers: arsenm, b-sumner. dfukalov added a project: AMDGPU. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl. Repository: rC Clang https://reviews.llvm.org/D42578 Files: include/clang/Basic/Built