[PATCH] D126974: [scan-build-py] Fix exception on shutdown with sarif-html output format

isthismyaccount accepted this revision. isthismyaccount added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126974/new/ https://reviews.llvm.org/D126974 _

[PATCH] D107887: scan-build-py: Force the opening in utf-8

isthismyaccount accepted this revision. isthismyaccount added a comment. This revision is now accepted and ready to land. Seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107887/new/ https://reviews.llvm.org/D107887 __

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount updated this revision to Diff 351308. isthismyaccount added a comment. Rebased to hopefully resolve merge issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CM

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount commandeered this revision. isthismyaccount edited reviewers, added: aabbaabb; removed: isthismyaccount. isthismyaccount added a comment. Grabbing this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 _

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount added a comment. Thanks for the reviews. I'll take over this and try to get the merge conflicts resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing list

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

isthismyaccount accepted this revision. isthismyaccount added a comment. This revision is now accepted and ready to land. LGTM on my part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commit

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 272052. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/Clang

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 3 inline comments as done. Daniel599 added a comment. I fixed all as your comments suggested, thanks :) If this patch is ready, can someone commit it on my behalf please? (I don't have write permissions) Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked an inline comment as done. Daniel599 added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added a comment. Any additional changes/fixes regarding this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked an inline comment as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:777 + "or make sure they are both configured the same. " + "Aliased checkers: '{

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 268055. Daniel599 added a comment. Added `StringMap::operator!=` and also unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:250 void removeIncompatibleErrors(); + void removeDuplicatedFixesOfAliasCheckers(); maybe I need to rename this method since now it's removing the errors

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 2 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:51 bool IsWarningAsError; + std::vector EnabledDiagnosticAliases; }; njames93 wrote: > Just ignore this, but d

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267489. Daniel599 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsu

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267478. Daniel599 added a comment. Thank you @njames93, I already started and took a bit different approach. In case of a conflict, leaving it to clang-tidy itself didn't help as it added both of the fix-its together resulting in `= 0{};`, so I thought it w

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267455. Daniel599 added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. I have made the needed changes in order to detect a conflict in duplicated fix-it of aliased checkers and also added a test for it. Now I`ll

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added a comment. In D80753#2062586 , @aaron.ballman wrote: > In D80753#2061565 , @njames93 wrote: > > > It may be worth verifying that the fix-its are identical too, multiple > > versions of a check coul

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267058. Daniel599 marked an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/Cl

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 4 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:3 + +#include +namespace std { Eugene.Zelenko wrote: > cstdio. Please also separate w

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267056. Daniel599 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangT

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 created this revision. Daniel599 added reviewers: alexfh, hokein. Daniel599 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, Charusso, xazax.hun. Herald added a project: clang. when both a check and its alias are enabled, we should only take the fixes of one of

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1727503 , @aaron.ballman wrote: > Thank you for the patch! I've commit on your behalf in > e477988309dbde214a6d16ec690a416882714aac > Thank you

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1723629 , @aaron.ballman wrote: > Do you need someone to commit this on your behalf? Yes I would like to. Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 226403. Daniel599 added a comment. removed curly braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files: clang-tools-extra/clang-tidy/readability/IdentifierNa

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 marked an inline comment as done. Daniel599 added a comment. Hi, any updates regarding my patch? issues to fix? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 __

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 224783. Daniel599 added a comment. Added check for macro definition, please re-review the enum `ShouldFixStatus` as now I use it as a switch-case within the diagnostic message. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 marked an inline comment as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:868 + if (CheckNewIdentifier != Idents.end() && + CheckNewIdentifier->second->isKeyword(getLangOpts())) { +

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 224151. Daniel599 added a comment. code-review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamin

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 marked 3 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:868 + if (CheckNewIdentifier != Idents.end() && + CheckNewIdentifier->second->isKeyword(getLangOpts())) { +

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1699288 , @MyDeveloperDay wrote: > > I saw this issue when I submitted mine > > (https://bugs.llvm.org/show_bug.cgi?id=43306) which for now seems to be a > > harder fix, still looking for a solution there. > > oh boy

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 added a comment. In D68539#1696864 , @MyDeveloperDay wrote: > I logged the original bug and I like it! > > I think the warning is better than mutating with a prefix, Thank you. > > I'll let the code owners approve it, but you have my vote! gla

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 223429. Daniel599 added a comment. added -U99 to diff cmd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files: clang-tools-extra/clang-tidy/readability/Identi

[PATCH] D68539: [clang-tidy] fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 updated this revision to Diff 223372. Daniel599 added a comment. code fixes according to code-review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68539/new/ https://reviews.llvm.org/D68539 Files: clang-tools-extra/clang-tidy/

[PATCH] D68539: fix for readability-identifier-naming incorrectly fixes variables which become keywords

Daniel599 created this revision. Daniel599 added reviewers: llvm-commits, alexfh, alexfh_. Daniel599 added projects: clang-tools-extra, LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. Daniel599 edited the summary of this revision. This patch fixes 'Bug 41120' https://b