[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ruoso added a comment. Currently, no. I think we do need a paper to discuss the requirements of the remote execution protocol and how they relate to the implementation of C++ modules. The simple summary is that one way that remote execution is implemented is by just wrapping the compiler execu

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ruoso added a comment. FWIW, having a differently named argument for output files and input files is very important for tooling. In particular, in the case of remote execution, it makes a huge difference being able to tell what are the inputs and outputs by looking at the arguments alone, so I

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ruoso accepted this revision. ruoso added a comment. Thanks for taking my last minute suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ruoso added a comment. I just noticed that the document was implying that Header Units were separate from the Standard C++ Modules, but they are an integral part of the language in the specification of modules. The contrast that we do is between "Named Modules" and "Header Units". I did some ed

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:338-339 + +If we want to create libraries for the BMIs, we can't wrap these BMIs directly. +We must compile these BMIs(``*.pcm``) into object files(``*.o``) and wrap these object files. +

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:309 + +Remember to compile and link BMIs +~ I think this is a bit confusing. The BMI is not linked... Maybe something like: "Remember that modules still ha

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:70-76 +* Primary module interface unit. + +* Module implementation unit. + +* Module partition interface unit. + +* Module partition implementation unit. ChuanqiXu wrote: > ruoso wrote: >

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:225 + +It is possible to generate a module file for an importable module unit by specifying the ``--precompile`` option. + Likewise, here the term "Built Module Interface file", with the

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:70-76 +* Primary module interface unit. + +* Module implementation unit. + +* Module partition interface unit. + +* Module partition implementation unit. The terminology here is a bit diff