[PATCH] D57930: [Driver] Verify GCCInstallation is valid

2019-02-11 Thread Daniel Mentz via Phabricator via cfe-commits
danielmentz marked an inline comment as done. danielmentz added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:259-260 if (GCCInstallation.getParentLibPath().find("opt/rh/devtoolset") != StringRef::npos) // With devtoolset on RHEL, we want to

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

2019-02-07 Thread Daniel Mentz via Phabricator via cfe-commits
danielmentz created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Values returned by GCCInstallation.getParentLibPath() and GCCInstallation.getTriple() are not valid unless GCCInstallation.isValid() returns true. This has previously been ignored, and the for