Author: djasper
Date: Wed Aug 15 12:07:55 2018
New Revision: 339803
URL: http://llvm.org/viewvc/llvm-project?rev=339803&view=rev
Log:
clang-format: Change Google style wrt. the formatting of empty messages.
Before:
message Empty {
}
After:
message Empty {}
Modified:
cfe/trunk/lib/Form
Author: djasper
Date: Thu Mar 22 07:43:54 2018
New Revision: 328201
URL: http://llvm.org/viewvc/llvm-project?rev=328201&view=rev
Log:
clang-format: Narrow down raw string literal line break exception.
For multiline raw string literals, we generally want to respect the
author's choice of linebreak
Author: djasper
Date: Thu Mar 22 07:30:28 2018
New Revision: 328200
URL: http://llvm.org/viewvc/llvm-project?rev=328200&view=rev
Log:
clang-format: Fix SpacesInParentheses with fully qualified names.
When SpacesInParentheses is set to true clang-format does not add a
space before fully qualified
Author: djasper
Date: Mon Mar 12 03:32:18 2018
New Revision: 327255
URL: http://llvm.org/viewvc/llvm-project?rev=327255&view=rev
Log:
clang-format: Properly handle implicit string concatenation in text protos
Three issues to fix:
- char_constants weren't properly treated as string literals
- Prev
Author: djasper
Date: Mon Mar 12 03:11:30 2018
New Revision: 327253
URL: http://llvm.org/viewvc/llvm-project?rev=327253&view=rev
Log:
Don't re-format raw string literal contents when formatting is disable
Not entirely sure this is the best place to put this check, but it fixes
the immediate issue
Author: djasper
Date: Fri Feb 23 22:57:47 2018
New Revision: 326024
URL: http://llvm.org/viewvc/llvm-project?rev=326024&view=rev
Log:
Remove unused variable. We should be warning-free.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/
Author: djasper
Date: Fri Feb 23 22:54:09 2018
New Revision: 326023
URL: http://llvm.org/viewvc/llvm-project?rev=326023&view=rev
Log:
Make module use diagnostics refer to the top-level module
All use declarations need to be directly placed in the top-level module
anyway, knowing the submodule doe
Author: djasper
Date: Fri Nov 10 09:11:18 2017
New Revision: 317901
URL: http://llvm.org/viewvc/llvm-project?rev=317901&view=rev
Log:
[clang-format] Handle leading comments in using declaration
This fixes clang-format internal assertion for the following code:
/* override */ using std::string;
Author: djasper
Date: Mon Nov 6 04:11:51 2017
New Revision: 317473
URL: http://llvm.org/viewvc/llvm-project?rev=317473&view=rev
Log:
[clang-format] Handle unary operator overload with arguments and specifiers
Before:
int operator++(int)noexcept;
After:
int operator++(int) noexcept;
Patch b
Author: djasper
Date: Wed Oct 11 00:47:54 2017
New Revision: 315439
URL: http://llvm.org/viewvc/llvm-project?rev=315439&view=rev
Log:
Revert r314955: "Remove PendingBody mechanism for function and ObjC method
deserialization."
This is breaking a build of https://github.com/abseil/abseil-cpp and
Author: djasper
Date: Mon Sep 11 00:35:01 2017
New Revision: 312897
URL: http://llvm.org/viewvc/llvm-project?rev=312897&view=rev
Log:
Revert r312830: "Reinstall the patch "Use EmitPointerWithAlignment to get
alignment information of the pointer used in atomic expr"."
This triggers llvm.org/PR316
Hi Rafael,
could you write slightly more extensive commit messages? This really
doesn't say anything..
Thank you,
Daniel
On Fri, Sep 8, 2017 at 2:01 AM, Rafael Espindola via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rafael
> Date: Thu Sep 7 17:01:26 2017
> New Revision: 312766
Author: djasper
Date: Thu Sep 7 06:45:41 2017
New Revision: 312721
URL: http://llvm.org/viewvc/llvm-project?rev=312721&view=rev
Log:
[clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine
The current description of AllowAllParametersOfDeclarationOnNextLine in
the Clang-Fo
Author: djasper
Date: Mon Sep 4 06:33:52 2017
New Revision: 312484
URL: http://llvm.org/viewvc/llvm-project?rev=312484&view=rev
Log:
clang-format: Fix indentation of macros in include guards (after r312125).
Before:
#ifndef A_H
#define A_H
#define A() \
int i;\
int j;
#endif //
Author: djasper
Date: Sun Sep 3 01:56:24 2017
New Revision: 312437
URL: http://llvm.org/viewvc/llvm-project?rev=312437&view=rev
Log:
clang-format: Fix formatting of for loops with multiple increments.
This fixes llvm.org/PR34366.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/tru
Author: djasper
Date: Fri Aug 25 12:14:53 2017
New Revision: 311792
URL: http://llvm.org/viewvc/llvm-project?rev=311792&view=rev
Log:
[Format] Invert nestingAndIndentLevel pair in WhitespaceManager used for
alignments
Indent should be compared before nesting level to determine if a token
is on th
Author: djasper
Date: Wed Aug 16 23:33:46 2017
New Revision: 311070
URL: http://llvm.org/viewvc/llvm-project?rev=311070&view=rev
Log:
Fix undefined behavior that is caused by not always initializing a bool.
The fix in r310994 is incomplete, as moveFromAndCancel can set the
pointer without initial
Author: djasper
Date: Fri Jun 30 01:02:37 2017
New Revision: 306804
URL: http://llvm.org/viewvc/llvm-project?rev=306804&view=rev
Log:
Fix heap use after free introduced by r306769.
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
h
Author: djasper
Date: Mon Jun 19 02:45:41 2017
New Revision: 305667
URL: http://llvm.org/viewvc/llvm-project?rev=305667&view=rev
Log:
clang-format: Improve understanding of combined typedef+record declarations
Fixes an issue where struct A { int X; }; would be broken onto multiple
lines, but type
Author: djasper
Date: Mon Jun 19 02:40:49 2017
New Revision: 305666
URL: http://llvm.org/viewvc/llvm-project?rev=305666&view=rev
Log:
clang-format: Handle "if constexpr".
c++1z adds the following constructions to the language:
if constexpr (cond)
statement1;
else if constexpr (cond)
Author: djasper
Date: Mon Jun 19 02:30:04 2017
New Revision: 305665
URL: http://llvm.org/viewvc/llvm-project?rev=305665&view=rev
Log:
clang-format: Add capability to format the diff on save in vim.
With this patch, one can configure a BufWrite hook that will make the
clang-format integration comp
Author: djasper
Date: Fri Jun 16 14:29:20 2017
New Revision: 305574
URL: http://llvm.org/viewvc/llvm-project?rev=305574&view=rev
Log:
Ignore return value in test.
Modified:
cfe/trunk/test/Driver/m_and_mm.c
Modified: cfe/trunk/test/Driver/m_and_mm.c
URL:
http://llvm.org/viewvc/llvm-project/c
Author: djasper
Date: Thu Jun 15 04:17:12 2017
New Revision: 305456
URL: http://llvm.org/viewvc/llvm-project?rev=305456&view=rev
Log:
Revert "Define _GNU_SOURCE for rtems c++"
This reverts commit r305399.
This breaks a build in libcxx:
libcxx/src/system_error.cpp:90:16: error: assigning to 'int'
Author: djasper
Date: Mon Jun 12 03:08:18 2017
New Revision: 305182
URL: http://llvm.org/viewvc/llvm-project?rev=305182&view=rev
Log:
Revert r305164/5/7.
cc1as does not currently access the "--" version of this flag. At the
very least this needs to be fixed and proper test cases need to be
added.
Author: djasper
Date: Mon May 15 02:51:10 2017
New Revision: 303037
URL: http://llvm.org/viewvc/llvm-project?rev=303037&view=rev
Log:
Revert r302965 - [modules] When creating a declaration, cache its owning
module immediately
Also revert dependent r302969. This is leading to crashes.
Will provide
This was leading to many crashers. Reverted in r303037.
On Sat, May 13, 2017 at 1:27 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Fri May 12 18:27:00 2017
> New Revision: 302965
>
> URL: http://llvm.org/viewvc/llvm-project?rev=302965&view=rev
> L
Author: djasper
Date: Mon May 8 10:08:00 2017
New Revision: 302428
URL: http://llvm.org/viewvc/llvm-project?rev=302428&view=rev
Log:
[clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding
DontAlign
This converts the clang-format option AlignEscapedNewlinesLeft from a
boolean to an en
Author: djasper
Date: Wed May 3 06:27:34 2017
New Revision: 302012
URL: http://llvm.org/viewvc/llvm-project?rev=302012&view=rev
Log:
Undo turning ExtBehavior into a bitfield.
This produces warnings that I can't explain in a GCC build:
In file included from ../tools/clang/include/clang/Lex/LexDi
Author: djasper
Date: Wed May 3 02:48:27 2017
New Revision: 302003
URL: http://llvm.org/viewvc/llvm-project?rev=302003&view=rev
Log:
Silences gcc's -Wnarrowing.
I think this is a false positive in GCC's warning, but nonetheless, we
should try to be warning-free. Smaller reproducer (reproduces wi
Author: djasper
Date: Tue May 2 14:21:42 2017
New Revision: 301963
URL: http://llvm.org/viewvc/llvm-project?rev=301963&view=rev
Log:
Revert r301822 (and dependent r301825), which tried to improve the
handling of constexprs with unknown bounds.
This triggers a corner case of the language where it
I forgot the () in the lambda definition, this should be:
..
auto l = [this] { auto l = []() EXCLUSIVE_LOCKS_REQUIRED(mu_) {}; };
..
Doesn't change the fact that clang segfaults without this revert, though.
On Tue, May 2, 2017 at 2:38 PM, Daniel Jasper via cfe-commits <
cfe
Author: djasper
Date: Tue May 2 07:38:27 2017
New Revision: 301916
URL: http://llvm.org/viewvc/llvm-project?rev=301916&view=rev
Log:
Revert r301735 (and subsequent r301786).
It leads to clang crashing, e.g. on this short code fragment (added to
test/SemaCXX/warn-thread-safety-parsing.cpp):
cl
I'll revert this as it makes the following snippet makes clang crash:
class SomeClass {
public:
void foo() {
auto l = [this] { auto l = [] EXCLUSIVE_LOCKS_REQUIRED(mu_) {}; };
}
Mutex mu_;
};
(e.g. this can be added to test/SemaCXX/warn-thread-safety-parsing.cpp)
>From a brief look at
Author: djasper
Date: Mon Apr 24 09:28:49 2017
New Revision: 301182
URL: http://llvm.org/viewvc/llvm-project?rev=301182&view=rev
Log:
clang-format: Fix bad corner case in formatting of function types.
Before:
std::function<
LngTemplatedType*(
Long
Author: djasper
Date: Wed Apr 19 01:06:38 2017
New Revision: 300661
URL: http://llvm.org/viewvc/llvm-project?rev=300661&view=rev
Log:
clang-format: Properly match parens of macro parameter lists.
No tests yet, but this will be tested by the upcoming:
https://reviews.llvm.org/D28462
Modified:
Author: djasper
Date: Fri Mar 31 08:30:24 2017
New Revision: 299214
URL: http://llvm.org/viewvc/llvm-project?rev=299214&view=rev
Log:
clang-format: Fix post-commit review comment of r299204, use Style.isCpp().
Also, while at it, s/IsCpp/isCpp/ so that it follows LLVM style.
Modified:
cfe/tru
Author: djasper
Date: Fri Mar 31 07:04:37 2017
New Revision: 299204
URL: http://llvm.org/viewvc/llvm-project?rev=299204&view=rev
Log:
clang-format: [JavaScript] Ignore QT keywords.
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
cfe/trunk/unittests/Format/FormatTestJS.cpp
Modified
Author: djasper
Date: Mon Mar 27 11:29:41 2017
New Revision: 298853
URL: http://llvm.org/viewvc/llvm-project?rev=298853&view=rev
Log:
Look through CXXBindTemporaryExprs when checking CXXFunctionCastExprs
for unused values.
This fixes a regression caused by r298676, where constructor calls to
clas
-Wunused-value is always triggered if a constructor of an object with a
non-trivial destructor has an initializer list as first parameter. So in
the test, even "Used({});" triggers -Wunused-value. That seems inconsistent
(replacing the init list with something else silences the warning) and also
th
Hi Richard,
this seems to have an unwanted side-effect on -Wunused-value (test case
attached). Could you take a look?
Cheers,
Daniel
On Fri, Mar 24, 2017 at 2:14 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Mar 23 20:14:25 2017
> New Revisi
Author: djasper
Date: Thu Mar 16 02:54:11 2017
New Revision: 297931
URL: http://llvm.org/viewvc/llvm-project?rev=297931&view=rev
Log:
clang-format: Fix bug in wrapping behavior of operators.
Before (even violating the column limit):
auto Diag =
diag()
<< (aaa
Author: djasper
Date: Mon Mar 13 19:40:32 2017
New Revision: 297696
URL: http://llvm.org/viewvc/llvm-project?rev=297696&view=rev
Log:
clang-format: Make it very slighly more expensive to wrap between "= {".
This prevents unwanted fallout from r296664. Specifically in proto formatting,
this change
Author: djasper
Date: Wed Mar 8 03:49:12 2017
New Revision: 297268
URL: http://llvm.org/viewvc/llvm-project?rev=297268&view=rev
Log:
clang-format: Get slightly better at understanding */&.
Before:
void f() { MACRO(A * const a); }
After:
void f() { MACRO(A *const a); }
Modified:
cfe/tru
On Mon, Mar 6, 2017 at 6:29 PM, Krasimir Georgiev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: krasimir
> Date: Mon Mar 6 11:29:25 2017
> New Revision: 297034
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297034&view=rev
> Log:
> [clang-format] Add tests for ambiguous namespa
Author: djasper
Date: Wed Mar 1 13:47:28 2017
New Revision: 296664
URL: http://llvm.org/viewvc/llvm-project?rev=296664&view=rev
Log:
clang-format: [JS] Properly format object literals with shorthands.
Before:
return {
a,
b: 'b', c,
};
After:
return {
a,
b: 'b',
c,
};
Author: djasper
Date: Wed Mar 1 13:26:12 2017
New Revision: 296659
URL: http://llvm.org/viewvc/llvm-project?rev=296659&view=rev
Log:
clang-format: [JS/TS] Properly understand cast expressions.
Many things were wrong:
- We didn't always allow wrapping after "as", which can be necessary.
- We used
Author: djasper
Date: Wed Mar 1 05:10:11 2017
New Revision: 296608
URL: http://llvm.org/viewvc/llvm-project?rev=296608&view=rev
Log:
Fix r296605 so that stuff in #ifndef SWIG blocks is still formatted.
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
cfe/trunk/unittests/Format/Form
Author: djasper
Date: Wed Mar 1 04:47:52 2017
New Revision: 296605
URL: http://llvm.org/viewvc/llvm-project?rev=296605&view=rev
Log:
clang-format: Ignore contents of #ifdef SWIG .. #endif blocks.
Those blocks are used if C++ code is SWIG-wrapped (see swig.org) and
usually do not contain C++ code
Author: djasper
Date: Tue Feb 28 12:28:15 2017
New Revision: 296499
URL: http://llvm.org/viewvc/llvm-project?rev=296499&view=rev
Log:
clang-format: [Java] Fix bug in enum formatting.
Before:
public enum VeryLongEnum {
ENUM_WITH_MANY_PARAMETERS("aa",
Author: djasper
Date: Mon Feb 20 08:51:16 2017
New Revision: 295663
URL: http://llvm.org/viewvc/llvm-project?rev=295663&view=rev
Log:
clang-format: [JS] Improve line-wrapping behavior of template strings.
Specifically, similar to other blocks, clang-format now wraps both
after "${" and before the
Author: djasper
Date: Mon Feb 20 06:43:48 2017
New Revision: 295659
URL: http://llvm.org/viewvc/llvm-project?rev=295659&view=rev
Log:
clang-format: Prevent weird line-wraps in complex lambda introducers
Before:
a.(
[a
Author: djasper
Date: Mon Feb 20 06:43:41 2017
New Revision: 295658
URL: http://llvm.org/viewvc/llvm-project?rev=295658&view=rev
Log:
clang-format: [JS/TS] Improve detection for array subscripts in types.
Before:
var someValue = (v as [
]).someFunction(
Author: djasper
Date: Fri Feb 17 04:44:07 2017
New Revision: 295437
URL: http://llvm.org/viewvc/llvm-project?rev=295437&view=rev
Log:
clang-format: Don't remove existing spaces between identifier and ::.
This can lead to bad behavior with macros that are used to annotate
functions (e.g. ALWAYS_IN
Author: djasper
Date: Tue Feb 7 15:38:16 2017
New Revision: 294358
URL: http://llvm.org/viewvc/llvm-project?rev=294358&view=rev
Log:
clang-format: Fix bad variable declaration detection.
Before:
LongType
variable(nullptr, [](A *a) {});
After:
LongType
Author: djasper
Date: Mon Feb 6 04:55:49 2017
New Revision: 294179
URL: http://llvm.org/viewvc/llvm-project?rev=294179&view=rev
Log:
clang-format: Fix bug with conflicting BreakBeforeBinaryOperations and
AlignAfterOpenBracket
Fix for the formatting options combination of
BreakBeforeBinaryOperat
Author: djasper
Date: Fri Feb 3 08:32:38 2017
New Revision: 294009
URL: http://llvm.org/viewvc/llvm-project?rev=294009&view=rev
Log:
clang-format: [JS] Fix bugs in parsing and aligning template strings.
Modified:
cfe/trunk/lib/Format/ContinuationIndenter.cpp
cfe/trunk/lib/Format/TokenAnn
Author: djasper
Date: Fri Feb 3 02:29:02 2017
New Revision: 293995
URL: http://llvm.org/viewvc/llvm-project?rev=293995&view=rev
Log:
clang-format: [Proto] Also supports implicit string literal concatenation
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/Form
Author: djasper
Date: Thu Feb 2 02:30:21 2017
New Revision: 293875
URL: http://llvm.org/viewvc/llvm-project?rev=293875&view=rev
Log:
clang-format: Do not use two-argument/operand special case with no alignment
Without alignment, there is no clean separation between the arguments, even if
there a
Author: djasper
Date: Wed Feb 1 17:27:37 2017
New Revision: 293839
URL: http://llvm.org/viewvc/llvm-project?rev=293839&view=rev
Log:
clang-format: Fix incorrect line breaks after forced operator wraps.
Before:
bool x = a //
||
b
//
|| ;
Author: djasper
Date: Wed Feb 1 04:00:10 2017
New Revision: 293754
URL: http://llvm.org/viewvc/llvm-project?rev=293754&view=rev
Log:
Fix Index test after recent clang-format change.
Modified:
cfe/trunk/test/Index/overriding-ftemplate-comments.cpp
Modified: cfe/trunk/test/Index/overriding-ft
Author: djasper
Date: Wed Feb 1 03:23:39 2017
New Revision: 293752
URL: http://llvm.org/viewvc/llvm-project?rev=293752&view=rev
Log:
clang-format: Don't force-wrap multiline RHSs for 2-operand experssions.
This rows back on r288120, r291801 and r292110. I apologize in advance
for the churn. All
Author: djasper
Date: Tue Jan 31 08:39:33 2017
New Revision: 293636
URL: http://llvm.org/viewvc/llvm-project?rev=293636&view=rev
Log:
clang-format: [JS] Indent expressions in ${} relative to their surrounding
This only affects expressions inside ${} scopes of template strings.
Here, we want to in
Author: djasper
Date: Tue Jan 31 07:03:07 2017
New Revision: 293622
URL: http://llvm.org/viewvc/llvm-project?rev=293622&view=rev
Log:
clang-format: [JS] Properly set scopes inside template strings.
Before:
var f = `a:${aaa
.a}
a:
Author: djasper
Date: Tue Jan 31 06:07:35 2017
New Revision: 293618
URL: http://llvm.org/viewvc/llvm-project?rev=293618&view=rev
Log:
clang-format: [JS] Fix incorrect line break in template strings.
Before:
var f = ` ${a ? 'a' : 'b'
}`;
After:
var f = ` ${
Author: djasper
Date: Tue Jan 31 05:25:01 2017
New Revision: 293616
URL: http://llvm.org/viewvc/llvm-project?rev=293616&view=rev
Log:
[clang-format] Refactor WhitespaceManager and friends
The main motivation behind this is to cleanup the WhitespaceManager and
make it more extensible for future al
Author: djasper
Date: Mon Jan 30 01:08:40 2017
New Revision: 293465
URL: http://llvm.org/viewvc/llvm-project?rev=293465&view=rev
Log:
clang-format: [JavaScript] Undo r291974 for JavaScript.
This had significant negative consequences and I don't have a good
solution for it yet.
Before:
var stri
Author: djasper
Date: Mon Jan 16 07:43:46 2017
New Revision: 292116
URL: http://llvm.org/viewvc/llvm-project?rev=292116&view=rev
Log:
Fix test failures after recent clang-format format change.
Modified:
cfe/trunk/test/Index/overriding-ftemplate-comments.cpp
Modified: cfe/trunk/test/Index/ove
Author: djasper
Date: Mon Jan 16 07:13:15 2017
New Revision: 292110
URL: http://llvm.org/viewvc/llvm-project?rev=292110&view=rev
Log:
clang-format: Always wrap before multi-line parameters/operands.
Before:
aa(, aaa::
Sorry, for the noise.
This is probably not the revision that caused this.
On Mon, Jan 16, 2017 at 1:08 AM, Daniel Jasper wrote:
> This patch seems to break on some of our code. Reproducer:
>
> $ cat /tmp/ctor.cc
> template
> struct A {
> A() {}
> };
>
> template
> class B : T {
> using T::
This patch seems to break on some of our code. Reproducer:
$ cat /tmp/ctor.cc
template
struct A {
A() {}
};
template
class B : T {
using T::T;
};
struct C {
B> d;
C(A b) : d(b) {}
};
djasper@dj:~/llvm/release$ bin/clang -cc1 -std=c++11 /tmp/ctor.cc
/tmp/ctor.cc:13:17: error: no matchi
Author: djasper
Date: Fri Jan 13 17:18:16 2017
New Revision: 291974
URL: http://llvm.org/viewvc/llvm-project?rev=291974&view=rev
Log:
clang-format: Fix bug in making line break decisions.
Here, the optimization to not line wrap when it would not lead to a
reduction in columns was overwriting and
Author: djasper
Date: Thu Jan 12 14:06:28 2017
New Revision: 291807
URL: http://llvm.org/viewvc/llvm-project?rev=291807&view=rev
Log:
clang-format: Fix regression introduced by r291801.
Uncovered by polly tests.
Before:
aa(aaa,
Author: djasper
Date: Thu Jan 12 13:35:26 2017
New Revision: 291801
URL: http://llvm.org/viewvc/llvm-project?rev=291801&view=rev
Log:
clang-format: Treat braced lists like other complex parameters.
Specifically, wrap before them if they are multi-line so that we don't
create long hanging indents.
Author: djasper
Date: Mon Jan 9 05:04:07 2017
New Revision: 291434
URL: http://llvm.org/viewvc/llvm-project?rev=291434&view=rev
Log:
clang-format: Improve support for override/final as variable names.
Before:
bool a = f() &&override.f();
bool a = f() &&final.f();
void f(const MyOverride &
Author: djasper
Date: Mon Jan 2 16:55:45 2017
New Revision: 290842
URL: http://llvm.org/viewvc/llvm-project?rev=290842&view=rev
Log:
Remove isIgnored()-test that is more expensive than the analysis behind it
In many translation units I have tried, the calls to isIgnored() removed
in this patch a
Author: djasper
Date: Thu Dec 22 06:37:06 2016
New Revision: 290337
URL: http://llvm.org/viewvc/llvm-project?rev=290337&view=rev
Log:
clang-format: Less eagerly try to keep label-value pairs on a line.
Before:
string v =
StrCat("aaa: ", SomeFunction(,
Author: djasper
Date: Wed Dec 21 11:02:06 2016
New Revision: 290259
URL: http://llvm.org/viewvc/llvm-project?rev=290259&view=rev
Log:
clang-format: Fix bug in handling of single-column lists.
Members that are themselves wrapped in fake parentheses would lead to
AvoidBinPacking be set on the wrong
Author: djasper
Date: Tue Dec 20 09:27:46 2016
New Revision: 290177
URL: http://llvm.org/viewvc/llvm-project?rev=290177&view=rev
Log:
clang-format: Fix bug in understanding string-label&value analysis.
While for <<-operators often used in log statments, a single key value
pair is always on the se
Reverted in rL290173.
On Tue, Dec 20, 2016 at 11:02 AM, Daniel Jasper wrote:
> This triggers a bunch of warnings:
>
> lib/AST/Expr.cpp:1519:11: error: enumeration value 'CK_ZeroToOCLQueue'
> not handled in switch [-Werror,-Wswitch]
> lib/CodeGen/CGExprConstant.cpp:654:13: error: enumeration
Author: djasper
Date: Tue Dec 20 04:05:04 2016
New Revision: 290173
URL: http://llvm.org/viewvc/llvm-project?rev=290173&view=rev
Log:
Revert "[OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand."
This reverts commit r290171. It triggers a bunch of warnings, because
the new enumerator
This triggers a bunch of warnings:
lib/AST/Expr.cpp:1519:11: error: enumeration value 'CK_ZeroToOCLQueue'
not handled in switch [-Werror,-Wswitch]
lib/CodeGen/CGExprConstant.cpp:654:13: error: enumeration value
'CK_ZeroToOCLQueue' not handled in switch [-Werror,-Wswitch]
lib/Edit/RewriteObjC
Oh, I completely understand, I am doing the same here :)
On Mon, Dec 19, 2016 at 1:38 PM, Renato Golin
wrote:
> On 19 December 2016 at 12:27, Daniel Jasper wrote:
> > I don't understand. This *is* a revert of the whole patch.
>
> My bad, your revert hadn't gone through:
>
> http://lab.llvm.org:
I don't understand. This *is* a revert of the whole patch.
On Mon, Dec 19, 2016 at 1:26 PM, Renato Golin
wrote:
> On 19 December 2016 at 11:28, Daniel Jasper via cfe-commits
> wrote:
> > I have reverted this in r290092 as it was leading to Clang crashes on the
> >
Author: djasper
Date: Mon Dec 19 05:14:23 2016
New Revision: 290094
URL: http://llvm.org/viewvc/llvm-project?rev=290094&view=rev
Log:
clang-format: Slightly tweak the behavior of <<-wrapping.
Before:
SomeLongLoggingStatementOrMacro() << "Some long text "
<< s
Author: djasper
Date: Mon Dec 19 04:09:25 2016
New Revision: 290092
URL: http://llvm.org/viewvc/llvm-project?rev=290092&view=rev
Log:
Revert "[c++1z] P0195R2: Support pack-expansion of using-declarations."
This reverts commit r290080 as it leads to many Clang crashes, e.g.:
http://lab.llvm.org:80
Author: djasper
Date: Mon Dec 19 02:40:56 2016
New Revision: 290090
URL: http://llvm.org/viewvc/llvm-project?rev=290090&view=rev
Log:
clang-format: Fix regression introduced in r290084.
We still want to try in linewrap within single elements of a 1-column
list.
After:
Type *Params[] = {Pointer
t; SCOP_STAT(NonSimpleMemoryAccess, "Compilated access semantics
> (volatile or "
> "atomic)"
>
> As this worked before, this seems to be a regression.
>
> Best,
> Tobias
>
> On Mon, Dec 19, 2016, at 08:26 A
Author: djasper
Date: Mon Dec 19 01:26:11 2016
New Revision: 290084
URL: http://llvm.org/viewvc/llvm-project?rev=290084&view=rev
Log:
clang-format: Allow "single column" list layout even if that violates the
column limit.
Single-column layout basically means that we format the list with one
eleme
Author: djasper
Date: Tue Dec 13 05:16:42 2016
New Revision: 289531
URL: http://llvm.org/viewvc/llvm-project?rev=289531&view=rev
Log:
clang-format: Keep string-literal-label + value pairs on a line.
We have previously done that for <<-operators. This patch also adds
this logic for "," and "+".
B
Author: djasper
Date: Tue Dec 13 04:05:03 2016
New Revision: 289525
URL: http://llvm.org/viewvc/llvm-project?rev=289525&view=rev
Log:
clang-format: Improve braced-list detection.
Before:
vector v { 12 }
GUARDED_BY(mutex);
After:
vector v{12} GUARDED_BY(mutex);
Modified:
cfe/trunk/
Author: djasper
Date: Mon Dec 12 06:42:29 2016
New Revision: 289428
URL: http://llvm.org/viewvc/llvm-project?rev=289428&view=rev
Log:
clang-format: Separate out a language kind for ObjC.
While C(++) and ObjC are generally formatted the same way and can be
mixed, people might want to choose differ
This is unfortunately causing problems as is, as it can change the
diagnostic that's created when the include of a module with config-mismatch
is inside a namespace. I have tried to fix this for a bit, but I am not
sure what the right solution is. For now, I have reverted this in r288626
and left t
Author: djasper
Date: Sun Dec 4 16:34:37 2016
New Revision: 288626
URL: http://llvm.org/viewvc/llvm-project?rev=288626&view=rev
Log:
Revert "Recover better from an incompatible .pcm file being provided by
-fmodule-file=. We try to include the headers of the module textually in this
case, still
Author: djasper
Date: Tue Nov 29 03:40:32 2016
New Revision: 288120
URL: http://llvm.org/viewvc/llvm-project?rev=288120&view=rev
Log:
clang-format: Wrap complex binary expressions on the RHS of a comma.
Specifically, if the RHS of a comma is a complex binary expression and
spans multiple lines, i
Author: djasper
Date: Tue Nov 29 03:40:36 2016
New Revision: 288121
URL: http://llvm.org/viewvc/llvm-project?rev=288121&view=rev
Log:
clang-format: [JS] Properly format dict literals that skip labels.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTestJ
Author: djasper
Date: Tue Nov 29 03:40:01 2016
New Revision: 288119
URL: http://llvm.org/viewvc/llvm-project?rev=288119&view=rev
Log:
clang-format: Fix unnnecessary line break.
Before:
aa((,
), //
,
a);
After:
aa
Author: djasper
Date: Sat Nov 12 01:38:22 2016
New Revision: 286715
URL: http://llvm.org/viewvc/llvm-project?rev=286715&view=rev
Log:
clang-format: Support ObjC selectors with unnamed parameters.
This fixes llvm.org/PR28063.
Modified:
cfe/trunk/lib/Format/ContinuationIndenter.cpp
cfe/tru
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D26274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
https://reviews.llvm.org/D26163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: djasper
Date: Wed Nov 9 08:12:55 2016
New Revision: 286367
URL: http://llvm.org/viewvc/llvm-project?rev=286367&view=rev
Log:
clang-format: [TypeScript] Fix bug in handling of non-null operator.
Before:
var i = x!-1;
After:
var i = x! - 1;
Modified:
cfe/trunk/lib/Format/TokenAnn
1 - 100 of 731 matches
Mail list logo
