https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/134520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
> I think the static library should be the default (like libclang_rt.builtins).
> Most uses will already use the static library unless they went into the
> effort of building the shared library. Then, flang-rt and flang are
> version-locked without a versioning scheme (`flan
DanielCChen wrote:
> I would generally prefer if we could avoid having driver behavior depend on
> the existance of files, but the linker would also pick an existing file as
> well.
Agreed. The `if (static exists) - else if (shared exists)` logic in this PR is
temporary until we have the comp
DanielCChen wrote:
> Can you please explain why you want to link the static library by default?
> For example, Clang has these options
> https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-static-libgcc
> that allow users to force the static linking, and, I think, by def
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/134362
>From cd100a70479adbb4619d685e345485eea99987c5 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Fri, 4 Apr 2025 06:10:56 -0400
Subject: [PATCH 1/2] [driver] Generalize adding the path of
libflang_rt.runtime
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/134520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/134520
`addArchSpecificRPath` shoudl immediately return for AIX as AIX doesn't support
`rpath` option.
`getArchSpecificLibPaths` also needs to get the triple without the OS version
on AIX.
>From a3583c59f7797a40a
DanielCChen wrote:
> May I ask not to merge this yet? I have a question above, but I will not be
> at work until next Thursday to discuss this in a timely manner.
@vzakhari Sure, I will wait until you come back.
https://github.com/llvm/llvm-project/pull/134362
___
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
DanielCChen wrote:
Sorry that I missed a couple of things. I will bring this back after I hash
them out.
https://github.com/llvm/llvm-project/pull/134297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -109,7 +109,7 @@ if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
extend_path(default_install_path "${COMPILER_RT_INSTALL_PATH}" lib)
set(COMPILER_RT_INSTALL_LIBRARY_DIR "${default_install_path}" CACHE PATH
"Path where built compiler-rt libraries should be instal
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/134362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2,7 +2,7 @@
! invocation. These libraries are added on top of other standard runtime
! libraries that the Clang driver will include.
-! RUN: %flang -### --target=ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 |
FileCheck %s --check-prefixes=CHECK,UNIX,UNIX-F128NONE
+! RUN: %f
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/134362
The PR is to generalize the re-use of the `compilerRT` code of adding the path
of `libflang_rt.runtime.a (so)` from AIX and LoP only to all platforms via a
new function `addFlangRTLibPath`.
Also, PR #1343
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/134297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/134297
As suggested in PR #131041, this PR moves the code of `addFortranRuntimeLibs`
from `PPCLinux.cpp` to `Gnu.cpp` to generalize it for all Linux platform.
>From a7c791a7fe3a0606fc6b79368b32d599bdfbe2fb Mon Sep
DanielCChen wrote:
Seems PR #134320 is fixing this.
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
Still fail at the same `ppc64le-unknown-linux-gnu` target? The reason I am
asking is that I was able to reproduce the failure at line 44. `! BSD-SAME:
-lexecinfo`
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mai
DanielCChen wrote:
@klausler It seems it passes for me on LoP after I pull the latest source.
Could you please try again and see if you still run into the failure?
```
-- Testing: 1 tests, 1 workers --
PASS: Flang :: Driver/linker-flags.f90 (1 of 1)
Exit Code: 0
Command Output (stderr):
--
/sc
DanielCChen wrote:
> LGTM (I'd generalize this more in a follow on though, there's no reason for
> this to be limited to LoP)
Thanks for the suggestion! I will investigate that and post a separate PR.
https://github.com/llvm/llvm-project/pull/131041
DanielCChen wrote:
Hello reviewers,
This PR is an attempt to generalize the current code that re-uses `compilerRT`
in `PPCLinux.cpp` to all Linux platforms.
Could you please comment if that is a feasible approach?
https://github.com/llvm/llvm-project/pull/134297
___
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/131822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
After further internal discussion. we decided to withdraw this PR until we hash
out a few more details.
Thanks everyone for the comments.
https://github.com/llvm/llvm-project/pull/131822
___
cfe-commits mailing list
cfe-commits@list
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131822
>From 28634f01af16c2d0eb9ac12d569d3393dbcc7edf Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Tue, 18 Mar 2025 11:09:41 -0400
Subject: [PATCH 1/3] [Driver] Add linker options to support statical linking
t
@@ -0,0 +1,38 @@
+!! Testing ld command with flang on POWERPC.
+
+!! Because flang-rt currently only supports
+!! LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON, use
+!! resource_dir_with_per_target_subdir as inputs.
+
+! Check powerpc64-ibm-aix 64-bit linking to static flang-rt
+! RUN: %
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From aecfa9e83dd29f7c4a3276633caf70553e2ca1cc Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/14] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 8e94a94094fd3ecfe3554f4e7c1812d8c79ea07d Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/14] [flang-rt] Pass the whole path of libflang_rt.runtime.a
DanielCChen wrote:
> LGTM.
>
> It would be safer/clearer to make the `IsFortran` argument change a separate
> PR...
Good point. I could have made another PR to set `flang-rt` library name only.
Will keep that in mind.
https://github.com/llvm/llvm-project/pull/131041
_
DanielCChen wrote:
Note that the reason `aio.exp` is not needed is because flang-rt currently
doesn't do asynchronous I/O. Once it is enabled using POSIX `aio_*` system
calls, it will need to export those calls.
https://github.com/llvm/llvm-project/pull/131822
DanielCChen wrote:
@MaskRay Could you please let me know if you are OK with this PR or need more
time to review? Thanks!
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131822
>From 21f3ec3b644ea201e3aa15d18f74c795ccf120f3 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Tue, 18 Mar 2025 11:09:41 -0400
Subject: [PATCH 1/3] [Driver] Add linker options to support statical linking
t
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -127,9 +127,19 @@ void aix::Linker::ConstructJob(Compilation &C, const
JobAction &JA,
}
// Force static linking when "-static" is present.
- if (Args.hasArg(options::OPT_static))
+ if (Args.hasArg(options::OPT_static)) {
CmdArgs.push_back("-bnso");
+if (D.
DanielCChen wrote:
@JDPailleux @kiranchandramohan
We are planning to add support for flang to compile 32-bit application as well
as building 32-bit flang-rt on AIX. The first thing would be to enable `-m32`
for flang in the driver. I saw Kiran's comment. Would it be possible to make
`-m32` av
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131822
>From 21f3ec3b644ea201e3aa15d18f74c795ccf120f3 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Tue, 18 Mar 2025 11:09:41 -0400
Subject: [PATCH] [Driver] Add linker options to support statical linking to
sh
@@ -127,9 +127,19 @@ void aix::Linker::ConstructJob(Compilation &C, const
JobAction &JA,
}
DanielCChen wrote:
Thanks for the comment!
Yes. I will add test.
https://github.com/llvm/llvm-project/pull/131822
___
cfe-c
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131822
>From 21f3ec3b644ea201e3aa15d18f74c795ccf120f3 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Tue, 18 Mar 2025 11:09:41 -0400
Subject: [PATCH 1/2] [Driver] Add linker options to support statical linking
t
DanielCChen wrote:
Hello reviewers,
I have rebased the PR to pull the change of enabling `PER_TARGET_RUNTIME_DIR`
on AIX in.
I also added a couple of LIT tests to test the flang-rt path on both AIX and
LoP.
Thanks for your time reviewing the PR!
https://github.com/llvm/llvm-project/pull/13104
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 8e94a94094fd3ecfe3554f4e7c1812d8c79ea07d Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/12] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 8e94a94094fd3ecfe3554f4e7c1812d8c79ea07d Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/13] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/132821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
Thanks to @MaskRay for reviewing the PR and @ldionne for the comments that led
us to find another issue.
Would the reviewers please let me know if you are still reviewing the change? I
am planning to merge it if you have no further comments.
https://github.com/llvm/llvm-pro
DanielCChen wrote:
@ldionne I have checked that on AIX, clang uses the configuration from the
system include as `-internal-isystem /opt/IBM/openxlCSDK/include/c++/v1`. There
is already a test in `aix-toolchain-include.cpp` for that.
https://github.com/llvm/llvm-project/pull/132821
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
@Meinersbur @MaskRay and all other reviewers,
PR #132821 enables `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` on AIX. As a result,
I no longer need to "force" AIX to use `os_dirname` for flang-rt.
The change in this PR is intact because I re-used the same code to handle the
op
DanielCChen wrote:
> I think this should also impact the set of headers being searched. On
> per-target runtimes, I think we look for libc++ headers under
> `include/c++/v1/` in addition to `include/c++/v1` (since that's where
> `__config_site` ends up)? I'm not super familiar with that config
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/132821
>From be03d5cf608498b11dd274ee6294a0c4e83d4c5e Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Mon, 24 Mar 2025 15:45:33 -0400
Subject: [PATCH] [Driver] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX.
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131822
>From 050913081eced8c43eb46ec6ff65aeecda60e3fb Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Tue, 18 Mar 2025 11:09:41 -0400
Subject: [PATCH] [Driver] Add linker options to support statical linking to
sh
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 179c9e995a7c7e32de095f1919fad1f415419f3d Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/12] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
DanielCChen wrote:
I will revert this commit first.
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
The intention is to make this PR for flang-rt only. As discussed with
@daltenty, I remove the NFC-change of adding an overriding `getCompilerRT` in
`AIX.cpp` as it actually breaches into clang space.
https://github.com/llvm/llvm-project/pull/131041
__
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From c394e25b3af722d76338bf7ab02d87de2a23074b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/12] [flang-rt] Pass the whole path of libflang_rt.runtime.a
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 55653ee989d41d4caf5ba5396bb2406dcc443945 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 01/10] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DI
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/10] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/131822
This is to support statical linking to shared `flang-rt` on AIX.
Users should be able to do `flang -static t.f`. The `a.out` generated should
not have dependencies on the shared libraries.
>From 491e6d0cdf
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 95377273d069e76023edf7ecc2df473e4e2f4aaa Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 01/10] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DI
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From c394e25b3af722d76338bf7ab02d87de2a23074b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/11] [flang-rt] Pass the whole path of libflang_rt.runtime.a
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/9] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 01/11] [flang-rt] Pass the whole path of libflang_rt.runtime.a
@@ -101,3 +102,19 @@ bool PPCLinuxToolChain::SupportIEEEFloat128(
return GlibcSupportsFloat128((Twine(D.DyldPrefix) + Linker).str()) &&
!(D.CCCIsCXX() && HasUnsupportedCXXLib);
}
+
+void PPCLinuxToolChain::addFortranRuntimeLibs(
+const ArgList &Args, llvm::opt::A
@@ -1187,16 +1187,19 @@ endif()
# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to
# break things. In this case we need to enable the large-file API as well.
if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
- add_compile_definitions(_XOPEN_S
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/8] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/9] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
DanielCChen wrote:
@arichardson I found the way to override the cache file. Thanks for the
suggestion!
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
DanielCChen wrote:
> Approach look OK to me.
>
> Could you add test(s) along the lines of
> [aix-rlib.c](https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/aix-rtlib.c).
> If we make further changes, knowing what is expected on AIX/PPCLunux would
> be very helpful.
>
> A review
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/7] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/8] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/6] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/5] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/4] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/3] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/2] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON
o
DanielCChen wrote:
> > > Wouldn't it be more maintainable to just force the value to OFF for AIX
> > > where the `option()` is defined?
> >
> >
> > Unfortunately, the cmake command line option
> > `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the
> > cmake file.
>
>
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 9d3e16f3e7c5adf4b5e0c1c6ba861d9e0ffea23b Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/7] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/7] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/6] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/5] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
DanielCChen wrote:
@Meinersbur and all other reviewers,
In the attempt to make building the path of flant-rt more general as well as
customizable in response to the review comment, I made the following change in
this latest commit (sorry about a couple of more commits that fixed some typos).
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/4] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/3] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131041
>From 660ec19fc5f59aa7c08331b5066388f3f5af14b9 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Wed, 12 Mar 2025 18:23:14 -0400
Subject: [PATCH 1/2] [flang-rt] Pass the whole path of libflang_rt.runtime.a
t
DanielCChen wrote:
> Wouldn't it be more maintainable to just force the value to OFF for AIX where
> the `option()` is defined?
Unfortunately, the cmake command line option `-D
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the cmake
file.
https://github.com/llvm/llvm-pro
DanielCChen wrote:
I am working on a patch that re-uses `compilerRT` code as much as possible.
https://github.com/llvm/llvm-project/pull/131041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
DanielCChen wrote:
I will check all those failures and push an update soon.
https://github.com/llvm/llvm-project/pull/131200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/131200
We don't plan to support it on AIX.
This change will make it as if it is set to OFF.
>From 37eb6964a176dd566b3600c0fb15a1d426551729 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23
DanielCChen wrote:
> With this PR applied? It hardcodes `libflang_rt.runtime.a` on AIX, how can it
> find the `.so`?
Sorry, I just realized on AIX, both static and shared library are named `.a`,
which is why it didn't fail for me. But it is not the case for other platforms.
https://github.c
@@ -1345,7 +1345,16 @@ void tools::addFortranRuntimeLibs(const ToolChain &TC,
const ArgList &Args,
if (AsNeeded)
addAsNeededOption(TC, Args, CmdArgs, /*as_needed=*/false);
}
-CmdArgs.push_back("-lflang_rt.runtime");
+if (TC.getTriple().isOSAIX()) {
+
https://github.com/DanielCChen approved this pull request.
LGTM.
Thanks for reverting it.
https://github.com/llvm/llvm-project/pull/117444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/117342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/117342
AIX BuildBot failed due to https://github.com/llvm/llvm-project/pull/116556 as
AIX linker does not support version script.
This PR is to fix the failure
This PR is on behalf of gniko...@ca.ibm.com
>From c
1 - 100 of 121 matches
Mail list logo
