DanBlackwell wrote:
This is also failing on macOS. I'm concerned that this change is now causing a
build error to anyone that includes a C++ container and
`common_interface_defs.h` in the same TU:
```
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.2
@@ -242,6 +255,43 @@ AddressSanitizer also supports
works similar to ``__attribute__((no_sanitize("address")))``, but it also
prevents instrumentation performed by other sanitizers.
+Disabling container overflow checks
+---
+
+Runtime suppressio
@@ -242,6 +255,43 @@ AddressSanitizer also supports
works similar to ``__attribute__((no_sanitize("address")))``, but it also
prevents instrumentation performed by other sanitizers.
+Disabling container overflow checks
+---
+
+Runtime suppressio
@@ -514,11 +514,15 @@ ErrorGeneric::ErrorGeneric(u32 tid, uptr pc_, uptr bp_,
uptr sp_, uptr addr,
}
static void PrintContainerOverflowHint() {
- Printf("HINT: if you don't care about these errors you may set "
- "ASAN_OPTIONS=detect_container_overflow=0.\n"
-
https://github.com/DanBlackwell requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/161304
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1609,7 +1609,12 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList
&Args,
if (Sanitize.needsFuzzer() && !Args.hasArg(options::OPT_dynamiclib)) {
AddLinkSanitizerLibArgs(Args, CmdArgs, "fuzzer", /*shared=*/false);
-// Libfuzzer is written in C++ and
@@ -1609,7 +1609,12 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList
&Args,
if (Sanitize.needsFuzzer() && !Args.hasArg(options::OPT_dynamiclib)) {
AddLinkSanitizerLibArgs(Args, CmdArgs, "fuzzer", /*shared=*/false);
-// Libfuzzer is written in C++ and
https://github.com/DanBlackwell approved this pull request.
Change looks good, and the comment explains the 'confusing' behaviour well.
https://github.com/llvm/llvm-project/pull/161304
___
cfe-commits mailing list
[email protected]
https://lis
https://github.com/DanBlackwell closed
https://github.com/llvm/llvm-project/pull/161304
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanBlackwell wrote:
Note, I also get this warning elsewhere when building compiler-rt:
```
[4118/4568] Linking CXX shared library
lib/clang/22/lib/darwin/libclang_rt.ubsan_osx_dynamic.dylib
ld: warning: ignoring duplicate libraries: '-lc++'
...
[4234/4568] Linking CXX shared library
lib/clang/
10 matches
Mail list logo