LecrisUT wrote:
Ok, can you preface the sentences with a "check if" so it doesn't create
confusions :sweat_smile:
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
LecrisUT wrote:
> Also I barely know anything about how to package this stuff correctly, and
> what the consequences would be if we get it wrong.
Also regarding @Endilll. Nothing can go wrong really. This is still not
connected to the CD and you would need permission from [`clang` pypi
projec
LecrisUT wrote:
> - The python bindings aren't placed in the right folder to import them when
> the package is pip installed
They are *not*? I tried it and it imported fine, same as you noticed.
> - Installing directly from a git URL or source archives for a release won't
> work
Similarly,
https://github.com/LecrisUT edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/LecrisUT approved this pull request.
My review is that it looks good to go for the scope that it serves. Follow up
changes I would recommend is to align the CI and `pyproject.toml` across the
other python projects, but it seems that it has been broken for a while, so
it's a
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,3 @@
+node: $Format:%H$
+node-date: $Format:%cI$
+describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$
LecrisUT wrote:
Awesome findings. I could go either way on if it's expected behaviour or not.
Iirc the current format does not include all ta
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
https://github.com/LecrisUT commented:
Other than missing new-line at the end of file, it looks fine.
License classifiers will soon be (or already are) deprecated, so check up with
setuptools and when they support PEP639.
https://github.com/llvm/llvm-project/pull/125806
___
@@ -0,0 +1,34 @@
+[build-system]
+requires = ["setuptools>=42", "setuptools_scm"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "clang"
+description = "libclang python bindings"
+readme = {file = "README.txt", content-type = "text/plain"}
+
+license = { text = "Apa
@@ -0,0 +1,3 @@
+node: $Format:%H$
+node-date: $Format:%cI$
+describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$
LecrisUT wrote:
Nitpick about the describe tags. Why not be more explicit with
`llvmorg-[0-9]*]`?
Anyway did you double check that it works
https://github.com/LecrisUT edited
https://github.com/llvm/llvm-project/pull/125806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
14 matches
Mail list logo
