Re: [PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

I'll be unavailable the next 2 weeks, feel free to do it if you want! On Fri, Jun 9, 2023, 21:10 Tom Honermann via Phabricator < revi...@reviews.llvm.org> wrote: > tahonermann added a comment. > > @cor3ntin, sorry for failing to keep up with reviews; I know this has > already been committed. I di

Re: [PATCH] D136554: Implement CWG2631

Yes please! However the warning looks correct to me in that case. A constructs x which constructs A etc. On Mon, Jan 16, 2023, 18:00 Chris Bowler via Phabricator < revi...@reviews.llvm.org> wrote: > cebowleratibm added a comment. > > I've reduced a regression on: > > commit ca619613801233ef2def8c

Re: [PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

My plan is to do that for all papers once past plenary to keep consistency with cxx_status. On Tue, Jul 5, 2022 at 6:13 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added reviewers: tahonermann, clang-language-wg. > aaron.ballman added inline comments. > > >

Re: [PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

On Thu, Apr 7, 2022 at 2:11 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In D123298#3435796 , @cor3ntin > wrote: > > > In D123298#3435770 , > @aaron.ballm

Re: [PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

Thanks for the tip! On Fri, Aug 27, 2021 at 9:31 PM Shivam Gupta via Phabricator < revi...@reviews.llvm.org> wrote: > xgupta added a comment. > > (If you pass --draft flag to arc while updating revision it becomes WIP so > you don't need to retitle or remove reviewers. Buildbot also work in that

Re: [PATCH] D106577: [clang] Define __STDC_ISO_10646__

On Fri, Aug 13, 2021 at 7:42 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In D106577#2943837 , @jyknight > wrote: > > > In D106577#2904960 , @rsmith > wro